Commit Graph

2822 Commits

Author SHA1 Message Date
Rachel Fenichel 2eeee8b9af Stop handling keypresses when the workspace is hidden. 2018-08-07 18:03:23 -04:00
Andrew n marshall e064a147c7 Create a common helper function for Comment[Create|Delete]) (PR #1988)
Resolves #1871
2018-08-07 12:54:47 -07:00
Rachel Fenichel 341865c80c Merge pull request #1995 from rachel-fenichel/feature/unplug_horizontal
Heal rows when unplugging, and add tests
2018-08-06 11:28:12 -07:00
Rachel Fenichel b89487e332 Ignore whether parent has multiple inputs 2018-08-06 11:18:00 -07:00
Rachel Fenichel a8d52903e2 update comment with todo 2018-08-06 10:29:12 -07:00
Dhruv 3ab37dbe46 #1871 Create a common helper function for Comment[Create|Delete] 2018-08-07 00:17:55 +08:00
Neil Fraser c6afb08c4b Add unit tests and code cleanup to utils (#1993)
* Add unit tests for new util functions
* Utils functions shouldn’t be package, not private.
* Use existing utility function for insertAfter
2018-08-03 14:31:50 -07:00
Rachel Fenichel b65491e656 Heal rows when unplugging, and add tests 2018-08-03 13:54:29 -07:00
Rachel Fenichel cc60346cf0 Merge pull request #1992 from rachel-fenichel/tests/block_unplug
Tests for block.unplug
2018-08-03 10:11:36 -07:00
Rachel Fenichel b52267bee9 Tests for block.unplug 2018-08-02 17:35:10 -07:00
translatewiki.net 4e6fb831ed Localisation updates from https://translatewiki.net. 2018-08-02 10:11:50 +02:00
Neil Fraser 6ce31942e0 Some goog.dom removal (#1991) 2018-08-01 15:47:28 -07:00
Neil Fraser 1fa4a8d856 Rebuild (#1990) 2018-07-31 12:58:16 -07:00
translatewiki.net adce2c6d12 Localisation updates from https://translatewiki.net. 2018-07-30 08:17:36 +02:00
translatewiki.net f2af7a2983 Localisation updates from https://translatewiki.net. 2018-07-26 10:01:43 +02:00
Rachel Fenichel 2517eb40ef Merge pull request #1986 from gokula-krishna-dev/resolve-xml-attribute
Change XML attribute for procedure from varId to var-id
2018-07-25 10:33:47 -07:00
Gokula Krishna eef7e8f923 Change the XML attribute key from var-id to varid 2018-07-25 10:56:22 +08:00
Gokula Krishna 2c3ef64609 Remove varId attribute while saving 2018-07-24 17:29:35 +08:00
Gokula Krishna 97d3956c43 Prioritize current key var-id 2018-07-24 13:31:04 +08:00
Gokula Krishna 6275c6eef7 Change XML attribute for procedure from varId to var-id 2018-07-24 11:12:17 +08:00
RoboErikG 61803167d8 Add test for deleting a rendered block with a comment (#1984)
Disabled for now as it fails due to #1960.
2018-07-23 10:56:37 -07:00
translatewiki.net eca22c9bd2 Localisation updates from https://translatewiki.net. 2018-07-23 09:31:27 +02:00
Andrew n marshall f42291ea64 Do not escape % in python strings. (#1982)
Rebase of PR-1890, commit 793055… from Ellipsis753:patch-1
2018-07-20 15:54:11 -07:00
translatewiki.net 49955bd984 Localisation updates from https://translatewiki.net. 2018-07-20 14:59:28 +02:00
RoboErikG c815608fdf Fix failing svg canvas test (#1977)
Partial fix for #1976. This fixes the broken test by initializing the
svg for blocks when they're created.
2018-07-17 09:35:53 -07:00
Andrew n marshall 4860e34f51 Removing goog.* uses from blocks/*.js files (#1975)
* Removing goog.arrays.equals() in blocks/procedures.js, with minor refactor.
* Replacing goog.dom.createDom() in blocks/procedures.js, blocks/variables.js,  blocks/variables_dynamic.js, and blocks/loops.js.
2018-07-16 17:01:12 -07:00
Neil Fraser c8bfc888c8 Throw errors instead of strings. (#1974)
Blocks and generators
2018-07-16 16:33:44 -07:00
RoboErikG 99ebefa1bf Revert "Fix #1960 by collecting block info before icons are destroyed" (#1973)
* Revert "Localisation updates from https://translatewiki.net."

This reverts commit c4a0b64945.

* Revert "Fix #1960 by collecting block info before icons are destroyed (#1970)"

This reverts commit 9a3bd45b22.
2018-07-16 10:18:40 -07:00
translatewiki.net c4a0b64945 Localisation updates from https://translatewiki.net. 2018-07-16 16:49:05 +02:00
RoboErikG 9a3bd45b22 Fix #1960 by collecting block info before icons are destroyed (#1970)
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
2018-07-12 15:34:32 -07:00
Neil Fraser ac2fa96d7f Replace goog.dom.createDom for creating HTML 2018-07-11 12:20:02 -07:00
Neil Fraser dce60fd152 Replace ReferenceError with Error.
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser c51cf0b79c Remove goog.dom.removeNode 2018-07-11 12:20:02 -07:00
Neil Fraser f802859547 Remove goog.dom.removeChildren
HTML can be nullified with innerHTML, SVG needs a loop.
2018-07-11 12:20:02 -07:00
Neil Fraser c8e08109f2 Correct requires for goog.style 2018-07-11 12:20:02 -07:00
Neil Fraser 51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00
Neil Fraser 0583bee502 Correct requires for goog.dom 2018-07-11 12:20:02 -07:00
Neil Fraser 8f7674ea08 Correct requires for goog.events 2018-07-11 12:20:02 -07:00
Neil Fraser 67a18036d0 Fix Travis errors 2018-07-11 12:20:02 -07:00
Neil Fraser 07d1d86283 Remove remaining goog.math 2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 60cce6cd0c Remove goog.math angle functions. 2018-07-11 12:20:02 -07:00
Neil Fraser eea2794e38 Remove goog.dom.TagName 2018-07-11 12:20:02 -07:00
Neil Fraser 06d90c9b34 Remove goog.array 2018-07-11 12:20:02 -07:00
Neil Fraser 03bf9f5e71 Remove goog.string 2018-07-11 12:20:02 -07:00
Neil Fraser 3909bd420a Remove all goog.asserts and goog.isXxx
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Andrew n marshall 02dc7b1d1d Fixing JSDoc for the return type of Blockly.WorkspaceComment.parseAttributes (#1966) 2018-07-03 12:07:25 -07:00
Andrew n marshall cf3f914be8 Moving TODOs out of jsdoc comments. (#1965) 2018-07-03 11:42:40 -07:00
Andrew n marshall ec4963f4b4 Merge pull request #1961 from rachel-fenichel/master_to_develop_june
Master->develop
2018-07-02 12:35:00 -07:00
Andrew n marshall 1bd135c9a5 Updating NPM package version to 1.20180629.0-develop (#1962) 2018-07-02 12:34:03 -07:00