Maribeth Moffatt
0255c580f7
Merge branch 'develop' into merge-v11
2024-05-13 11:20:39 -07:00
Neil Fraser
c0298652af
feat: Add snapping to workspace comments. ( #8070 )
...
Now that there are two things that snap (blocks and WS comments), the alignment code in being moved to a common place.
2024-05-12 23:16:26 +02:00
Maribeth Bottorff
28ac0c4473
fix: improve types in FieldRegistry ( #8062 )
...
* fix: improve types in FieldRegistry
* chore: tsdoc
2024-05-10 14:14:50 -07:00
Beka Westberg
c704d5a887
revert: "feat: allow the dialog methods to take in extra parameters ( #8084 )" ( #8085 )
...
This reverts commit 278006b5f8
2024-05-10 11:12:15 -07:00
Maribeth Bottorff
54eeb85d89
fix!: add getContents to IFlyout ( #8064 )
2024-05-08 11:44:00 -07:00
Beka Westberg
278006b5f8
feat: allow the dialog methods to take in extra parameters ( #8084 )
...
* feat: allow prompt to take in additional params
* feat: allow confirm tot ake in extra args
* feat: allow alert dialog to take in extra parameters
* chore: add tests for dialog methods
2024-05-08 10:10:09 -07:00
Aaron Dodson
08183863e7
refactor: split out block serialization for creating new blocks from the flyout ( #8065 )
...
* refactor: split out block serialization for creating new blocks from the flyout
* fix: add JSDoc.
* chore: satisfy the linter.
2024-05-03 12:27:55 -07:00
John Nesky
171befa746
fix!: Only fire intermediate events when editing input with invalid text. ( #8054 )
...
* fix: Fire intermediate events only when editing text input.
* Prefix unused arg with underscore.
* Fix tests.
2024-05-02 18:57:57 -07:00
Richard Knoll
4861c7d98a
fix: prevent duplication of comment icon bubbles ( #8053 )
2024-05-02 08:38:40 -07:00
Beka Westberg
93c4d75fbd
fix: comment highlight being positioned incorrectly in RTL ( #8044 )
2024-04-19 11:33:25 -07:00
Beka Westberg
69c5557e4f
chore: fix comments being resizable when readonly ( #8043 )
2024-04-19 11:15:56 -07:00
Beka Westberg
7246bbc0d1
fix: comment text input size in samples ( #8042 )
2024-04-19 08:37:35 -07:00
John Nesky
cee7f916bb
feat!: Invalid Blocks ( #7958 )
...
* feat: Invalid Blocks
* Rename the new json property from invalid to invalidReasons.
* Merged isValid into isEnabled.
* Minor fixes.
* More minor fixes.
* Reverting some stuff that didn't need to change.
* Addressing PR feedback.
* Update the BlockInfo interface to match State.
* Make BlockChange.disabledReason private.
2024-04-17 19:47:51 -07:00
Beka Westberg
7d8f88a4f1
chore: delete old comments ( #8038 )
...
* chore!: delete old comment classes and references
* chore: PR comments
2024-04-17 14:33:36 -07:00
Beka Westberg
a865744b7e
fix: bumping comments into bounds ( #8037 )
2024-04-17 14:02:46 -07:00
Beka Westberg
41fe298a62
fix: cut shortcut for workspace comments ( #8036 )
2024-04-17 13:53:57 -07:00
Beka Westberg
e21bb99ff1
feat!: Add context menu options for workspace comments ( #8035 )
...
* feat: add context menu support and migrate easy options
* feat: pass events to context menu options
* chore: migrate final comment context menu option
* feat: add exports for comment context menu items
* chore: PR comments
2024-04-17 13:02:53 -07:00
Beka Westberg
70f3f52911
fix: CSS for selected collapsed comments ( #8039 )
2024-04-17 09:48:43 -07:00
Beka Westberg
94dda6e668
fix: text input bubble css ( #8040 )
2024-04-17 09:47:51 -07:00
Beka Westberg
dabb11f4cb
feat!: add ability to copy and paste workspace comments ( #8024 )
...
* chore: add support for copying and pasting workspace comments
* chore: fix build
* fix: PR comments
2024-04-15 14:43:58 -07:00
Beka Westberg
b6753a250e
fix: more drag exports ( #8025 )
...
* fix: more drag exports I forgot about
* chore: fix date in copyright
2024-04-12 22:09:32 +00:00
Beka Westberg
d554053bd0
feat: add ability to delete workspace comments ( #8023 )
2024-04-11 13:22:50 -07:00
Beka Westberg
a0f821a239
fix: revert dragger name ( #8020 )
2024-04-11 13:22:17 -07:00
Beka Westberg
613c7335ee
chore: export some types and methods ( #8021 )
2024-04-11 08:38:50 -07:00
Beka Westberg
ee95b4c577
chore: rename method ( #8015 )
2024-04-09 10:57:03 -07:00
Mike Harvey
e2df0fc288
fix: correct dropdown arrow placement for Thrasos on Safari ( #8017 )
2024-04-08 14:56:36 -07:00
Beka Westberg
7491a50239
fix: compatibility with scroll plugin ( #8016 )
2024-04-08 13:17:03 -07:00
Beka Westberg
3e1e9b5ddc
fix: blocks not being returned to the correct layer if their drag is reverted with no parent ( #7998 )
...
* fix: blocks not being returned to the correct drag layer if their drag is reverted with no parent
* fix: delete test code
2024-04-08 09:44:31 -07:00
Beka Westberg
0cec8b1d29
fix: drag cursor not showing ( #7999 )
2024-04-08 09:23:49 -07:00
Beka Westberg
25ba5f0a3d
fix: firing move event for insertion marker ( #8000 )
2024-04-05 13:50:14 -07:00
Beka Westberg
6f7e04d8eb
fix: bubbles not being returned to the correct drag layer ( #7997 )
2024-04-05 13:46:28 -07:00
Beka Westberg
e1cbddd860
feat: visual comment selection ( #7996 )
...
* feat: add visually highlighting selected comment
* chore: TSDoc
2024-04-05 13:39:20 -07:00
Beka Westberg
e8c51965b4
feat: add toFlyoutData method for compatibility with backpack ( #8002 )
2024-04-05 10:25:33 -07:00
Beka Westberg
7277a2350f
chore: delete old dragging infrastructure ( #7995 )
2024-04-05 09:13:02 -07:00
Beka Westberg
c60db431ca
chore: delete useless DRAG_STACK value ( #7994 )
2024-04-04 15:58:24 -07:00
Beka Westberg
fd177358ea
feat: comment collapse event ( #7949 )
...
* feat: define comment collapse event
* feat: add firing collapse events
* chore: add round-trip test
* chore: add tests for firing collapse events
* chore: format
2024-04-04 15:48:34 -07:00
Beka Westberg
c0e6e6745f
fix: dragging shadow blocks ( #7992 )
...
* fix: dragging shadow blocks
* fix: dragging shadows not reverting them to their original position
* fix: shadow parents not being deselected
2024-04-04 18:30:41 +00:00
Maribeth Bottorff
b0c29b8b69
Merge pull request #7993 from google/develop
...
chore: merge develop into rc/v11
2024-04-04 11:14:18 -07:00
Beka Westberg
ed403d0b77
feat!: change gestures to look at selected when dragging ( #7991 )
...
* feat: change gestures to look at selected when dragging
* chore: fix tests
* chore: format
* chore: PR comments
2024-04-04 08:52:43 -07:00
Beka Westberg
e75a4fb1d3
fix: comment move and change events ( #7947 )
...
* fix: comment move event
* feat: add support for a drag reason
* fix: comment change events
* chore: add tests for move and change events
2024-04-03 12:58:04 -07:00
Beka Westberg
3988e13fbc
chore: fix comment colours disappearing when dragging ( #7978 )
2024-04-02 14:37:54 -07:00
Mike Harvey
9e05d69d2a
feat: support keyboard navigation of flyout buttons ( #7852 )
...
* feat: support keyboard navigation of flyout buttons
* fix: use FlyoutItem type for flyout contents, rework navigateBetweenStacks for flyouts
2024-04-02 13:40:58 -07:00
Beka Westberg
f7bdfa2062
feat: support dragging comments in the gesture ( #7977 )
...
* feat: add dragging of comments in gesture
* chore: fix naming problems
2024-04-02 20:08:27 +00:00
Beka Westberg
b13f8f6737
fix: prevent default undo ( #7946 )
...
* fix: prevent default undo
* chore: fix format
2024-04-02 13:03:11 -07:00
Maribeth Bottorff
b7cdeffccd
chore: merge develop into rc/v11
2024-04-01 14:57:19 -07:00
Alejandro Ramos
d56f52cb0a
fix: Assign to containerDiv blockyWidgetDiv if it already exists ( #7980 )
...
* fix: assign to containerDiv if it already exists
* Delete unused return
* Fix if statement
* format file using Prettier
* Deduplicate lines and improve efficiency
2024-04-01 21:54:54 +00:00
Beka Westberg
2fa6f5b954
fix: comment icon interface re serialization ( #7964 )
...
* fix: comment icon interface re serialization
* chore: fix test
2024-04-01 14:34:48 -07:00
Beka Westberg
63eb4ecb2a
fix: comment create and delete events ( #7945 )
...
* chore: switch events to use new comment class
* fix: switch create and delete events to use JSON
* work on getting new comments to fire events
* chore: fixup tests
* chore: rename workspace comment test to comment view test
* chore: add tests for firing events
* chore: remove TODO
2024-04-01 21:33:50 +00:00
Maribeth Bottorff
6767717d0b
feat: allow duplicate registry values ( #7988 )
2024-04-01 14:13:25 -07:00
Beka Westberg
9effba5ee1
feat: make comment a draggable ( #7976 )
...
* feat: add drag strategy
* chore: use draggable
2024-04-01 10:25:43 -07:00
