Commit Graph

987 Commits

Author SHA1 Message Date
Neil Fraser
3012d52808 Line wrap comments in generated code. 2016-06-08 00:12:58 -07:00
Neil Fraser
4ba2b1bea3 Use a comment block for function comments in generated JS, Python and Dart. 2016-06-06 00:19:36 -07:00
Neil Fraser
87e4e6224a Merge branch 'master' into develop 2016-06-05 17:03:30 -07:00
Neil Fraser
9ca00656ad Properly deal with shadow statement blocks in stacks. 2016-06-05 16:58:27 -07:00
Neil Fraser
f642fa80d5 Increase commonality between playgrounds. 2016-06-05 15:32:54 -07:00
Neil Fraser
266e2ffa9a Add toolbox location and toolbox mode options to playground. 2016-06-05 04:16:09 -07:00
Neil Fraser
cf8ee673a9 Fix inheritance on rendered connection.
Closure compiler on maximum compression breaks badly due to lack of
@extends attribute.
2016-06-03 18:44:40 -07:00
Neil Fraser
f3a1ef464d Merge branch 'develop' 2016-06-03 16:41:14 -07:00
Neil Fraser
a625d5b07c Fix unit tests. 2016-06-03 16:40:50 -07:00
Neil Fraser
57131165b0 Routine recompile 2016-06-03 16:12:59 -07:00
Neil Fraser
1aafaf4abf Merge branch 'master' into develop 2016-06-03 16:12:04 -07:00
picklesrus
213469a479 Change the blockly workspace resizing strategy. (#386)
* Add a new method to be called when the contents of the workspace change and
the scrollbars need to be adjusted but the the chrome (trash, toolbox, etc)
are expected to stay in the same place.

Change a bunch of calls to svgResize to either be removed or call the new
method instead.  This is a nice performance win since the offsetHeight/Width
call in svgResize can be expensive, especially when called as often as we do -
there was some layout thrashing.

This also paves the way for moving calls to recordDeleteAreas
(which is also expensive) to a more cacheable spot than on every
mouse down/touch event.

of things (namely the scrollbars)

* Fix size of graph demo when it first loads by calling svgResize.
The graph starts with fixed width and was relying on a resize event
to fire (which I believe was removed in commit
217c681b86).

* Fix the resizing of the code demo.  The demo's tab min-width used to
match the toolbox's width was only being set on a resize event, but
commit 217c681b86 changed how that worked.

* Fix up some comments.

* Use specific workspaces rather than Blockly.getMainWorkspace().

* Make workspace required for resizeSvgContents and update
some calls to send real workspaces rather than ones that are
null.

Remove the private tag on terminateDrag_ because it is only
actually called from outside the BlockSvg object.

* Remove a rogue period.

* Recategorize BlockSvg.terminateDrag_ to @package instead of @private so that
other developers don't use it, but it still can be used by other Blockly classes.

* Add a TODO to fix issue #307.

* Add @package to workspace resizeContents.
2016-06-03 16:11:55 -07:00
Neil Fraser
bfa842c9a8 Remove claim that good.string.quote should be used. 2016-06-02 16:31:49 -07:00
Sean Lip
0502fca2c3 Merge branch 'develop' of https://github.com/google/blockly into develop 2016-06-02 15:52:15 -07:00
Sean Lip
e8a2d3e2fd Fix extra category error. Clean up code, rename variables, reduce line lengths, fix lint issues. 2016-06-02 15:51:37 -07:00
Niklas Laxström
11a3f77e66 Localisation updates from https://translatewiki.net. 2016-06-02 08:01:07 +02:00
Neil Fraser
32192850ad Generated JS helper functions should be camelCase.
Complying with Google style guide.
2016-06-01 17:18:18 -07:00
rachel-fenichel
0e29021b31 Merge pull request #392 from rachel-fenichel/bugfix/fake_drag_return
Bugfix/fake drag return
2016-06-01 16:24:17 -07:00
Rachel Fenichel
9709bd0088 get rid of drag_tests file: 2016-06-01 16:23:49 -07:00
Rachel Fenichel
1f2107ee08 add missing return in fake drag 2016-06-01 16:20:56 -07:00
Rachel Fenichel
3ddfabf064 Merge remote-tracking branch 'upstream/develop' into develop 2016-06-01 15:35:23 -07:00
rachel-fenichel
914b22789d Merge pull request #389 from rachel-fenichel/feature/render_move_connections
Move connections at the end of render, instead of in the middle of dr…
2016-06-01 15:32:41 -07:00
rachel-fenichel
06a8c776b3 Merge pull request #390 from rachel-fenichel/feature/drag_tests
Add a button to randomly click and drag blocks in the playground.
2016-06-01 15:32:35 -07:00
Rachel Fenichel
c3f27127d3 lint 2016-06-01 15:31:43 -07:00
Rachel Fenichel
53cf0be791 lint 2016-06-01 15:24:23 -07:00
Rachel Fenichel
66ca80c42f Make function private 2016-05-31 15:48:32 -07:00
Rachel Fenichel
dd205feda0 Add a button to randomly click and drag blocks in the playground. 2016-05-31 15:42:28 -07:00
Rachel Fenichel
03de6b6a92 Move connections at the end of render, instead of in the middle of drawing 2016-05-31 15:39:08 -07:00
rachel-fenichel
c279669049 Merge pull request #388 from picklesrus/playground-button
Add a button to flip between flyouts and toolboxes.
2016-05-31 10:50:15 -07:00
Katelyn Mann
2db6841b66 Add a button to flip between flyouts and toolboxes. 2016-05-31 09:15:42 -07:00
Niklas Laxström
c2368107c5 Localisation updates from https://translatewiki.net. 2016-05-30 10:33:25 +02:00
Neil Fraser
a242c5d6e4 Stop context menu in context menu. Issue #372. 2016-05-29 15:59:46 -07:00
Neil Fraser
1db8092f15 Do not allow shadow blocks to have non-shadow children. 2016-05-29 14:53:29 -07:00
Neil Fraser
d6f84bff56 Do not allow importing of top-level shadow blocks. 2016-05-29 13:43:45 -07:00
Sean Lip
4e2d8f1310 Add missing comment from an earlier review. 2016-05-27 17:03:12 -07:00
Sean Lip
9791b48533 Add an explicit injector for the 'Run Code' button. Update es6-shim dependency to prevent console errors. 2016-05-27 16:37:39 -07:00
Rachel Fenichel
bb9b088826 test page that creates random blocks and randomly drags them around the page 2016-05-27 13:53:46 -07:00
rachel-fenichel
f0dcf3521e Merge pull request #382 from rachel-fenichel/cleanup/scrollbar_complications
Split scrollbar code into content changes and view changes; store dim…
2016-05-27 10:39:48 -07:00
Rachel Fenichel
5532e879eb Check for infinity with == in scrollbar 2016-05-27 10:38:41 -07:00
Rachel Fenichel
8afb04d9ee Move values to prototype and use coordinate. 2016-05-27 10:37:40 -07:00
Rachel Fenichel
06b9bb68e6 Rename knob to handle 2016-05-27 10:25:19 -07:00
Rachel Fenichel
5752913b4d Make some variables private and some functions public. 2016-05-26 15:22:24 -07:00
Rachel Fenichel
c80d3709e5 Merge branch 'develop' into cleanup/scrollbar_complications 2016-05-26 14:58:25 -07:00
Niklas Laxström
3d752e57e6 Localisation updates from https://translatewiki.net. 2016-05-26 07:53:34 +02:00
Rachel Fenichel
f486ac949c use helper functions to set attribute on svg and in model at the same time. 2016-05-25 16:38:19 -07:00
Rachel Fenichel
4562ff8d74 Split scrollbar code into content changes and view changes; store dimensions in variables instead of querying the dom. 2016-05-25 16:20:20 -07:00
Neil Fraser
abe2533d7e Merge branch 'develop' 2016-05-25 15:45:06 -07:00
Neil Fraser
6f12c69500 Routine recompile. 2016-05-25 15:44:44 -07:00
Neil Fraser
89811bfb5d Merge branch 'master' into develop 2016-05-25 15:41:19 -07:00
rachel-fenichel
e14e42192c Merge pull request #379 from rachel-fenichel/cleanup/more_lint
More lint and eslint configuration.
2016-05-25 15:36:03 -07:00