Commit Graph

2640 Commits

Author SHA1 Message Date
Rachel Fenichel
3927bd17c3 Rebuild message files 2018-04-20 16:45:16 -07:00
Andrew n marshall
ab8692652a Revert "Removing namespace declarations for deprecated and unused namespaces. (#1796)" (#1809)
This reverts commit 75459abfdd.
2018-04-20 08:08:11 -07:00
Rachel Fenichel
c3b5bb2140 Merge pull request #1808 from rachel-fenichel/event_file_churn
Move events back up to core, because moving it to a separate folder was a mistake.
2018-04-19 17:40:44 -07:00
Rachel Fenichel
4a467cef5b Move events back up to core, because moving it to a separate folder was a mistake. 2018-04-19 16:53:19 -07:00
Rachel Fenichel
e4e73e7d60 Merge pull request #1729 from rachel-fenichel/feature/block_event_base
Create base classes for block and variable events
2018-04-19 16:28:53 -07:00
Rachel Fenichel
f23c5c0a38 Rebuild 2018-04-19 16:23:53 -07:00
Rachel Fenichel
5839620a43 Remove unnecessary conditionals. 2018-04-19 16:15:00 -07:00
Rachel Fenichel
d8202f8cae Create base classes for block and variable events, instead of stuffing everything into Abstract 2018-04-19 16:15:00 -07:00
Andrew n marshall
75459abfdd Removing namespace declarations for deprecated and unused namespaces. (#1796)
These namespaces use to contain the original block hue constants,
but were deprecated (via comment, except for procedures) over a year
ago. With the removal of those constants, the declarations were
creating empty, unused objects.
2018-04-18 15:32:26 -07:00
Andrew n marshall
2bfff4a335 Warn if jsonInit() receives a colour attribute without a value. (#1795)
* Warn if jsonInit() receives a colour attribute without a value.
 * Extract colour init code into function.
 * Adding block type name to prior warnings.
2018-04-18 13:35:30 -07:00
Rachel Fenichel
46da00dbd3 Merge pull request #1787 from rachel-fenichel/feature/block_animations
Move block animation code to a new file and rebuild
2018-04-18 10:17:43 -07:00
Andrew n marshall
1a37bebd89 Refactor of checkBlockColourConstant_() (#1798)
Rewrote Blockly.checkBlockColourConstant_(..).
 * Last argument is now the expected value of the constant (replacing
   the `removed` argument). The prevents warnings when a Msg colour
   constant is overridden (the correct way).
 * If a value for the constant is not found, do not warn (#1790).
2018-04-18 08:40:45 -07:00
Neil Fraser
b4450b7dee Reverse deprecated argument order to womtoblock in accessible. 2018-04-17 14:58:27 -07:00
Andrew n marshall
b2cb96b5b1 Mark Blockly.Constants.Colour and .Lists depreacted. (#1797)
Both are only used by the hue constants, which are already deprecated.
2018-04-17 13:29:50 -07:00
Andrew n marshall
49be85b89d Correct block color reference in demos/graph (#1794) 2018-04-17 12:38:06 -07:00
Neil Fraser
662d79443f Add 'ordered' option to descendant getting functions. (#1786) 2018-04-17 11:41:03 -07:00
Rachel Fenichel
51d512ab8b Merge pull request #1789 from google/rachel-fenichel-patch-1
Fix #1788
2018-04-17 10:15:53 -07:00
Rachel Fenichel
100af3836d Fix #1788 2018-04-16 16:42:18 -07:00
Rachel Fenichel
9b3c173640 Merge pull request #1783 from jcyang43/protectedProperties
Mark some properties @protected instead of @private so they can be used by subclasses
2018-04-16 16:09:57 -07:00
Rachel Fenichel
4e3b114832 Move block animation code to a new file and rebuild 2018-04-16 15:28:52 -07:00
Johnny Yang
7dbe0bda66 mark properties @protected instead of @private so they can be used by Blockly.FlyoutVertical & Blockly.FlyoutHorizontal 2018-04-16 01:36:28 +10:00
Johnny Yang
419fe9e8a5 mark properties @protected instead of @private so they can be used by Blockly.RenderedConnection 2018-04-16 01:34:52 +10:00
Johnny Yang
6c2d63300d mark properties @protected instead of @private so they can be used by Blockly.BlockSvg 2018-04-16 01:33:04 +10:00
Rachel Fenichel
f52b75a198 Merge pull request #1778 from AnmAtAnm/shadow-pop
Rewrote LOGIC_COMPARE_ONCHANGE_MIXIN to fix #1408.
2018-04-13 17:04:12 -07:00
Rachel Fenichel
eaafc23c09 Merge pull request #1781 from rachel-fenichel/master_to_develop
Master to develop
2018-04-13 16:41:25 -07:00
Andrew n marshall
ef23b0e4ef Do not reconnect a previous shadow block.
Assume unplug() will recreate a new correct shadow.
2018-04-13 16:26:20 -07:00
Rachel Fenichel
f49521b88b Rebuild core files 2018-04-13 14:51:30 -07:00
Rachel Fenichel
b5ac0b71a3 Merge branch 'master' into master_to_develop 2018-04-13 14:46:50 -07:00
Rachel Fenichel
91f36345f6 Merge pull request #1777 from rachel-fenichel/bugfix/1658
Fix context menus on blocks with variables
2018-04-13 13:46:15 -07:00
Rachel Fenichel
1dfb53b337 Fix comment 2018-04-13 13:39:28 -07:00
Andrew n marshall
c0e220214c Rewrote LOGIC_COMPARE_ONCHANGE_MIXIN to fix #1408.
* Create prevBlock_ upon first call to onchange.
 * Revert state upon an incompatible combination, bumping the new incompatible
   block, instead of the old block. Thus, the shadow is never the bumped block.

Bug:
 * The undo stack get caught in a loop, and will never undo back to a state
   equivalent to the previous action.
2018-04-12 17:27:20 -07:00
Rachel Fenichel
23666664fa Fix context menus on blocks with variables 2018-04-12 16:56:07 -07:00
Andrew n marshall
5c541c6f99 Setting the value of math_numnber toolbox blocks to 123. (#1773)
Using 123 as a better indicator to the user this block can represent any number,
and the user should replace this value with their own desired number.
2018-04-12 14:46:37 -07:00
Rachel Fenichel
df3e826087 Merge pull request #1774 from rachel-fenichel/bugfix/1425
Work around a problem with RTL mutators
2018-04-12 13:30:35 -07:00
Rachel Fenichel
abde1134c7 Merge pull request #1772 from rachel-fenichel/feature/local_build
Create a script to do local builds of core Blockly.
2018-04-12 12:01:29 -07:00
translatewiki.net
bdfbdeeae9 Localisation updates from https://translatewiki.net. 2018-04-12 09:09:23 +02:00
Rachel Fenichel
01e48608fb Fix my definition of plausible 2018-04-11 18:08:49 -07:00
Rachel Fenichel
6606c7c6fc Fix excess newlines 2018-04-11 17:08:18 -07:00
Neil Fraser
0ac5b2773e Remove rogue line breaks in translated messages. 2018-04-11 17:01:15 -07:00
Rachel Fenichel
40e74d4d65 Check if the browser's value was plausible, and use it if so. 2018-04-11 17:00:39 -07:00
Neil Fraser
1d385f8d69 Require goog.userAgent in the correct files. 2018-04-11 16:59:35 -07:00
Rachel Fenichel
29571e91e2 Work around a problem with RTL mutators 2018-04-11 16:17:06 -07:00
Rachel Fenichel
42cb962cef Apply review feedback. 2018-04-11 15:26:05 -07:00
Rachel Fenichel
b5b7aeaf1b Create a script to do local builds of core Blockly. 2018-04-11 14:19:49 -07:00
Rachel Fenichel
9a62e6aa70 Merge pull request #1767 from rachel-fenichel/metrics_test
Simple tests for getContentDimensions
2018-04-11 13:41:12 -07:00
Rachel Fenichel
e11ec48ed3 Break tests out into individual cases 2018-04-11 13:35:54 -07:00
Andrew n marshall
ecc41372d7 Fixing issue 1760: nulls in JSON array for block definitions. (#1768)
JSON array with null or undefined value will now skip the offending item, and proceed to load following items. Added tests for null and undefined array elements.

* Testing handling null and undefined id in block definition.
* Adding test utility function to capture console warnings.
* Test assumption that creating a simple block will not cause a warning. This is assumed when later checking warning counts.
2018-04-11 10:22:30 -07:00
Andrew n marshall
e9d8e00a55 Making all blocks use the MSG colour values. (#1749)
* Making all blocks use the MSG colour values.
 * Deprecating Blockly.Constants.Lists.HUE and similar constants.
 * Removing deprecated Blockly.Blocks.lists.HUE constants.
 * Allowing message references in the Block.setColour() parameter.
 * Adding checking of older constants, ensuring they are not overwritten.
2018-04-09 17:37:47 -07:00
Rachel Fenichel
9f07d04709 Simple tests for getContentDimensions 2018-04-09 11:28:18 -07:00
translatewiki.net
d3a9d96841 Localisation updates from https://translatewiki.net. 2018-04-09 08:14:44 +02:00