Commit Graph

24 Commits

Author SHA1 Message Date
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Rachel Fenichel
7bc461ea83 polish: export draggingConnections directly 2021-08-04 17:17:24 -07:00
Rachel Fenichel
d5a6d7d3db Move draggingConnections to common 2021-08-04 15:59:41 -07:00
Monica Kozbial
bec82da358 Remove require destructuring (#5294) 2021-08-03 15:07:14 -07:00
Aaron Dodson
83ff0ea09e Merge pull request #5148 from gonfunko/rerefactor
Update goog.module-migrated files to fix style issues
2021-07-22 08:09:53 -07:00
Rachel Fenichel
12636da182 Reorder some requires and rebuild 2021-07-21 15:47:55 -07:00
Rachel Fenichel
b3f837a8d2 Replace references to constants with internalConstants 2021-07-21 15:33:55 -07:00
Aaron Dodson
0e6258ca1a Migrated to inline exports 2021-07-21 08:17:13 -07:00
Aaron Dodson
bbdf5730f6 Reordered core/connection_checker.js requires 2021-07-19 08:10:47 -07:00
Aaron Dodson
5b9505802e clang-format core/connection_checker.js 2021-07-16 14:46:07 -07:00
Aaron Dodson
e23560343e Migrate core/connection_checker.js to named requires 2021-07-16 14:45:35 -07:00
Aaron Dodson
50793c20cb Migrate core/connection_checker.js to goog.module 2021-07-16 14:30:16 -07:00
Aaron Dodson
29c560dfbb Migrate core/connection_checker.js to ES6 const/let 2021-07-16 14:26:36 -07:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Rachel Fenichel
750b62030b First pass at creating connectionTypes and inputTYpes 2021-03-04 10:22:24 -08:00
Rachel Fenichel
84446215c0 Update more missing requireTypes 2021-02-10 14:59:05 -08:00
Rachel Fenichel
c9be2402bd More missing requires 2021-01-12 12:38:21 -08:00
Sam El-Husseini
fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
Rachel Fenichel
98b436031c Use registry for connection checker 2020-07-17 10:51:39 -06:00
Rachel Fenichel
1700efc77b Add distance parameter to canConnect 2020-07-16 17:40:13 -06:00
Rachel Fenichel
745017f325 Move from one, two to a, b 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e47d33148e Review feedback 2020-07-16 17:40:13 -06:00
Rachel Fenichel
809148b435 Fix compiler errors 2020-07-16 17:40:13 -06:00
Rachel Fenichel
7288c66294 Rename connectionTypeChecker->connectionChecker 2020-07-16 17:40:13 -06:00