Rachel Fenichel
6218750207
Fix events for variable fields on new blocks; fix tests
2017-12-19 11:28:23 -08:00
Rachel Fenichel
df1d5ba525
fix tests
2017-12-15 14:07:17 -08:00
Rachel Fenichel
be4054b593
Tests
2017-12-13 11:50:08 -08:00
Rachel Fenichel
399f1a5c11
Tests
2017-12-13 11:50:08 -08:00
Rachel Fenichel
24672bcbb2
Remove ws.updateVariableStore and tests, and ws.getVariableUses
2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a
Get rid of workspace.deleteVariable
2017-12-13 11:50:08 -08:00
Rachel Fenichel
523a10413b
All tests pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a
All but XML tests now pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45
Update tests in workspace_test. Get rid of renameVariable
2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f
Fix tests in field_variable_test.js
2017-12-13 11:50:07 -08:00
Rachel Fenichel
779be46a92
Allow variables of different types to share the same name.
2017-12-13 11:50:07 -08:00
Rachel Fenichel
66586bf622
Add a test for case-sensitivity in the variable names, ids, etc. in the flyout
2017-11-03 16:03:32 -07:00
Rachel Fenichel
30716fbd78
switch to variabletype everywhere
2017-11-03 16:03:32 -07:00
Evan W. Patton
67e192e208
Fix logic bugs related to e1e9427 ( #1398 )
...
This commit adds a fallback when attempting to merge events that
collide on a hash but do not actually merge. Previously, the latter
event would be dropped.
This also fixes a minor UX problem where moving the isNull check into
the merging loop resulted in extra events in the undo queue that
served no purpose and required multiple undo operations without visual
feedback.
Fixes #1373
2017-10-27 16:04:17 -07:00
Neil Fraser
2445a752b7
Resolve another 20 warnings.
2017-10-24 14:06:29 -07:00
Neil Fraser
4262b09002
Resolve 106 warnings.
2017-10-24 14:06:29 -07:00
Andrew n marshall
f992ea0f9c
Fix #1369 : resource loading order constraints, interpolation tokens in message expansion (PR #1383 )
...
This fixes race condition in #1369 by using message references instead of explicit string lookups. This required fixing a bug the token interpolation parser that was breaking on the inner '"%1"' for these tooltips.
2017-10-24 13:02:14 -07:00
Neil Fraser
82705923cb
Convert compile demo into a unit test. ( #1360 )
...
* Intentionally break Travis.
* Alphabetize tests, remove orphaned test, and add fail to test that's running.
* Unbreak test, disable OS X, move scripts, list compiler directory.
* Test Java, break test.
* Unbreak test, call compile script.
* Compile main_compressed.js
* Run test command using bash.
* Fix path.
* Exclude node modules.
* Be more specific about JS files to compile.
* Test failure.
* Restore OSX, undo Blockly failure, remove compilation demo, add compilation test.
* Delete manual test files.
* Ignore downloaded/generated files.
* Whitespace cleanup.
2017-10-12 14:54:57 -07:00
Rachel Fenichel
c381808120
Tests for widget div math. ( #1338 )
...
* New widget div functions, used in context menu code
* Make all widget div positioning functions use the same argument order
* Use new widget div functions for fields
* share code for measuring menu size
* Get rid of positionMenu
* Update copyright date
* Rebuild blockly_uncompressed because there's a new require in town
* Test for widget div math
2017-09-22 16:10:47 -07:00
picklesrus
5518873389
Revert "Remove all all instances calling setValue on variable fields with the name instead of the id" ( #1296 )
...
* Revert "Create WorkspaceViewport class (#1291 )"
This reverts commit 6c00d77c9e .
* Revert "Remove all all instances calling setValue with name. (#1254 )"
This reverts commit 8e8b6b27af .
2017-08-28 16:55:44 -07:00
marisaleung
8e8b6b27af
Remove all all instances calling setValue with name. ( #1254 )
2017-08-24 14:34:01 -07:00
Evan W. Patton
e1e94271c4
Implement Blockly.Events.filter in linear time ( #1205 )
...
* Implement Blockly.Events.filter in linear time
For large App Inventor projects (order 1k+ blocks, 100+ top-level
blocks), the O(n^2) behavior of Blockly.Event.filter was causing
performance issues when rearranging blocks or pasting from the
backpack. This commit provides a linear merge implementation using a
key that uniquely identifies a block so that multiple events targeting
the same block are merged. This change benefits from O(1) amortized
lookup using an object as a key-value store.
* Add event filter unit tests and fix logic bugs
* Update Blockly.Events.filter unit tests
2017-08-18 14:18:47 -07:00
marisaleung
234c53157f
Fix Blockly.Procedures.isNameUsed return values.
...
Add tests for Procedures.isNameUsed() so this bug never happens again.
2017-07-28 12:02:14 -07:00
marisaleung
733d869f8e
Add VariableType checks.
2017-07-20 16:47:37 -07:00
marisaleung
15d47840b1
Fire field variable change event with variable value, not name.
2017-06-29 11:24:25 -07:00
marisaleung
3c8e0ebbeb
Dropdown Create does not create a missing variable twice.
2017-06-27 16:51:19 -07:00
marisaleung
4a2c95fd1b
Revamping mostly gesture tests.
2017-06-22 16:56:28 -07:00
marisaleung
5b1a0ae284
Test Delete Variable Twice.
2017-06-09 16:32:16 -07:00
marisaleung
d852a2b116
In DropdownCreate check for Msg.DELETE_VARIABLE.
2017-06-09 16:22:25 -07:00
marisaleung
c58553b7ba
Create utility function for checking variable values.
2017-06-09 15:24:31 -07:00
marisaleung
833c2d0c40
Fire VAR events and test.
2017-06-09 14:42:14 -07:00
marisaleung
e9a480c51f
Add VAR events.
2017-06-08 15:15:17 -07:00
marisaleung
0040ff636c
Field Variable setValue() looks up variable.
2017-06-06 15:29:28 -07:00
marisaleung
ccf3ad1473
Add BLOCK events and constructor tests.
2017-06-01 12:38:38 -07:00
marisaleung
cd0487e816
Clean up and create test utilities file.
2017-06-01 10:36:01 -07:00
marisaleung
a6f85cec53
Appease eslint: semicolons and such.
2017-05-25 13:44:06 -07:00
marisaleung
dc06872a37
Deserialization variables at top.
2017-05-24 15:29:46 -07:00
marisaleung
ce4a84b3cf
Include variables at top of serialization.
2017-05-24 10:53:44 -07:00
marisaleung
e84121690b
Merge pull request #1113 from marisaleung/SmallFix
...
Small fix
2017-05-23 11:40:39 -07:00
marisaleung
1cd8e1fcc1
Add type, id, and info to the generated xml.
...
Add xml tests for fieldToDom.
Update workspace tests to pass with new changes.
2017-05-19 15:47:39 -07:00
marisaleung
cd5bb0d888
Changed parameter name in workspace for clarity.
2017-05-18 14:14:17 -07:00
shirletan
7a2c01e1cf
Work around timing issue with travis osx issue ( #1092 )
...
* add more wait time for test setup
* increase selenium wait time
* add more wait
2017-05-09 16:39:39 -07:00
marisaleung
0e0b1a3ebd
Merge branch 'develop' into develop
2017-05-04 12:38:15 -07:00
marisaleung
12ea998155
Created separate file for VariableMap
2017-05-03 17:04:15 -07:00
marisaleung
2b1fe1c4e3
Merge pull request #1071 from marisaleung/develop
...
VariableMap and functions added.
2017-05-03 13:20:05 -07:00
marisaleung
d903b5e86b
VariableMap and functions added.
2017-05-03 10:51:24 -07:00
marisaleung
b159c7c3b5
Create separate file for VariableMap and its functions.
2017-05-02 15:06:12 -07:00
marisaleung
2994805e6a
VariableMap and functions added.
2017-05-02 10:07:46 -07:00
marisaleung
54178c65ae
Merge pull request #1055 from marisaleung/develop
...
Create a variable model with name, id, and type.
2017-04-20 13:31:22 -07:00
marisaleung
9577e5ddc4
Created a variable model with name, id, and type.
...
Created a jsunit test file for variable model.
2017-04-20 13:19:53 -07:00