Commit Graph

3802 Commits

Author SHA1 Message Date
Neil Fraser 8916dbf75b Add Infinity tests for number and angle fields. 2019-08-01 11:36:58 -07:00
Neil Fraser c8e3938eba Remove field tests with null
Null is explicitly disallowed in most field constructors.  Thus the random results of passing null are undefined and may change.  These changes should not be tested against.

Exceptions:  Variable and serializable lable fields acually do take null.

This commit is due to the upcoming parseInt->Number commit which happens to change how null behaves.

Also added missing ‘empty’ test for checkboxes.
2019-08-01 11:36:58 -07:00
Neil Fraser 11f6c5a631 Fix angle picker when 'Infinity' is typed in.
Previously 'NaN' would be generated, which is not a legal value.
2019-08-01 11:36:58 -07:00
Roy van Schaijk bcadd836b2 Make the TabList exclude hidden fields (#2764)
* Make the TabList exclude hidden fields

* Stop using private variable
2019-08-01 11:14:52 -07:00
Monica Kozbial 9cc0cb6881 Merge pull request #2760 from moniika/moniika-update-centerline
Fix bottom row element centerlines
2019-08-01 10:47:46 -07:00
alschmiedt 1ba6bb887d Fixes undo (#2766) 2019-08-01 10:05:56 -07:00
alschmiedt 579363e67a Fix compile (#2759)
* Adds ability to have multiple folders in core
2019-08-01 09:01:49 -07:00
kozbial e2f12f8262 Fixing edge case for centerline computation for bottom row elements. 2019-07-31 20:12:51 -07:00
Rachel Fenichel 5294d0ab71 Merge pull request #2753 from rachel-fenichel/remove_console_spam
Remove logs from rendering
2019-07-31 15:55:03 -07:00
Rachel Fenichel 860db83b50 Merge pull request #2755 from rachel-fenichel/connection_locations
Work on connection locations
2019-07-31 13:20:38 -07:00
Rachel Fenichel 41c686e733 Use constants 2019-07-31 13:17:20 -07:00
Rachel Fenichel 37250f4ce4 Fix connection highlight rendering 2019-07-31 12:42:34 -07:00
Sam El-Husseini 47da636803 Update LICENSE (#2754)
Replacing the contents of the LICENSE file with the exact text of https://www.apache.o…nses/LICENSE-2.0.txt including the APPENDIX.
2019-07-31 12:29:21 -07:00
Rachel Fenichel bcdd691796 Make updating the connection locations called the same way for both renderers 2019-07-31 11:45:32 -07:00
Rachel Fenichel 113c24509b Remove logs from rendering 2019-07-31 11:14:24 -07:00
Rachel Fenichel bc49bf849c Merge pull request #2751 from rachel-fenichel/eslint_rules
Add more eslint rules
2019-07-31 11:01:15 -07:00
Rachel Fenichel 2d1179e52f Add spaced-comment as warning 2019-07-31 09:56:07 -07:00
Rachel Fenichel 16f0992764 Enable operator-linebreak rule 2019-07-31 09:45:27 -07:00
Rachel Fenichel afd2b09453 Add func-call-spacing rule 2019-07-31 09:43:21 -07:00
Rachel Fenichel b4109d7c43 Add no-multi-spaces rule 2019-07-31 09:33:54 -07:00
alschmiedt 9466c6b7df Move marker creation to the workspace (#2742)
* Move marker creation to the workspace
2019-07-31 09:04:53 -07:00
alschmiedt 62f4871e45 Fixes copy paste to work with the marker (#2740)
* Fixes copy paste to work with the marker
2019-07-31 07:49:02 -07:00
Neil Fraser 45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Neil Fraser 6aedfab4d1 Misc JSDoc fixes. (#2747) 2019-07-30 16:28:48 -07:00
Neil Fraser abc452109e Fix XML across Blockly. (#2727)
Also fixes references to createSvgElement
2019-07-30 15:08:47 -07:00
Rachel Fenichel 47574c670d Merge pull request #2745 from rachel-fenichel/render/constants
Position notches
2019-07-30 14:05:39 -07:00
Beka Westberg c43e001634 Fixed DropDownDiv Rendering On Small Workspaces (#2641)
* Fixed dropdown div rendering when the workspace is too small.
2019-07-30 13:29:52 -07:00
Sam El-Husseini d2d621aec3 Update typings after removing references to goog.math (#2743)
* Update typings after removing references to goog.math
2019-07-30 13:19:14 -07:00
Rachel Fenichel 94fe97d9fd position notches 2019-07-30 11:38:18 -07:00
Sam El-Husseini 57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Sam El-Husseini 9d593f2cb8 TypeScript Definition file (#2738)
* Add Typescript definition file for Blockly
2019-07-30 11:17:57 -07:00
Sam El-Husseini 5ce8c68833 Fix node build and add node tests (#2736)
* Fix node build and add node tests
2019-07-30 11:13:52 -07:00
alschmiedt 8ef540a8dc Used moveBy in moveTo (#2741) 2019-07-30 10:50:59 -07:00
Sam El-Husseini 4622c95629 Fix screenToWsCoordinates jsdoc (#2737)
Fix typos in jsdoc
2019-07-30 10:08:52 -07:00
Rachel Fenichel d6acc66c4d Merge pull request #2732 from rachel-fenichel/render/constants
More work to move constants into objects
2019-07-29 16:12:21 -07:00
Rachel Fenichel b74fe2a6cc lint 2019-07-29 16:09:03 -07:00
Rachel Fenichel fd398ce75a Review cleanup 2019-07-29 16:04:44 -07:00
Sam El-Husseini 4c626e7b76 Fix setOnClickHandler jsdoc casing (#2730) 2019-07-29 15:29:06 -07:00
Rachel Fenichel bed30dfa68 Cleanup 2019-07-29 15:26:53 -07:00
Rachel Fenichel 97c8275bdf Merge pull request #2731 from BeksOmega/fixes/FlyoutDragging
Fixed flyout scrollbars not being updated when the flyout was dragged.
2019-07-29 15:17:37 -07:00
Rachel Fenichel 9ce8282568 Remove references to distance45outside 2019-07-29 14:58:51 -07:00
Neil Fraser 95b26d3f23 Basic linting
Untested.
2019-07-29 14:49:50 -07:00
Beka Westberg b45492c4b3 Fixed flyout scrollbars not being updated when the flyout was dragged. 2019-07-29 13:39:06 -07:00
alschmiedt 826409b01a Add tests for keyboard navigation (#2725) 2019-07-29 13:12:09 -07:00
alschmiedt 7dcc03e791 Fixes mocha tests (#2723) 2019-07-29 12:40:20 -07:00
Sam El-Husseini 0c75664b06 Fix IE flyout button callback (#2719) 2019-07-29 10:58:38 -07:00
Sandeep Dubey 44e559c4d9 Add correct link for blockly doc. (#2721) 2019-07-27 11:47:58 -07:00
Rachel Fenichel 36b4b18492 Quarantine highlights. 2019-07-26 17:33:10 -07:00
Rachel Fenichel 64cc3c5de6 Reduce number of direct references to the constants file 2019-07-26 16:41:06 -07:00
Ashwin Ramaswami 980412e723 Properly handle cases when sound.play() does not return a promise (#2614)
* Properly handle cases when sound.play() does not return a promise
2019-07-26 16:40:39 -07:00