Commit Graph

2478 Commits

Author SHA1 Message Date
Andrew n marshall
9cd6b1ec24 Print a warning if JSON color value is invalid. (#1639)
Ignores the invalid color, defaulting to black.
2018-02-21 13:55:32 -08:00
Andrew n marshall
2358fe6fd5 Adding test cases for Unicode in blocks. (#1646)
Adds test blocks to demonstrate capabilities. Stopped short of adding BiDi override characters.
I added to the toolbox category "Images". It isn't really images, but it didn't seem worth making a separate category at this stage.
2018-02-21 13:53:44 -08:00
Rachel Fenichel
09316c6bd4 Merge pull request #1647 from google/rachel-fenichel-patch-1
Update comment on loop types
2018-02-21 13:09:55 -08:00
Rachel Fenichel
e3700c02e4 Merge pull request #1651 from AnmAtAnm/rm-todos-in-docs
Moving TODO from doc comment to single line comment.
2018-02-21 11:06:31 -08:00
Rachel Fenichel
13cb64392f Fix some JsDoc annotations (#1650) 2018-02-21 11:01:01 -08:00
Andrew n marshall
91e2d03eea Moving TODO from doc comment to single line comment. 2018-02-21 10:58:52 -08:00
Rachel Fenichel
20b7b7a8eb Update comment on loop types
See https://groups.google.com/d/msg/blockly/v6W3BGN9P_o/RH91g94RBAAJ
2018-02-20 17:01:29 -08:00
Rachel Fenichel
c4d114eb0f Merge pull request #1644 from rachel-fenichel/bugfix/1642
Serialize variable IDs in procedure definitions
2018-02-20 14:20:52 -08:00
Andrew n marshall
8fcdbf0eae Adding new playground test category "Drag" (#1643)
Edge cases to test involving dragging blocks from the toolbox.
2018-02-20 14:12:44 -08:00
Rachel Fenichel
74fd58131b Serialize variable IDs in procedure definitions 2018-02-20 13:18:48 -08:00
Andrew n marshall
2aadfa6ac2 BlockFactory: Fixing incorrect <button> html (#1622)
Applies changes suggested in #1176, based off of develop.
2018-02-20 13:00:44 -08:00
Andrew n marshall
f45c6faf05 Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText() (#1638)
Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText()

The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
2018-02-16 16:51:18 -08:00
Andrew n marshall
4092a644d5 Adding a iframe wrapper around the playground. (#1634) 2018-02-16 16:48:11 -08:00
Andrew n marshall
d9a7f84b98 Adding test blocks into the playground (#1629)
The new toolbox option includes a number of test blocks
largely pulled from the android project, testing various
configurations and edge cases.
2018-02-16 11:14:40 -08:00
Rachel Fenichel
29dc4021f0 Merge pull request #1631 from rachel-fenichel/bugfix/1544
Delete extra variables at the end of a procedure argument edit
2018-02-16 11:11:42 -08:00
Rachel Fenichel
af59e27d96 Cleanup 2018-02-16 11:02:03 -08:00
Rachel Fenichel
f3a4664dea Delete extra variables at the end of a procedure argument edit 2018-02-15 17:18:23 -08:00
Rachel Fenichel
4c63eef022 Merge pull request #1620 from AnmAtAnm/closure-version
Updating Closure version
2018-02-14 16:51:25 -08:00
Andrew n marshall
446c1bbce4 Updateing Closure to 20180204.0.0 2018-02-14 16:15:43 -08:00
Rachel Fenichel
19969117ef Merge pull request #1617 from google/VariableXML
Reduce size of XML by omitting empty variable tag.
2018-02-14 14:13:41 -08:00
Neil Fraser
73417b8317 Reduce size of XML by omitting empty variable tag. 2018-02-14 11:22:55 -08:00
RoboErikG
551b05b4f1 Fix typo in BKY message key (#1616)
We had {% instead of %{

Fixes #1613
2018-02-14 10:52:49 -08:00
Mark Gibson
54f0e06e21 Customising field types using a register of fields #1584 (#1594)
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Rachel Fenichel
acaeeb4d2e Merge pull request #1610 from AnmAtAnm/rm-dropdown-init-forceRerender
Remove forceRerender() from FieldDropDown.init()
2018-02-13 17:14:58 -08:00
Andrew n marshall
e1e3f273d2 Remove forceRerender() from FieldDropDown.
Errantly forced whole block to rerender, including fields that
had not yet been initialized.

Fixes #1609
2018-02-13 15:01:33 -08:00
Rachel Fenichel
962c38b718 Merge pull request #1607 from rachel-fenichel/bugfix/1604
Break circular dependency
2018-02-13 13:00:03 -08:00
Rachel Fenichel
6aa06e9b48 Merge pull request #1605 from rachel-fenichel/bugfix/1600
Bugfix/1600
2018-02-13 10:46:38 -08:00
Rachel Fenichel
5e0928e4f3 Break circular dependency 2018-02-13 10:44:07 -08:00
Rachel Fenichel
2bd606c5e7 Fix comments 2018-02-13 10:41:57 -08:00
Rachel Fenichel
3a8fc92143 Indentation 2018-02-12 17:14:26 -08:00
Rachel Fenichel
744e70e4d2 Split playground toolbox XML into typed and untyped examples. 2018-02-12 17:12:52 -08:00
Rachel Fenichel
3463799d83 Merge pull request #1599 from rachel-fenichel/bugfix/sb-1373
Don't allow block deletion in the flyout.  Make copy-paste always copy to the main workspace
2018-02-12 14:43:40 -08:00
Andrew n marshall
dc7783ee01 Warn conflicts with Blockly.Generator.prototype (#1603)
Console warning if block prototypeName conflicts with Blockly.Generator.prototype.
2018-02-12 13:44:54 -08:00
Rachel Fenichel
f471a23b2b Add comment 2018-02-12 13:25:07 -08:00
Andrew n marshall
03538c19a7 Fix #1601
Correct deprecated argument order in domToWorksapce call in WorkspaceFactory.
2018-02-12 12:52:34 -08:00
Rachel Fenichel
4a4a0fe569 Merge pull request #1596 from rachel-fenichel/master_to_develop
Master to develop
2018-02-09 10:55:46 -08:00
Rachel Fenichel
57852f0249 Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace. 2018-02-08 17:23:22 -08:00
Rachel Fenichel
90b0f34c08 Merge pull request #1597 from rachel-fenichel/bugfix/1554
Make WorkspaceSvg.refreshToolboxSelection_ package instead of private
2018-02-08 16:51:40 -08:00
Rachel Fenichel
6a018515af Make WorkspaceSvg.refreshToolboxSelection_ package instead of private 2018-02-08 16:45:19 -08:00
Rachel Fenichel
3635657029 Rebuild 2018-02-08 16:05:09 -08:00
Rachel Fenichel
f2641d36aa Merge branch 'master' of https://github.com/google/blockly into master_to_develop 2018-02-08 15:48:24 -08:00
Andrew n marshall
cf1c69686d In Code demo, give warning if a generator function is missing. (#1585)
Refactored renderContent() to use new attemptCodeGeneration()
function, reducing code duplication.
attemptCodeGeneration() now calls checkAllGeneratorFunctionsDefined()
before running the generator.
2018-02-08 13:01:33 -08:00
translatewiki.net
99f977e5c9 Localisation updates from https://translatewiki.net. 2018-02-08 09:52:28 +01:00
Rachel Fenichel
e58c8a32d4 Merge pull request #1590 from rachel-fenichel/feature/bubble_dragger
Create a Dragger for moving bubbles around
2018-02-07 14:19:23 -08:00
Rachel Fenichel
85cb2b8c41 Merge pull request #1592 from jollytoad/feature-1486-fields-fromJson
Fields should implement fromJson #1486
2018-02-07 11:22:15 -08:00
Mark Gibson
28d3d68b62 Fix fromJson_ to fromJson in tests 2018-02-07 18:30:22 +00:00
Mark Gibson
2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson
6ab7cd25f5 Missing semi-colon! 2018-02-07 12:44:01 +00:00
Mark Gibson
d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel
4ddba5aadb rebuild 2018-02-06 19:00:32 -08:00