Commit Graph

2198 Commits

Author SHA1 Message Date
Karishma Chadha aae1b1bb74 Addressing PR comment. Moving functionality to get newly added variables into a helper function. 2017-11-22 14:51:11 -05:00
Karishma Chadha ee142e92bb Fixing comment style. 2017-11-22 13:43:25 -05:00
Karishma Chadha c950225897 Minor refactoring 2017-11-22 13:37:30 -05:00
Karishma Chadha 71205de2ef Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace. 2017-11-22 13:27:29 -05:00
Karishma Chadha 07d6624625 Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace. 2017-11-22 12:50:00 -05:00
Neil Fraser 3a6d84e0c2 Fix alignment of language menu when RTL. 2017-11-21 17:32:43 -08:00
Rachel Fenichel 662757ab7d Switch to parentNode for IE 2017-11-20 16:50:21 -08:00
Rachel Fenichel b51b47fdbf Merge pull request #1457 from rachel-fenichel/bugfix/force_rerender
Call forceRerender instead of setText
2017-11-17 15:45:21 -08:00
Rachel Fenichel 3b81eede3e Call forceRerender instead of setText 2017-11-17 14:39:12 -08:00
Rachel Fenichel 6a2112641f Merge pull request #1453 from microsoftsam/develop
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 10:39:56 -08:00
Sam El-Husseini ee81be9595 Merge pull request #1 from microsoftsam/fixrtlbuttonscale
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 00:55:22 -08:00
Sam El-Husseini ee7ad3dfef Fix right aligned Flyout buttons when workspace is scaled 2017-11-16 00:53:07 -08:00
RoboErikG bcedc130bb Fix #1444 - broken mutator for text_charat (#1451)
* Fix #1444 - broken mutator for text_charat

There might no longer be an input named AT on a text_charat block
which the mutator had been depending on. There is now a boolean on
the block for isAt, though, so use that directly instead.

The

* Address comments
2017-11-15 12:21:07 -08:00
Neil Fraser 5707657569 Stop blocks from exploding.
Uncompiled a goog.math.Coordinate toStrings as a nice “(1, 2)”, but
complied it toStrings as a useless “[object Object]”.  Fixes #1448.
2017-11-14 15:44:09 -08:00
Andrew n marshall aa78a8b566 Better error reporting when the test XML fails to load. (#1443) 2017-11-14 13:36:38 -08:00
Neil Fraser eb796b71de Prevent selection of toolbox categories. 2017-11-13 15:30:33 -08:00
Rachel Fenichel 383d133c1e Merge pull request #1434 from google/lint
Enable eslint on Travis!
2017-11-10 16:34:18 -08:00
Rachel Fenichel fec346548c Merge pull request #1436 from rachel-fenichel/master_to_develop
Merge master->develop
2017-11-10 15:04:55 -08:00
Rachel Fenichel 078932a652 ignore more types of tests 2017-11-10 14:16:47 -08:00
Rachel Fenichel f4b7a8851f Eslint ignore svg-externs.js 2017-11-10 14:16:47 -08:00
Rachel Fenichel 75d0798e4a Run eslint on travis 2017-11-10 14:16:47 -08:00
Rachel Fenichel 65ac665b81 Removed files that were accidentally added when merging from master 2017-11-10 14:13:06 -08:00
Rachel Fenichel 6c56d1d87d Merge branch 'master' into master_to_develop 2017-11-10 14:03:14 -08:00
Neil Fraser dac5adf49f Remove unnecessary restriction on variable names. 2017-11-07 17:29:39 -08:00
Rachel Fenichel 13aa7bfb69 No-regex-spaces 2017-11-07 17:27:00 -08:00
Neil Fraser 8a398ab334 Add @package 2017-11-07 14:23:41 -08:00
Neil Fraser 3bf0418460 Right-align flyout buttons in RTL.
Fixes #1208.
2017-11-07 14:23:41 -08:00
Neil Fraser 8cedef49ac Cleanup. 2017-11-07 14:23:41 -08:00
Neil Fraser 7216c060bd Terminology: "background button" -> "mat"
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks.  When UI buttons were added to flyounts, there
was a terminology collision.  This change renames the original
background ‘buttons’ to ‘mats’.  As in placemats or door mats.
2017-11-07 14:23:41 -08:00
Neil Fraser 626447afb2 Restore Translations (#1396)
* Remove English from Tagalog.

* Resurrect translations for TEXT_INDEXOF_TITLE

* Resurrect translations for TEXT_APPEND_TITLE

* Resolve compile warnings.
2017-11-07 13:14:56 -08:00
RoboErikG 53e6bddff5 Use msg references in block JSON for text_charat (#1426) 2017-11-06 13:05:09 -08:00
Rachel Fenichel f06aed4710 Fix text input widget position in RTL 2017-11-06 12:50:22 -08:00
translatewiki.net 2fae5513b2 Localisation updates from https://translatewiki.net. 2017-11-06 08:56:44 +01:00
Rachel Fenichel 66586bf622 Add a test for case-sensitivity in the variable names, ids, etc. in the flyout 2017-11-03 16:03:32 -07:00
Rachel Fenichel 30716fbd78 switch to variabletype everywhere 2017-11-03 16:03:32 -07:00
Rachel Fenichel a6457ef614 Get rid of highlighting when releasing the drag would delete instead of connecting 2017-11-03 15:47:15 -07:00
Rachel Fenichel 768bd4aef5 Check workspace.isDragging() instead of Blockly.dragMode_ 2017-11-03 15:46:41 -07:00
Rachel Fenichel 432881d2c1 Make quote images meet line length requirements 2017-11-03 14:04:36 -07:00
Rachel Fenichel 8c51935025 More lint for unused variables 2017-11-03 14:04:36 -07:00
Rachel Fenichel cd9be725c1 fix lint in field_angle.js 2017-11-02 16:37:09 -07:00
picklesrus e0f7862547 spacing changes 2017-11-02 14:05:29 -07:00
picklesrus de8d13eaa1 Fix lint errors so we can eventually run eslint on travis. 2017-11-02 14:05:29 -07:00
RoboErikG c4b2899007 Fix #1397 by being more careful with mutator (#1410)
* Fix #1397 by being more careful with mutator

The text_charAt mutator was replacing more of the title string than
necessary, which would lead to losing some of the relevant text in
the label. Updated the mutator to only add/remove a new input on the
end instead of replacing the default dummy input.

* Code cleanup
2017-11-02 09:37:31 -07:00
translatewiki.net cf6bebb6fa Localisation updates from https://translatewiki.net. 2017-11-02 08:08:37 +01:00
Neil Fraser 6635dada6d Allow external code to load new audio. (#1409)
If external code can ‘play’, it should be able to ‘load’.  Resolves
compile error in Blockly Games.  Feel free to push back if this API
shouldn’t be public.

Also fix compiler warnings on block defs.  ‘undefined’ means undefined, ‘=‘ means optional.
2017-11-01 17:47:24 -07:00
Neil Fraser 63637a927a Remove unnecessary restriction on variable names. 2017-11-01 12:08:53 -07:00
translatewiki.net e93d44e8ff Localisation updates from https://translatewiki.net. 2017-10-30 08:58:58 +01:00
Neil Fraser 905d542ae5 Switch compile to HTTPS. 2017-10-27 17:44:54 -07:00
Neil Fraser 2ff345fa4e Adding PHP to comment.
And normalizing order of languages.
2017-10-27 17:44:54 -07:00
Neil Fraser d503e1c05b Reenable compressed builds. 2017-10-27 17:44:54 -07:00