Commit Graph

2215 Commits

Author SHA1 Message Date
Neil Fraser
bc1a5baa48 Fixes to Generator tests (#1510)
* Remove unneeded report variable from generator tests.
* Fix missing message parameter in unittest_fail.  This was a compile error in Dart.
* Fix indentation in PHP.
* Equality helper function not needed in PHP.
2017-12-12 17:38:38 -08:00
Rachel Fenichel
0cb5dfc437 Merge pull request #1492 from Kenny2github/patch-1
Remove "fake some drags!"
2017-12-11 17:12:11 -08:00
RoboErikG
0142aa0e94 Don't require flyouts to run Blockly (#1502)
* Don't require flyouts to run Blockly

There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.

* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du
383f1d9bac Develop (#1501)
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG
a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
Tianwei Du
492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
Rachel Fenichel
404373e53a Merge pull request #1496 from rachel-fenichel/bugfix/1467
Fix #1467
2017-12-07 15:06:37 -08:00
Rachel Fenichel
7ef19b6851 Fix #1467 2017-12-06 17:00:22 -08:00
Rachel Fenichel
1d78d7be45 Merge pull request #1483 from DubeySandeep/ScrollableDropdowns
Added scrollable functionality to dropdown menu
2017-12-04 10:39:43 -08:00
picklesrus
d1886572d0 Fix #1487 and only add the delete cursor if the block is not deletabl… (#1491)
* Fix #1487 and only add the delete cursor if the block is not deletable. Also add a grab cursor when it is not deletable so the cursor keeps the grab hand when over the toolbox.  This changes the toolbox api slightly, but the methods it touches are @package so it should be okay.
2017-12-04 10:36:47 -08:00
Sandeep Dubey
2dd8c1f669 Made the changes asked by the reviewer 2017-12-03 02:40:11 +05:30
Ken
c53dec9786 Remove "fake some drags!"
Removed the button, the "fakeDrag" and "fakeManyDrags" and "fakeDragWrapper", and the "fakeDragStack" list.
2017-12-02 11:47:46 +08:00
Rachel Fenichel
a6603b462a Merge pull request #1489 from rachel-fenichel/cleanup/field_to_dom
Blockly.Xml code cleanup : fields
2017-11-30 13:12:00 -08:00
Rachel Fenichel
222407c6ce Extract code for domToField_ 2017-11-30 12:08:01 -08:00
Rachel Fenichel
d73337ad73 Extract fieldToDom into its own function 2017-11-30 11:24:57 -08:00
Rachel Fenichel
762e8d9c38 Merge pull request #1477 from kchadha/varcreate-bugfix
VarCreate bugfix
2017-11-22 12:56:31 -08:00
Karishma Chadha
143d95222c Fixing type annotation. 2017-11-22 15:22:34 -05:00
Karishma Chadha
aae1b1bb74 Addressing PR comment. Moving functionality to get newly added variables into a helper function. 2017-11-22 14:51:11 -05:00
Karishma Chadha
ee142e92bb Fixing comment style. 2017-11-22 13:43:25 -05:00
Karishma Chadha
c950225897 Minor refactoring 2017-11-22 13:37:30 -05:00
Karishma Chadha
71205de2ef Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace. 2017-11-22 13:27:29 -05:00
Karishma Chadha
07d6624625 Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace. 2017-11-22 12:50:00 -05:00
Neil Fraser
3a6d84e0c2 Fix alignment of language menu when RTL. 2017-11-21 17:32:43 -08:00
Rachel Fenichel
662757ab7d Switch to parentNode for IE 2017-11-20 16:50:21 -08:00
Rachel Fenichel
b51b47fdbf Merge pull request #1457 from rachel-fenichel/bugfix/force_rerender
Call forceRerender instead of setText
2017-11-17 15:45:21 -08:00
Rachel Fenichel
3b81eede3e Call forceRerender instead of setText 2017-11-17 14:39:12 -08:00
Rachel Fenichel
6a2112641f Merge pull request #1453 from microsoftsam/develop
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 10:39:56 -08:00
Sam El-Husseini
ee81be9595 Merge pull request #1 from microsoftsam/fixrtlbuttonscale
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 00:55:22 -08:00
Sam El-Husseini
ee7ad3dfef Fix right aligned Flyout buttons when workspace is scaled 2017-11-16 00:53:07 -08:00
RoboErikG
bcedc130bb Fix #1444 - broken mutator for text_charat (#1451)
* Fix #1444 - broken mutator for text_charat

There might no longer be an input named AT on a text_charat block
which the mutator had been depending on. There is now a boolean on
the block for isAt, though, so use that directly instead.

The

* Address comments
2017-11-15 12:21:07 -08:00
Neil Fraser
5707657569 Stop blocks from exploding.
Uncompiled a goog.math.Coordinate toStrings as a nice “(1, 2)”, but
complied it toStrings as a useless “[object Object]”.  Fixes #1448.
2017-11-14 15:44:09 -08:00
Andrew n marshall
aa78a8b566 Better error reporting when the test XML fails to load. (#1443) 2017-11-14 13:36:38 -08:00
Neil Fraser
eb796b71de Prevent selection of toolbox categories. 2017-11-13 15:30:33 -08:00
Rachel Fenichel
383d133c1e Merge pull request #1434 from google/lint
Enable eslint on Travis!
2017-11-10 16:34:18 -08:00
Rachel Fenichel
fec346548c Merge pull request #1436 from rachel-fenichel/master_to_develop
Merge master->develop
2017-11-10 15:04:55 -08:00
Rachel Fenichel
078932a652 ignore more types of tests 2017-11-10 14:16:47 -08:00
Rachel Fenichel
f4b7a8851f Eslint ignore svg-externs.js 2017-11-10 14:16:47 -08:00
Rachel Fenichel
75d0798e4a Run eslint on travis 2017-11-10 14:16:47 -08:00
Rachel Fenichel
65ac665b81 Removed files that were accidentally added when merging from master 2017-11-10 14:13:06 -08:00
Rachel Fenichel
6c56d1d87d Merge branch 'master' into master_to_develop 2017-11-10 14:03:14 -08:00
Neil Fraser
dac5adf49f Remove unnecessary restriction on variable names. 2017-11-07 17:29:39 -08:00
Rachel Fenichel
13aa7bfb69 No-regex-spaces 2017-11-07 17:27:00 -08:00
Neil Fraser
8a398ab334 Add @package 2017-11-07 14:23:41 -08:00
Neil Fraser
3bf0418460 Right-align flyout buttons in RTL.
Fixes #1208.
2017-11-07 14:23:41 -08:00
Neil Fraser
8cedef49ac Cleanup. 2017-11-07 14:23:41 -08:00
Neil Fraser
7216c060bd Terminology: "background button" -> "mat"
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks.  When UI buttons were added to flyounts, there
was a terminology collision.  This change renames the original
background ‘buttons’ to ‘mats’.  As in placemats or door mats.
2017-11-07 14:23:41 -08:00
Neil Fraser
626447afb2 Restore Translations (#1396)
* Remove English from Tagalog.

* Resurrect translations for TEXT_INDEXOF_TITLE

* Resurrect translations for TEXT_APPEND_TITLE

* Resolve compile warnings.
2017-11-07 13:14:56 -08:00
RoboErikG
53e6bddff5 Use msg references in block JSON for text_charat (#1426) 2017-11-06 13:05:09 -08:00
Rachel Fenichel
f06aed4710 Fix text input widget position in RTL 2017-11-06 12:50:22 -08:00
translatewiki.net
2fae5513b2 Localisation updates from https://translatewiki.net. 2017-11-06 08:56:44 +01:00