Commit Graph

4316 Commits

Author SHA1 Message Date
alschmiedt bc4cb542e8 Fix capitalization (#3182) 2019-10-07 13:05:49 -07:00
RoboErikG 663809297d Set correct defaults for Fields (#3179)
null was being converted to 0 by Number() when it should cause the
default value to be set instead. This updates FieldNumber and
FieldAngle to handle nulls correctly. Also update jsdoc.

Fixes #3177
2019-10-07 11:38:32 -07:00
Beka Westberg a08d9f2277 Re-added resizeBubble_ call. Fixed resizeBubble_ JSDoc. (#3173) 2019-10-07 11:08:45 -07:00
Sam El-Husseini 2ac4149d98 Misc compiler warnings. (#3172)
* Fix misc compiler warnings. Use ws.getToolbox() instead of ws.toolbox_
2019-10-07 11:06:56 -07:00
Rachel Fenichel 608ce7b93c Merge pull request #3133 from BeksOmega/fixes/ConnectionTracking
Connection Tracking Pt 3: Changed connections to use 'tracked_' property
2019-10-07 11:05:10 -07:00
translatewiki.net ddd0cb5632 Localisation updates from https://translatewiki.net. 2019-10-07 19:41:12 +02:00
Beka Westberg e09a7b8165 Renamed doNotCallTrackConnections_ to callTrackConnections. Flipped logic. Moved it to the constructor. 2019-10-05 12:28:25 -07:00
Sam El-Husseini db33e821da Remove call to setText in playground (#3168)
* Remove last instance of setText
2019-10-04 15:57:35 -07:00
Rachel Fenichel b342a12911 Merge pull request #3155 from rachel-fenichel/trashcan_visibility
Make trashcan setOpen package and update a few annotations.
2019-10-04 15:55:15 -07:00
Rachel Fenichel a5377c1e08 Merge pull request #3154 from rachel-fenichel/disposal_cleanup
Get rid of unnecessary nulls in block dragger, insertion marker manag…
2019-10-04 15:53:42 -07:00
Rachel Fenichel 0484b6623b Merge pull request #3164 from samelhusseini/merge_master
Merge master into develop
2019-10-04 13:50:59 -07:00
Sam El-Husseini 7fe78a3050 Merge branch 'master' into merge_master 2019-10-04 13:45:00 -07:00
Sam El-Husseini 7d83cc57e8 Rebuild typings: (#3163) 2019-10-04 13:32:43 -07:00
Rachel Fenichel 3ea43a2821 Merge pull request #3162 from rachel-fenichel/rebuild_10_04_19
Rebuild
2019-10-04 13:27:40 -07:00
Rachel Fenichel a9c0dcf146 Rebuild 2019-10-04 13:17:05 -07:00
Sam El-Husseini 74ecb94078 Remove last instance of Object.assign (#3161) 2019-10-04 13:06:58 -07:00
Sam El-Husseini 893461384e Fix UMD build in IE11 (#3158)
* Fix the UMD build in IE11. No Object.assign
2019-10-04 10:03:58 -07:00
Beka Westberg bc68167763 Removed Object.assign() from turtle demo (#3157)
* Removed Object.assign() from turtle demo.
2019-10-03 19:39:06 -07:00
Sam El-Husseini 80aac249ea Make bumpNeighbours public. (#3156) 2019-10-03 19:31:55 -07:00
Rachel Fenichel 79c2fa6688 Make trashcan setOpen package and update a few annotations. 2019-10-03 18:08:27 -07:00
Rachel Fenichel 45d66a1264 Get rid of unnecessary nulls in block dragger, insertion marker manager, and gesture dispose functions. 2019-10-03 17:58:29 -07:00
Sam El-Husseini e4cc2217e6 Fix compiler warnings related to events. (#3151)
* Fix 23 warnings in event related code.
2019-10-03 15:59:01 -07:00
Sam El-Husseini d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Sam El-Husseini 7839512f0e When collapsed, toString was referencing text_. Using getText instead. (#3150) 2019-10-03 15:26:41 -07:00
Sam El-Husseini e5ec726253 Fix type, caught by typings 2019-10-03 14:41:15 -07:00
Sam El-Husseini fba98fca5b Move the dropdown field into the dropdown div. (#3122)
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00
Sam El-Husseini e92bae1dda Download screenshot in playground (#3148)
* Add an option on the playground to download a screenshot of the blocks on the workspace.
2019-10-03 14:35:12 -07:00
Rachel Fenichel f2812df7dd Merge pull request #3147 from rachel-fenichel/misc_cleanup
Misc cleanup
2019-10-03 14:27:03 -07:00
Rachel Fenichel c5e691b88b Update workspace_svg.js 2019-10-03 14:26:42 -07:00
Sam El-Husseini 735a72c20a mutation / compose fn annotations (#3149)
* Add compose / decompose type annotations.
2019-10-03 14:25:07 -07:00
Neil Fraser f5909c9916 Restore require variables to blockly.js (#3145)
Variables and Xml are circular dependencies.  Both need to be declared in blockly.js

Maybe they can be sorted out later, but for now things are broken since nobody in core currently requires variables anywhere.
2019-10-03 14:14:19 -07:00
Rachel Fenichel f9e54b033a Merge pull request #3146 from rachel-fenichel/sign_error
Signs are hard.
2019-10-03 11:26:06 -07:00
Rachel Fenichel 05e9cf126a Signs are hard. 2019-10-03 10:47:27 -07:00
Rachel Fenichel 78dc82f7ac Misc cleanup: annotations, and flyoutButton disposal. 2019-10-03 10:40:43 -07:00
Rachel Fenichel 77e64b39bc Remove unused nulls in disposal 2019-10-02 17:10:41 -07:00
Rachel Fenichel 771d6a119e Merge pull request #3143 from rachel-fenichel/remove_block_render_svg
Remove block_render_svg
2019-10-02 16:33:47 -07:00
Rachel Fenichel 668731b545 add visibility annotations 2019-10-02 16:29:32 -07:00
Rachel Fenichel 7ed47670cf Remove block_render_svg 2019-10-02 16:21:36 -07:00
Rachel Fenichel 79bedca5a7 Element -> SVGElement (#3140)
* Use SVGElement instead of Element for the results of createSvgElement

* More SVGElement annotations.
2019-10-02 16:12:31 -07:00
Sam El-Husseini eb5f1cc94a Fix 6 warnings in components/ (#3141) 2019-10-02 16:12:17 -07:00
Neil Fraser c6b8cd69b5 Update newly added licenses.
The minimalist rendere was added while the licenses PR was waiting for review.
2019-10-02 15:33:42 -07:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini 31a2544989 Rename sample renderer to minimalist (#3137)
* Rename sample to minimalist
2019-10-02 14:16:36 -07:00
Sam El-Husseini d28e897e47 Add a sample renderer instance. (#3136)
* Add a sample renderer instance.
2019-10-02 13:22:54 -07:00
Sam El-Husseini 99ce193b1f Base renderer next / prev connection fixes. (#3135) 2019-10-02 12:35:00 -07:00
Rachel Fenichel d7cc808d1f Merge pull request #3134 from rachel-fenichel/bugfix/3098
Bound element position based on height of the row
2019-10-02 11:44:37 -07:00
Sam El-Husseini 1236660efd Actually make WS comments optional (#3130)
* Remove last reference to ws comments since its an optional module

* Also remove from workspace
2019-10-02 11:41:51 -07:00
Sam El-Husseini f22603f32a Call onHide before clearing content (#3131) 2019-10-02 11:41:34 -07:00
Rachel Fenichel 6b78417ede Bound element position based on height of the row 2019-10-02 11:27:26 -07:00
Rachel Fenichel 1a461362b6 Merge pull request #3129 from rachel-fenichel/spacer_height
Use row height for spacer height.
2019-10-02 10:31:00 -07:00