Reverts the storage mechanism introduced in #9611 (constructable
stylesheets via `adoptedStyleSheets`) while keeping the per-root
injection-site tracking that #9611 added for shadow-DOM support.
Motivations:
- Safari 15.4 compatibility. `new CSSStyleSheet()` and
`adoptedStyleSheets` require Safari 16.4+
- Cascade order. `adoptedStyleSheets` apply after `<style>`/`<link>`
elements in the document, so Blockly's defaults silently overrode
host stylesheets. Prepending a `<style>` to the head (or to the
shadow root) restores the pre-#9611 behavior where any author
stylesheet declared later wins on specificity ties.
Trade-offs:
- Per-shadow-root CSS text is duplicated rather than shared via a
single adopted sheet object. Negligible for typical use.
- `Css.register()` calls made after the first `inject()` no longer
reach already-injected roots (same as #9611's behavior); subsequent
`inject()` calls into other roots still pick them up. Web-component
consumers can legitimately register late, so this is preferred to
reinstating the pre-#9611 throw.
Fixes#9876
The controls_ifelse block was using the controls_if_tooltip dynamic
extension, which reads this.elseifCount_ and this.elseCount_ set by
the controls_if_mutator. Since controls_ifelse has no mutator, both
counts are undefined and the extension always returned TOOLTIP_1 (for
a simple if), instead of TOOLTIP_2 (for if/else).
The static tooltip already declared on the block was unreachable
because of a typo (BKYCONTROLS_IF_TOOLTIP_2 was missing the underscore
after BKY) and would have been overridden by the extension anyway.
Fix the message key typo and drop the extension so the static
TOOLTIP_2 string is displayed instead.
Fixes#9813
Signed-off-by: sheitabrk <44614193+sheitabrk@users.noreply.github.com>
* chore(docs): update keyboard shortcut page for v13
* chore(docs): update nesting on keyboard nav documentation
* chore(docs): remove references to META keycode in favor of CTRL_CMD
* chore(docs): Update explanation of keyboard navigation
* chore(docs): add compliance info for keyboard nav
* chore(docs): refer to command and control instead of meta
* fix: insert custom input label before children
* fix: do not add empty field labels to block label
* fix: revert ariaLabelProvider changes
* fix: add override designation
* fix: update test after merge conflict
* fix: Improve display of workspace focus rings
* fix: Only bind tab listener once
* refactor: Make setup of workspace focus rings more consistent with other DOM elements
* fix: Fix major performance regression in test suite (and perhaps IRL)
* fix: Fix adding of class in `DropDownDiv`
* test: Add tests for adding/removing showing*Div classes
Michael Harvey
Robert Knight
Maribeth Moffatt
Matt Hillsdon
Aaron Dodson
Sheita
github-actions[bot]
Rachel Fenichel
lizschwab