Rachel Fenichel
e4844cd120
Move getOrCreateVariable to variables.js
2017-12-05 13:08:01 -08:00
Rachel Fenichel
39e689b458
Fix default variable name
2017-12-04 15:52:53 -08:00
Rachel Fenichel
c802125d37
Make unique variable names in the flyout
2017-12-04 15:46:44 -08:00
Rachel Fenichel
6bb048d1bb
All tests pass
2017-12-04 14:29:16 -08:00
Rachel Fenichel
d1c2401fcf
All but XML tests now pass
2017-12-04 14:19:19 -08:00
Rachel Fenichel
a8a83a77a7
Move code from renameVariableInternal to renameVariableById
2017-12-01 16:22:52 -08:00
Rachel Fenichel
b78264a33e
Update tests in workspace_test. Get rid of renameVariable
2017-12-01 16:21:19 -08:00
Rachel Fenichel
494c4882be
Fix variable_map_test and variable_model_test
2017-12-01 14:05:37 -08:00
Rachel Fenichel
fa02e56c17
Fix tests in field_variable_test.js
2017-12-01 14:04:10 -08:00
Rachel Fenichel
25913884ab
Delete by id
2017-11-30 17:21:12 -08:00
Rachel Fenichel
112fcccb31
Fix renaming
2017-11-30 17:12:39 -08:00
Rachel Fenichel
86e88aae92
Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables
2017-11-30 16:30:58 -08:00
Rachel Fenichel
3c76028e14
Add TODOs and fix return type
2017-11-30 13:16:17 -08:00
Rachel Fenichel
b870c3ccb9
Allow variables of different types to share the same name.
2017-11-30 13:16:16 -08:00
Rachel Fenichel
a6603b462a
Merge pull request #1489 from rachel-fenichel/cleanup/field_to_dom
...
Blockly.Xml code cleanup : fields
2017-11-30 13:12:00 -08:00
Rachel Fenichel
222407c6ce
Extract code for domToField_
2017-11-30 12:08:01 -08:00
Rachel Fenichel
d73337ad73
Extract fieldToDom into its own function
2017-11-30 11:24:57 -08:00
Rachel Fenichel
762e8d9c38
Merge pull request #1477 from kchadha/varcreate-bugfix
...
VarCreate bugfix
2017-11-22 12:56:31 -08:00
Karishma Chadha
143d95222c
Fixing type annotation.
2017-11-22 15:22:34 -05:00
Karishma Chadha
aae1b1bb74
Addressing PR comment. Moving functionality to get newly added variables into a helper function.
2017-11-22 14:51:11 -05:00
Karishma Chadha
ee142e92bb
Fixing comment style.
2017-11-22 13:43:25 -05:00
Karishma Chadha
c950225897
Minor refactoring
2017-11-22 13:37:30 -05:00
Karishma Chadha
71205de2ef
Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace.
2017-11-22 13:27:29 -05:00
Karishma Chadha
07d6624625
Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace.
2017-11-22 12:50:00 -05:00
Neil Fraser
3a6d84e0c2
Fix alignment of language menu when RTL.
2017-11-21 17:32:43 -08:00
Rachel Fenichel
662757ab7d
Switch to parentNode for IE
2017-11-20 16:50:21 -08:00
Rachel Fenichel
b51b47fdbf
Merge pull request #1457 from rachel-fenichel/bugfix/force_rerender
...
Call forceRerender instead of setText
2017-11-17 15:45:21 -08:00
Rachel Fenichel
3b81eede3e
Call forceRerender instead of setText
2017-11-17 14:39:12 -08:00
Rachel Fenichel
6a2112641f
Merge pull request #1453 from microsoftsam/develop
...
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 10:39:56 -08:00
Sam El-Husseini
ee81be9595
Merge pull request #1 from microsoftsam/fixrtlbuttonscale
...
Fix positioning of right aligned Flyout buttons when workspace is scaled
2017-11-16 00:55:22 -08:00
Sam El-Husseini
ee7ad3dfef
Fix right aligned Flyout buttons when workspace is scaled
2017-11-16 00:53:07 -08:00
RoboErikG
bcedc130bb
Fix #1444 - broken mutator for text_charat ( #1451 )
...
* Fix #1444 - broken mutator for text_charat
There might no longer be an input named AT on a text_charat block
which the mutator had been depending on. There is now a boolean on
the block for isAt, though, so use that directly instead.
The
* Address comments
2017-11-15 12:21:07 -08:00
Neil Fraser
5707657569
Stop blocks from exploding.
...
Uncompiled a goog.math.Coordinate toStrings as a nice “(1, 2)”, but
complied it toStrings as a useless “[object Object]”. Fixes #1448 .
2017-11-14 15:44:09 -08:00
Andrew n marshall
aa78a8b566
Better error reporting when the test XML fails to load. ( #1443 )
2017-11-14 13:36:38 -08:00
Neil Fraser
eb796b71de
Prevent selection of toolbox categories.
2017-11-13 15:30:33 -08:00
Rachel Fenichel
383d133c1e
Merge pull request #1434 from google/lint
...
Enable eslint on Travis!
2017-11-10 16:34:18 -08:00
Rachel Fenichel
fec346548c
Merge pull request #1436 from rachel-fenichel/master_to_develop
...
Merge master->develop
2017-11-10 15:04:55 -08:00
Rachel Fenichel
078932a652
ignore more types of tests
2017-11-10 14:16:47 -08:00
Rachel Fenichel
f4b7a8851f
Eslint ignore svg-externs.js
2017-11-10 14:16:47 -08:00
Rachel Fenichel
75d0798e4a
Run eslint on travis
2017-11-10 14:16:47 -08:00
Rachel Fenichel
65ac665b81
Removed files that were accidentally added when merging from master
2017-11-10 14:13:06 -08:00
Rachel Fenichel
6c56d1d87d
Merge branch 'master' into master_to_develop
2017-11-10 14:03:14 -08:00
Neil Fraser
dac5adf49f
Remove unnecessary restriction on variable names.
2017-11-07 17:29:39 -08:00
Rachel Fenichel
13aa7bfb69
No-regex-spaces
2017-11-07 17:27:00 -08:00
Neil Fraser
8a398ab334
Add @package
2017-11-07 14:23:41 -08:00
Neil Fraser
3bf0418460
Right-align flyout buttons in RTL.
...
Fixes #1208 .
2017-11-07 14:23:41 -08:00
Neil Fraser
8cedef49ac
Cleanup.
2017-11-07 14:23:41 -08:00
Neil Fraser
7216c060bd
Terminology: "background button" -> "mat"
...
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks. When UI buttons were added to flyounts, there
was a terminology collision. This change renames the original
background ‘buttons’ to ‘mats’. As in placemats or door mats.
2017-11-07 14:23:41 -08:00
Neil Fraser
626447afb2
Restore Translations ( #1396 )
...
* Remove English from Tagalog.
* Resurrect translations for TEXT_INDEXOF_TITLE
* Resurrect translations for TEXT_APPEND_TITLE
* Resolve compile warnings.
2017-11-07 13:14:56 -08:00
RoboErikG
53e6bddff5
Use msg references in block JSON for text_charat ( #1426 )
2017-11-06 13:05:09 -08:00
