Commit Graph

861 Commits

Author SHA1 Message Date
Sam El-Husseini
67a6bfd0cf Fix travis 2020-11-17 14:15:51 -08:00
Monica Kozbial
dd0d5aee53 Adding procedure tests and handling procedures instantiated without name (#4428)
* Expand procedure tests and fix bug with default ids

* Add tests

* Remove xml_procedures_test.js and add non-overlapping test cases into procedures_test.js
2020-11-06 11:48:48 -08:00
Monica Kozbial
8361268c63 Refactor field_variable_tests to use dev-tools (#4417)
* Refactor field_variable_tests to use dev-tools
2020-11-06 11:35:00 -08:00
Monica Kozbial
637497148d Renaming ui event properties and updating documentation for consistency (#4432)
* Renaming properties and updating documentation for consistency

* Update more properties

* fix tests
2020-11-05 11:40:17 -08:00
Monica Kozbial
40ef586260 Refactoring Ui events in core (#4418)
* Ui events base (#4370)

* Add constants for new ui event types

* Add property to indicate an event as UI event

* Click events (#4372)

* Creating new ui base class.

* Refactor theme event (#4391)

* Add themeName property to theme event

* Refactor marker move events. (#4389)

* Refactor trashcan open event (#4392)

* Refactor selected event (#4387)

* Refactor toolbox item change event (#4394)

* Refactor bubble open events (#4390)

* Refactor block drag event (#4388)

* Viewport events (#4395)

* Fix event filtering for ui events (#4401)

* Move events to new directory and rename Ui events base (#4400)

* Move events to new directory and rename Ui events base

* Add missing fromJson implementation for click event (#4410)

* Adding serialization tests for events

* Zoom controls event (#4407)

* Refactor zoom event

* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
Monica Kozbial
9bcfa60e86 Add missing cleanup to multiline field test (#4416) 2020-11-02 16:37:17 -08:00
alschmiedt
f1498e7f07 Keyboard shortcuts (#4421)
* Adds shortcut registry and removes action and key map (#4398)

* Adds Shortcut tests and refactored navigation tests (#4412)

* Adds shortcut items (#4408)

* Add shortcuts for navigation (#4409)

* Add final keyboard shortcut cleanup (#4413)
2020-11-02 13:30:05 -08:00
alschmiedt
7eb9c498e6 Test Blockly.onKeyDown method (#4373) 2020-10-16 11:26:32 -07:00
Halit Anil Donmez
9bafa7e40d do value update if the value is valid again (#4351)
* do value update if the value is valid again

* update the logic at set value

* fix tests

* update logging
2020-10-07 11:05:02 -07:00
Monica Kozbial
3b1643f221 Refactor FieldImage tests to use dev-tools helpers (#4315)
* Refactor FieldImage tests to use dev-tools helpers
2020-10-07 10:43:44 -07:00
Monica Kozbial
e67e49ad9b Update FieldDropdown to use dev-tools helpers (#4316) 2020-10-02 14:15:20 -07:00
Sam El-Husseini
70f71af933 Add test-blocks into the basic playground (#4333)
* Use local node_modules files instead of unkpkg for advanced playground, get test blocks in the basic playground from npm

* Also move theme-modern

* Update package-lock
2020-10-02 09:48:01 -07:00
Monica Kozbial
6ec002e3d4 Adding tests for multiline block (#4317)
* Adding tests for multiline input
2020-09-30 15:20:35 -07:00
Monica Kozbial
81d355f5fa Fix order errors in text generators (#4329)
* Fix dart text generator logic

* Fix Javascript text generator logic.

* Fix Lua text generator logic

* Fix php text generator logic

* Fix python text generator logic

* Fix error in substring logic

* Fix unit test block generators

* Update from ORDER_COMMA to ORDER_NONE

* Update golden files
2020-09-30 14:08:45 -07:00
Monica Kozbial
dec7463a49 Update FieldCheckbox and FieldColour setValue tests (#4332)
* update FieldCheckbox setValue tests

* update FieldColout setValue tests
2020-09-29 10:09:05 -07:00
Monica Kozbial
76fabc91f7 Capture deprecation warnings in tests that have associated bugs (#4314) 2020-09-29 09:57:17 -07:00
Monica Kozbial
3b364976aa Procedures test workspace cleanup (#4311)
* Add basic cleanup.

* Refactor to ensure proper workspace cleanup

* Remove unecessary variable cleanup

* Uncomment out logic
2020-09-28 10:49:32 -07:00
alschmiedt
3d698f4bcc Block factory fix (#4327) 2020-09-28 10:42:45 -07:00
Maribeth Bottorff
4ea112fcd3 Don't undo the change events from disableOrphans (#4304) 2020-09-25 11:46:29 -07:00
Monica Kozbial
81ee330eb9 Update metadata sizes for new release (#4323) 2020-09-24 15:31:02 -07:00
Rachel Fenichel
f840bec037 Reorder more 2020-09-24 12:41:47 -07:00
Rachel Fenichel
122f97c7ed Change order of tests to avoid timing issues 2020-09-24 12:33:41 -07:00
Rachel Fenichel
c5d761dc8a lint 2020-09-21 17:43:35 -07:00
Rachel Fenichel
70f518985a Upgrade webdriverio to v6 2020-09-21 17:42:26 -07:00
Monica Kozbial
876ab33dbf Updated navigation test blocks position so they aren't bumped out of … (#4242)
* Updated navigation test blocks position so they aren't bumped out of bounds during test.

* Added comment
2020-09-17 16:26:58 -07:00
Sam El-Husseini
db40e44b7c Move Blockly.utils.dom.SvgElementType to Blockly.utils.Svg (#4285)
* Move SVGElementType to its own file shaving off 2.7KB
2020-09-16 14:42:58 -07:00
Maribeth Bottorff
6017a953d1 Fix bugs related to events firing during block create (#4278)
Fix bugs related to events firing during block create and add test for expected block init behavior
2020-09-15 20:02:07 -07:00
alschmiedt
38d37d7c7a Updates dev tools script to new version (#4273) 2020-09-11 10:11:43 -07:00
Sam El-Husseini
701eecd5e1 Revert google-closure-deps package to avoid regression, add test to catch this in the future (#4269) 2020-09-10 17:31:01 -07:00
alschmiedt
5bca960628 Fix advanced playground (#4266) 2020-09-10 15:57:53 -07:00
Beka Westberg
47cc3b97b0 Add getTooltip (#4254)
* Add getTooltip

* Add tests

* Fix typings?

* Fix typings?

* PR Comments
2020-09-10 08:57:05 -07:00
alschmiedt
74cf05535c Uncomment skipped navigation tests (#4263) 2020-09-09 16:07:09 -07:00
Monica Kozbial
896c630a89 Shared global cleanup (#4217)
* Refactor block type cleanup into shared cleanup.

* Use shared cleanup for block type cleanup.

* Remove overwriting of core Blockly block in test.

* Rename cleanup arrays for clarity

* Add blocks to cleanup array when defined in shared helpers

* Refactor logic for adding to shared cleanup.

* Add helper for defining block and adding block type to cleanup.

* Fix jsdocs

* Simplifying helpers for adding to cleanup.

* Add missing semicolons

* Update jsdoc for sharedTestSetup

* Use stub to wrap cleanup with defineBlocksWithJsonArray

* Remove unused helper from lint ignore
2020-09-09 15:51:34 -07:00
alschmiedt
29269957c7 Removes test blocks (#4250) 2020-09-08 13:50:45 -07:00
Beka Westberg
c732484180 Add programmatically setting shadows Take 2 (#4215)
* Add programmatically setting shadows
2020-09-08 08:50:01 -07:00
alschmiedt
d01169fa79 Toolbox Rewrite (#4223)
Rewrite the toolbox in order to get rid of old closure code and make it easier to extend.

Co-authored-by: Maribeth Bottorff <maribethb@google.com>
2020-09-02 08:13:07 -07:00
Monica Kozbial
739b8b3adc Viewport change event (#4180)
* Adding viewport ui event emitting and tests

* comment out viewport ui event logic and add TODO for reference
2020-08-31 18:41:20 -07:00
Monica Kozbial
61bdbc5034 Fixing issues with workspace dispose in event tests. (#4211)
* Fixing issues with workspace dispose in event tests.
2020-08-31 16:35:36 -07:00
Monica Kozbial
43b23f6d4a Stub modify in navigation_modify workspace keys test (#4214) 2020-08-31 13:20:54 -07:00
Abby
ed38a45efd Update chrome driver version 2020-08-26 08:10:09 -07:00
Monica Kozbial
6152354348 Check contents of warnings messages in tests. (#4212)
* Check contents of warnings messages in tests.
2020-08-21 14:45:02 -07:00
Monica Kozbial
1b9af5413c Add missing field to block definition in test. (#4209) 2020-08-21 11:06:21 -07:00
Monica Kozbial
886f8b7ad8 Update assert to notExists call (#4206) 2020-08-21 11:04:38 -07:00
Monica Kozbial
ed386faa04 Capture expected warnings logged when modify_ call fails. (#4204) 2020-08-21 11:03:51 -07:00
Monica Kozbial
7dd57adf83 Give Blockly div in tests a height. (#4207) 2020-08-20 19:02:19 -07:00
Monica Kozbial
b87d4497ae Update test asserts on stubs to use sinon asserts (#4205)
* Update asserts for stubs to use sinon asserts.

* Manual update of unclear stub assert.
2020-08-20 19:01:46 -07:00
Monica Kozbial
30e231bb71 Remove unnecessary block dispose that was causing test leakage. (#4210)
* Remove unnecessary block dispose that was causing test leakage.

* Remove unused block array.
2020-08-20 19:00:48 -07:00
Monica Kozbial
a9f1d2e219 Field test deprecated logs (#4198)
* Cleanup of tests.

* Suppress warning logs in field tests.
2020-08-20 13:58:18 -07:00
Monica Kozbial
6e39d2f2e2 Capture expected warning in registry test. (#4201) 2020-08-20 13:57:21 -07:00
Monica Kozbial
f849f8801d Minor stub and assert cleanup (#4185)
* Fix order or assert equal arguments.

* Replace usages of callsFake with returns where appropriate
2020-08-20 11:07:32 -07:00