Ben Henning 141e28d1de fix: Correct ARIA label is for invalid values. (#9469) ...

## The basics

- [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change)

## The details
### Resolves

Fixes #9466

### Proposed Changes

Ensures `FieldInput`'s ARIA labels are recomputed when an invalid value is attempted to be set.

### Reason for Changes

Previously the `FieldInput` would continuously update its ARIA label as the value changed, including for invalid values. If the editor was cancelled this would correctly revert but if an invalid value was attempted to be saved then it would cancel the update but not correct the ARIA label.

### Test Coverage

No new tests are needed for this experimental change. This has been manually verified locally using `FieldNumber` in Core's advanced playground.

### Documentation

No documentation changes are needed for this experimental change.

### Additional Information

None.

2025-11-19 14:31:04 -08:00

..

bubbles

Merge pull request #9446 from BenHenning/fix-miscellaneous-screen-reader-issues

2025-11-12 18:09:30 -08:00

clipboard

fix: Fix positioning of pasted blocks and comments in RTL. (#9302)

2025-08-19 08:32:31 -07:00

comments

fix: improve screenreader output for workspace comments (#9351)

2025-09-18 14:27:41 -07:00

dragging

feat: Add initial support for screen readers (experimental) (#9280)

2025-08-06 15:28:45 -07:00

events

fix!: remove deprecated setEnabled and backwards event filtering (#9039)

2025-05-13 14:30:28 -07:00

icons

fix: Use button as the aria-role for icons. (#9408)

2025-10-07 14:34:25 -07:00

inputs

fix: Miscellaneous improvements for screenreader support. (#9424)

2025-10-16 14:17:00 -07:00

interfaces

fix: Fix bug that caused inadvertent scrolling when the WidgetDiv was shown. (#9291)

2025-08-21 11:15:07 -07:00

keyboard_nav

Merge branch 'develop' into merge-develop-into-experimental-branch

2025-11-04 18:47:23 +00:00

renderers

fix: Avoid creating redundant a11y tree nodes when selecting a block. (#9363)

2025-09-15 11:40:07 -07:00

serialization

feat: Add a generator for all fields on a block. (#8667)

2025-01-06 11:30:22 -08:00

theme

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

toolbox

feat: Remove most block tree support. (#9412)

2025-10-13 12:37:21 -07:00

utils

fix: make the aria live region assertive (#9436)

2025-11-04 13:44:34 -08:00

any_aliases.ts

chore: Add required @license tag to any_aliases.ts (#6899)

2023-03-16 17:15:51 +01:00

block_animations.ts

Fix: #8194 by using a stepped animation for the wiggle (#8743)

2025-02-12 13:16:35 -08:00

block_flyout_inflater.ts

refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. (#8992)

2025-05-07 08:47:52 -07:00

block_svg.ts

Merge pull request #9446 from BenHenning/fix-miscellaneous-screen-reader-issues

2025-11-12 18:09:30 -08:00

block.ts

chore: Fix documentation generation warnings. (#9325)

2025-08-19 14:56:59 -07:00

blockly_options.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

blockly.ts

feat: add keyboard navigation controller (#8924)

2025-05-29 13:48:54 -07:00

blocks.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

browser_events.ts

chore(deps): bump @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1 (#8479)

2024-08-14 09:10:34 -07:00

bubbles.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

bump_objects.ts

refactor(events): Introduce and use event type predicates (#8538)

2024-08-20 19:50:29 +01:00

button_flyout_inflater.ts

refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. (#8992)

2025-05-07 08:47:52 -07:00

clipboard.ts

feat: add copy api and paste into correct workspace (#9215)

2025-07-08 16:05:53 -07:00

comments.ts

feat: Add support for keyboard navigation in/to workspace comments. (#9182)

2025-07-01 15:13:13 -07:00

common.ts

fix: Dispatch keyboard events with the workspace they occurred on. (#9137)

2025-06-16 15:45:01 -07:00

component_manager.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

config.ts

fix: remove parameter from wouldDelete (#7968)

2024-03-28 15:39:48 -07:00

connection_checker.ts

chore: Use .includes and .startsWith, not .indexOf (#7936)

2024-03-15 00:03:55 +01:00

connection_db.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

connection_type.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

connection.ts

fix: Ensure focus changes when tabbing fields (#9173)

2025-07-02 16:07:05 -07:00

constants.ts

feat!: Invalid Blocks (#7958)

2024-04-17 19:47:51 -07:00

contextmenu_items.ts

refactor: Remove duplicated method from contextmenu_items.ts. (#9289)

2025-08-12 08:55:54 -07:00

contextmenu_registry.ts

chore: remove now-unneeded cast (#9016)

2025-05-09 16:20:36 -07:00

contextmenu.ts

feat!: Make everything ISelectable focusable (#9004)

2025-05-09 08:16:14 -07:00

css.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

delete_area.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

dialog.ts

feat: Make fields focusable (#8923)

2025-04-30 15:54:21 -07:00

drag_target.ts

fix!: various drag-adjacent interfaces (#7975)

2024-03-29 21:00:56 +00:00

dragging.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

dropdowndiv.ts

fix: Revert drop down and widget div PRs (#9222)

2025-07-09 12:13:33 -07:00

extensions.ts

feat!: Added support for separators in menus. (#8767)

2025-02-27 14:00:40 -08:00

field_checkbox.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

field_dropdown.ts

fix: Miscellaneous improvements for screenreader support. (#9424)

2025-10-16 14:17:00 -07:00

field_image.ts

Merge pull request #9446 from BenHenning/fix-miscellaneous-screen-reader-issues

2025-11-12 18:09:30 -08:00

field_input.ts

fix: Correct ARIA label is for invalid values. (#9469)

2025-11-19 14:31:04 -08:00

field_label_serializable.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

field_label.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

field_number.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

field_registry.ts

fix: Allow reregistering fields. (#9290)

2025-08-22 14:55:07 -07:00

field_textinput.ts

refactor: Remove INavigable in favor of IFocusableNode. (#9037)

2025-05-13 15:04:49 -07:00

field_variable.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

field.ts

Merge pull request #9446 from BenHenning/fix-miscellaneous-screen-reader-issues

2025-11-12 18:09:30 -08:00

flyout_base.ts

fix: Toolbox & Flyout ARIA positions (experimental) (#9394)

2025-10-01 15:52:07 -07:00

flyout_button.ts

Merge branch 'develop' into merge-develop-into-experimental-branch

2025-11-04 18:47:23 +00:00

flyout_horizontal.ts

fix: Fix bug that prevented keyboard navigation in flyouts. (#8687)

2025-01-09 14:31:51 -08:00

flyout_item.ts

refactor: Remove INavigable in favor of IFocusableNode. (#9037)

2025-05-13 15:04:49 -07:00

flyout_metrics_manager.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

flyout_navigator.ts

refactor: Remove INavigable in favor of IFocusableNode. (#9037)

2025-05-13 15:04:49 -07:00

flyout_separator.ts

refactor: Remove INavigable in favor of IFocusableNode. (#9037)

2025-05-13 15:04:49 -07:00

flyout_vertical.ts

fix: Fix bug that prevented keyboard navigation in flyouts. (#8687)

2025-01-09 14:31:51 -08:00

focus_manager.ts

fix: Fix bug that caused inadvertent scrolling when the WidgetDiv was shown. (#9291)

2025-08-21 11:15:07 -07:00

generator.ts

release: Merge branch 'rc/v11.2.0' into rc/v12.0.0

2024-12-04 12:06:12 -08:00

gesture.ts

fix: handle pointercancel only for drags (#9373)

2025-09-19 13:53:57 -07:00

grid.ts

release: Merge branch 'rc/v11.2.0' into rc/v12.0.0

2024-12-04 12:06:12 -08:00

icons.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

inject.ts

fix: make the aria live region assertive (#9436)

2025-11-04 13:44:34 -08:00

inputs.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

insertion_marker_previewer.ts

refactor: Make InsertionMarkerPreviewer's block serialization amenable to subclassing. (#9282)

2025-08-06 12:45:17 -07:00

internal_constants.ts

chore: delete useless DRAG_STACK value (#7994)

2024-04-04 15:58:24 -07:00

keyboard_navigation_controller.ts

feat: add keyboard navigation controller (#8924)

2025-05-29 13:48:54 -07:00

label_flyout_inflater.ts

refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. (#8992)

2025-05-07 08:47:52 -07:00

layer_manager.ts

fix: Fix bug that caused the focus manager to attempt to focus unfocusable elements. (#9117)

2025-05-30 13:09:52 -07:00

layers.ts

fix: export the layer constants. (#8256)

2024-07-09 15:25:20 -07:00

main.ts

chore!: delete deprecations for v11. (#7732)

2024-01-23 08:48:08 -08:00

marker_manager.ts

refactor: Ensure that the workspace cursor is never null. (#9210)

2025-07-07 13:55:40 -07:00

menu_separator.ts

feat!: Added support for separators in menus. (#8767)

2025-02-27 14:00:40 -08:00

menu.ts

feat: Fix ARIA roles and setup for fields (experimental) (#9384)

2025-10-01 16:19:06 -07:00

menuitem.ts

fix: Miscellaneous improvements for screenreader support. (#9424)

2025-10-16 14:17:00 -07:00

metrics_manager.ts

chore!: Fix warnings when generating docs. (#8660)

2025-01-06 10:53:45 -08:00

msg.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

names.ts

chore: Post-merge fixits.

2024-12-04 12:15:19 -08:00

navigator.ts

feat: Add support for keyboard navigation to/from block comments. (#9227)

2025-07-11 10:54:19 -07:00

observable_procedure_map.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

options.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

positionable_helpers.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

procedures.ts

refactor!: Use JSON instead of XML for defining dynamic toolbox categories. (#8658)

2025-01-08 11:50:18 -08:00

registry.ts

fix: Allow overriding VariableModel via options.plugins. (#9257)

2025-07-30 08:58:30 -07:00

render_management.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

rendered_connection.ts

fix: Improve narration and navigation of C-shaped blocks. (#9416)

2025-10-13 12:18:38 -07:00

scrollbar_pair.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

scrollbar.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

separator_flyout_inflater.ts

refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. (#8992)

2025-05-07 08:47:52 -07:00

serialization.ts

chore: Organise imports (#8527)

2024-08-15 03:16:14 +01:00

shortcut_items.ts

feat: add copy api and paste into correct workspace (#9215)

2025-07-08 16:05:53 -07:00

shortcut_registry.ts

fix: Copy shortcuts before returning them (#9109)

2025-05-29 09:59:45 -07:00

sprites.ts

chore: remove alias comments (#6816)

2023-02-06 10:08:55 -08:00

theme_manager.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

theme.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

toast.ts

feat: Add support for displaying toast-style notifications. (#8896)

2025-04-21 15:32:45 -07:00

tooltip.ts

chore(deps): bump @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1 (#8479)

2024-08-14 09:10:34 -07:00

touch.ts

fix: handle pointercancel only for drags (#9373)

2025-09-19 13:53:57 -07:00

trashcan.ts

chore: Merge branch 'develop' into rc/v12.0.0

2025-05-03 02:00:27 +01:00

utils.ts

refactor(build): Delete Closure Library (#7415)

2023-08-31 00:24:47 +01:00

variable_map.ts

fix: Fix bug that could caused variable map to be left in an inconsistent state. (#9339)

2025-09-02 12:39:16 -07:00

variable_model.ts

chore: Post-merge fixits.

2024-12-04 12:15:19 -08:00

variables_dynamic.ts

refactor!: Finish refactor of WorkspaceSvg VariableMap methods (#8946)

2025-05-02 17:47:11 +01:00

variables.ts

refactor!: Finish refactor of WorkspaceSvg VariableMap methods (#8946)

2025-05-02 17:47:11 +01:00

widgetdiv.ts

fix: Revert drop down and widget div PRs (#9222)

2025-07-09 12:13:33 -07:00

workspace_audio.ts

chore: Remove underscores from private fields. (#8682)

2024-12-02 11:33:05 -08:00

workspace_dragger.ts

feat!: Make everything ISelectable focusable (#9004)

2025-05-09 08:16:14 -07:00

workspace_svg.ts

feat: Remove most block tree support. (#9412)

2025-10-13 12:37:21 -07:00

workspace.ts

fix: Refer to correct replacement method in deprecation warning. (#9237)

2025-07-15 11:06:27 -07:00

xml.ts

fix: Fix positioning of pasted blocks and comments in RTL. (#9302)

2025-08-19 08:32:31 -07:00

zoom_controls.ts

refactor(events): introduce EventType enum in separate module (#8530)

2024-08-20 08:36:33 +01:00