17062 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Elvis Pfutzenreuter	ecbbc512b2	esp32/network_lan: Add PHY_GENERIC device type. ... Support the new PHY_GENERIC device type, added in ESP-IDF v5.4.0 [1]. This PHY driver was added to ESP-IDF to support "generic"/oddball PHY LAN chips like the JL1101, which offer no features beyond the bare 802.3 PHY standard and don't actually need a chip-specific driver (see discussion at [2]). [1] 0738314308 [2] https://github.com/espressif/esp-eth-drivers/pull/28 Signed-off-by: Elvis Pfutzenreuter <epxx@epxx.co>	2025-05-16 15:34:20 -03:00
Rick Sorensen	90aeac800a	esp32/machine_i2c: Fix default I2C pins for C3, S3. ... The default I2C init does not require setting SCL or SDA but the default I2C0 pins for C3, S3 conflict with the espressif GPIO usage. For the C3, pins 18/19 are for USB/JTAG. If used for I2C() they will cause the REPL to hang on initialization of the I2C. For the S3 pin 19 is allocated for USB/JTAG also but the defaults do not seem to affect the REPL. See related #16956. Fixes issue #17103. Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com> Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-16 17:39:10 +10:00
Daniël van de Giessen	06d8c084b9	esp32/modesp32: Implement esp32.idf_task_info(). ... This adds a new function, `esp32.idf_task_info()`, that can be used to retrieve task statistics which is useful for diagnosing issues where some tasks are using up a lot of CPU time. It's best used in conjunction with the `utop` module from micropython-lib. Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>	2025-05-16 16:49:59 +10:00
Angus Gratton	10f6c0699e	esp32/network_lan: Add support for LAN8670 PHY. ... This adds support for LAN8670 to the esp32 port. Enabled conditionally for the esp32 target, if ESP-IDF version is new enough (v5.3 or newer). Fixes issue #15731. Signed-off-by: Damien George <damien@micropython.org> Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-16 15:16:06 +10:00
IhorNehrutsa	f48b981567	esp32: Update to use ESP-IDF v5.4.1. ... This version of the IDF uses about 1KB more IRAM and 1KB more DRAM on most boards, but 6.5KB more DRAM usage on the S3. It seems that's due to a lot of small increases in many components. Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>	2025-05-16 14:02:39 +10:00
Damien George	e1ab04e820	esp32/mpthreadport: Fix double delete of tasks on soft reset. ... Python threads (created via the `_thread` module) are backed by a FreeRTOS task. Managing the deletion of the task can be tricky, and there are currently some bugs with this in the esp32 port. The actual crash seen was in FreeRTOS' `uxListRemove()`, and that's because of two calls to `vTaskDelete()` for the same task: one in `freertos_entry()` when the task ran to completion, and the other in `mp_thread_deinit()`. The latter tried to delete the task a second time because it was still in the linked list, because `vTaskPreDeletionHook()` had not yet been called. And the reason `vTaskPreDeletionHook()` was yet to be called is because the FreeRTOS idle task was starved. This commit fixes that. There are three things done by this commit: - remove the `vTaskPreDeletionHook`, it's not needed anymore because task stack memory is allocated by the IDF, not on the MicroPython heap - when a task finishes it now removes itself from the linked list, just before it deletes itself - on soft reset, all tasks are deleted and removed from the linked list in one swoop (while the mutex is held) Signed-off-by: Damien George <damien@micropython.org>	2025-05-16 13:31:34 +10:00
IhorNehrutsa	9d565182d7	docs/esp32/quickref: Add PWM lightsleep example. ... Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>	2025-05-16 12:37:25 +10:00
IhorNehrutsa	a724545193	esp32/mpconfigport: Document how to get more debug info. ... Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>	2025-05-16 12:37:14 +10:00
IhorNehrutsa	150a5aa3a1	esp32/machine_pwm: Improve PWM and make its API match other ports. ... This reduce inconsistencies between esp32 PWM and other ports: 1. duty_u16() high value is 2**16-1 == 65535 2. Invert PWM wave with invert=1 parameter 3. Enable PWM in light sleep mode 4. Allow PWM output and read pulse input simultaneously on the same Pin() 5. Code refactoring Co-Authored-By: Angus Gratton <angus@redyak.com.au> Co-Authored-By: robert-hh <robert@hammelrath.com> Co-Authored-By: Andrew Leech <andrew.leech@planetinnovation.com.au> Co-Authored-By: Yoann Darche <yoannd@hotmail.com> Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>	2025-05-16 12:35:58 +10:00
IhorNehrutsa	c310301f27	docs/esp32: Improve PWM documentation and examples. ... This reduces inconsitencies between esp32 and other ports. According to the discussion in #10817. Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>	2025-05-16 12:34:32 +10:00
Jeff Epler	6d74b4e3c1	tools/gen-cpydiff.py: Ensure every item has at least 2 TOC levels. ... Previously, the navigation ended up messy when the (long) description of the item became used as a 2nd level header, meaning that it was placed in the navigation. Check for this when generating cpydiff so that new cases don't sneak in unnoticed. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:52:03 +10:00
Jeff Epler	ea19f3b735	tests/cpydiff: Ensure all have two levels of category. ... This improves the TOC display of the generated differences section. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:52:03 +10:00
Jeff Epler	a19d3f742e	tools/gen-cpydiff.py: Fix RST heading generation. ... The heading character for the difference title was always "~", but items had been added which had just a single heading level. This made the generated table of contents confused about heading levels, because heading levels are not fixed in rst, but are inferred from the order they appear in the document. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:52:03 +10:00
Jeff Epler	8648e6d1cf	tests/cpydiff: Add test of underscore-in-literals. ... Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:52:03 +10:00
Jeff Epler	605eda158d	tools/gen-cpydiff.py: Improve stdout vs stderr interleaving. ... In the syntax_space cpydiff, all the warnings were shown after the other output. This is because the output always showed all of stdout first and all of stdout second. By running Python in unbuffered mode and using `stderr=STDOUT`, the two streams are interleaved in exactly the order they're printed, so the SyntaxWarnings are interleaved with the other output. By using the `encoding=` argument of Popen, the need to explicitly convert to utf-8 is avoided. The encoding of the input also becomes utf-8 in this case, which all the test cases are (well, they're all ASCII, I think). As in `run-tests.py`, setting PYTHONIOENCODING ensures the Python interpreter's input and output are in utf-8, which is not always the case, especially on Windows systems. I spot-checked the generated doc pages and they all seemed to make sense still. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:52:03 +10:00
Jeff Epler	2f97d1dd28	tests/cpydiff: Document that uPy requires space after number+period. ... Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:51:43 +10:00
Jeff Epler	e22c666d06	tests/cpydiff: Explain the numeric literal parsing difference. ... Fixes issue #17224. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-16 11:45:18 +10:00
Damien George	44bcfe53de	tests/extmod/vfs_lfs_error.py: Test value of all OSError's errno. ... To make sure they have the correct value. Signed-off-by: Damien George <damien@micropython.org>	2025-05-15 13:09:49 +10:00
Damien George	62d26bfc15	extmod/vfs_lfsx: Fix errno value raised from chdir. ... OSError errno values should be positive. Signed-off-by: Damien George <damien@micropython.org>	2025-05-15 13:09:49 +10:00
Daniël van de Giessen	4208970451	tools/verifygitlog.py: Allow long co-author and sign-off names. ... Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>	2025-05-15 13:03:11 +10:00
Damien George	51b821ce82	tools/verifygitlog.py: Disallow a leading slash in commit subject line. ... Signed-off-by: Damien George <damien@micropython.org>	2025-05-15 13:01:41 +10:00
Daniël van de Giessen	3b1e22c669	esp32/network_ppp: Restructure to match extmod/network_ppp_lwip. ... The ESP32 PPP implementation predates the generic implementation in extmod. The new extmod implementation has a few advantages such as a better deinitialisation procedure (the ESP32 implemementation would not clean up properly and cause crashes if recreated) and using the UART IRQ functionality instead of running a task to read data from the UART. This change restructures the ESP implementation to be much closer to the new extmod version, while also bringing a few tiny improvements from the ESP32 version to the extmod version. The diff between extmod/network_ppp_lwip.c and ports/esp32/network_ppp.c is now a small set of easy to review ESP32 port-specific changes. Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>	2025-05-15 11:56:14 +10:00
Alessandro Gatti	2406582479	esp32/network_common: Raise a memory error on ESP_ERR_NO_MEM. ... This commit changes the error handler for WiFi operations to recognise out of memory conditions reported by ESP-IDF functions, and report them as more descriptive exceptions rather than a generic "error 0x101". The error handler only provided a human-readable error description for WiFi-specific error codes (codes in the ESP_ERR_WIFI_BASE range), but WiFi functions are known to return other codes. Now ESP_ERR_NO_MEM is covered with a specific error message, making it easier to debug issues related to running out of ESP-IDF heap. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2025-05-15 11:29:41 +10:00
Daniël van de Giessen	155fa94fbf	esp32/machine_uart: Correctly manage UART queue and event task. ... If the driver was reinitialised while there was already an event task running the queue that task is trying to receive from would be deleted, causing it to try to take a lock that no longer existed and deadlocking the CPU. This change ensures the task is always shut down before recreating the queue and recreates the task afterwards. It also allows setting an IRQ handler before the UART is initialized (like other ports allow), removes the task when the UART is deinitialized (which was previously missing), adds a check that no event task can be started when no queue exists, and adds a check to prevent reinitialising the UART driver unnecessarily. Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>	2025-05-14 15:55:31 +02:00
Alessandro Gatti	883dc41d46	esp32/main: Make the entry point function name configurable. ... This commit introduces a new port configuration entry allowing the entry point function name to be changed, from "app_main" to a custom name. This is needed when MicroPython is embedded as an ESP-IDF component, since the "app_main" symbol is already provided elsewhere, making compilation not possible. Marking MicroPython's symbol as weak would make it compile and make it possible to create and start the MicroPython task anyway with the right FreeRTOS task creation incantation, but it is probably easier to just rename the initialisation function into something else that can be accessed from outside. When MicroPython is embedded as an ESP-IDF component, the MICROPY_ESP_IDF_ENTRY definition can be set to indicate the new entry point function name. The new function name prototype should still be defined in external code to let linking succeed. Also, the NLR failure callback is marked as weak to give the chance of handling such error in a more controlled fashion rather than trigger an unconditional board restart. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2025-05-14 06:26:31 +02:00
Alessandro Gatti	116d0d4945	esp32/esp32_common.cmake: Allow adding defines and compiler flags. ... This commit introduces two extra CMake variables, MICROPY_DEF_COMPONENT and MICROPY_COMPILE_COMPONENT, that make it easier to integrate MicroPython as a custom ESP-IDF component. Whilst there is no official MicroPython component available for ESP-IDF, integration can be achieved with some minor CMake scripting outside the MicroPython tree - except for customisation of compilation defines and build flags, which is what this commit tries to provide. Compilation defines customisation is especially important for MicroPython configuration, as it is not possible to inject a value for MP_CONFIGFILE otherwise. This means that unless MicroPython itself is forked first to edit ports/esp32/mpconfigport.h, it is not possible to perform any meaningful configuration of the interpreter/runtime when included as a component. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2025-05-14 06:25:59 +02:00
robert-hh	1d4bf8ac40	esp32/machine_timer: Fix timer.value() for an uninitialized timer. ... Raises a value error in that case, which happens after a timer was created but not initialized, or after calling `timer.deinit()`. Fixes issue #17033. Signed-off-by: robert-hh <robert@hammelrath.com>	2025-05-14 11:58:36 +10:00
Alessandro Gatti	d7371124d2	esp32/esp32_common.cmake: Use the tinyusb source files from ESP-IDF. ... This commit removes the explicit dependency on the vendored tinyusb version for the ESP32S2 and ESP32S3 boards. Tinyusb is still available to MicroPython through a dependency on the `espressif/esp_tinyusb` ESP-IDF component, which in turn depends on the `espressif/tinyusb` component itself. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2025-05-14 11:02:31 +10:00
Jeff Epler	f77fd6257c	tests/cpydiff: Document format separator difference. ... Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-13 12:19:46 +10:00
Jeff Epler	9032491efd	py/objstr: Add support for the :_b/o/x specifier in str.format. ... This groups non-decimal values by fours, such as bbb_bbbb_bbbb. It also supports `{:_d}` to use underscore for decimal numbers (grouped in threes). Use of incorrect ":,b" is not diagnosed. Thanks to @dpgeorge for the suggestion to reduce code size. Signed-off-by: Jeff Epler <jepler@gmail.com>	2025-05-13 12:16:35 +10:00
Alessandro Gatti	f47e214cdc	all: Rename the "NORETURN" macro to "MP_NORETURN". ... This commit renames the NORETURN macro, indicating to the compiler that a function does not return, into MP_NORETURN to maintain the same naming convention of other similar macros. To maintain compaitiblity with existing code NORETURN is aliased to MP_NORETURN, but it is also deprecated for MicroPython v2. This changeset was created using a similar process to decf8e6a8b ("all: Remove the "STATIC" macro and just use "static" instead."), with no documentation or python scripts to change to reflect the new macro name. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2025-05-13 10:36:47 +10:00
Angus Gratton	69993daa5c	rp2/modmachine: Add mutual exclusion for machine.lightsleep(). ... There's no specified behaviour for what should happen if both CPUs call `lightsleep()` together, but the latest changes could cause a permanent hang due to a race in the timer cleanup code. Add a flag to prevent hangs if two threads accidentally lightsleep, at least. This allows the new lightsleep test to pass on RPI_PICO and RPI_PICO2, and even have much tighter time deltas. However, the test still fails on wireless boards where the lwIP tick wakes them up too frequently. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-12 16:30:46 +10:00
Angus Gratton	977fd94856	tests/ports/rp2: Add a test case for light sleeping from CPU1. ... Not currently passing. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-12 16:30:38 +10:00
Peter Harper	03da15575f	tests/ports/rp2: Update machine idle test to revert skip for RP2350. ... This reverts commit b42bb911c6. Signed-off-by: Peter Harper <peter.harper@raspberrypi.com>	2025-05-12 16:29:51 +10:00
Peter Harper	2a4f1c9f0f	rp2/modmachine: Add debug code for mp_machine_lightsleep. ... Add some debug code that can be enabled to determine why lightsleep is returning early. Signed-off-by: Peter Harper <peter.harper@raspberrypi.com>	2025-05-12 16:29:37 +10:00
Peter Harper	ee2c78cd97	rp2: Use pico-sdk alarm pool instead of soft timer for sleep. ... Stop using soft timer for `mp_wfe_or_timeout`. Now uses the alarm pool again as issues with this code have been fixed. This resolves the "sev" issue that stops the RP2350 going idle. Also, change the lightsleep code to use the hardware timer library and alarm 1, as alarm 2 is used by and soft timers and alarm 3 is used by the alarm pool. Signed-off-by: Peter Harper <peter.harper@raspberrypi.com>	2025-05-12 16:24:51 +10:00
Damien George	a05766f47b	tests/multi_net: Add test that requires queuing UDP packets. ... This commit adds a new network multi-test which sends a burst of UDP packets from the client, and the server doesn't recv them until they have all been sent. Signed-off-by: Damien George <damien@micropython.org>	2025-05-12 14:19:34 +10:00
Damien George	26e978e7bc	extmod/modlwip: Implement a queue of incoming UDP/raw packets. ... The bare-metal lwIP socket interface is currently quite limited when used for UDP streams, because it only allows one outstanding incoming UDP packet. If one UDP packet is waiting to be socket.recv'd and another one comes along, then the second one is simply dropped. This commit implements a queue for incoming UDP and raw packets. The queue depth is fixed at compile time, and is currently 4. This allows better use of UDP connections, eg more efficient. It also makes DTLS work better which sometimes has a queue of UDP packets (eg during the connection phase). Signed-off-by: Damien George <damien@micropython.org>	2025-05-12 14:17:44 +10:00
Damien George	61eedbbd11	tools/verifygitlog.py: Apply stricter rules on git subject line. ... There is a bit of ambiguity as to how the prefix of the git subject line should look like. Eg `py/vm: ...` vs `py/vm.c: ...` (whether the extension should be there or not). This commit makes the existing CI check of the git commit message stricter, by applying extra rules to the prefix, the bit before the : in the subject line. It now checks that the subject prefix: - doesn't start with unwanted bits: ., /, ports/ - doesn't have an extension: .c, .h, .cpp, .js, .rst or .md Full error messages are given when a rule does not pass. This helps to reduce maintainer burden by applying stricter rules, to keep the git commit history consistent. Signed-off-by: Damien George <damien@micropython.org>	2025-05-12 13:47:03 +10:00
Damien George	487c94c253	tests/extmod/vfs_rom.py: Clear sys.path before running test. ... Otherwise if the target has certain files/directories (such as "test") in its filesystem then these interfere with the unit tests. Signed-off-by: Damien George <damien@micropython.org>	2025-05-12 13:33:42 +10:00
Damien George	f7c53cd221	tests/net_inet: Update micropython.org certificate for SSL tests. ... The Let's Encrypt root certificate has changed so needs updating in these tests. Also use `bytes.fromhex()` instead of `binascii.unhexlify()`, to eliminate the need for the `binascii` module. Both of these features are controlled by `MICROPY_PY_BUILTINS_BYTES_HEX`, so the test will still work on the same targets that it previously did. Signed-off-by: Damien George <damien@micropython.org>	2025-05-12 13:32:06 +10:00
Angus Gratton	ae6062a45a	lib/littlefs: Fix string initializer in lfs1.c. ... Avoids the new Wunterminated-string-literal when compiled with gcc 15.1. It would be preferable to just disable this warning, but Clang -Wunknown-warning-option kicks in even when disabling warnings so this becomes fiddly to apply. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-09 18:31:40 +10:00
Angus Gratton	9f86005885	py/emitinlinethumb: Refactor string literal as array initializer. ... Avoids the new Wunterminated-string-literal when compiled with gcc 15.1. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-09 18:31:40 +10:00
Angus Gratton	7d5aba0523	extmod/moductypes: Refactor string literal as array initializer. ... Avoids the new Wunterminated-string-literal when compiled with gcc 15.1. Also split out the duplicate string to a top-level array (probably the duplicate string literal was interned, so unlikely to have any impact.) This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-09 18:31:40 +10:00
Angus Gratton	3fa77bdc7d	rp2: Add temporary workaround for GCC 15.1 build failure. ... This is a workaround for this upstream issue: https://github.com/raspberrypi/pico-sdk/issues/2448 Can be removed after the next pico-sdk update. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-09 18:31:25 +10:00
Damien George	d01a981a9b	py/mpconfig: Enable io.IOBase at core feature level. ... IOBase is quite an important building block of other parts of the system, such as `mpremote mount` and running .mpy and native tests. This feature costs +244 bytes of firmware size on ARM Thumb2 architectures, which is worth the cost for the extra features it enables. The change here means that `io.IOBase` is now enabled on all nrf boards, (previously it was only nRF52840 and nRF9160) and also B_L072Z_LRWAN1 (there is no change to other ports or boards). Signed-off-by: Damien George <damien@micropython.org>	2025-05-09 12:43:27 +10:00
Damien George	9c8c219f8a	rp2/rp2_dma: Fix default value used in pack_ctrl on RP2350. ... The bit position of CHAIN_TO is not the same as on RP2040. Signed-off-by: Damien George <damien@micropython.org>	2025-05-09 12:05:04 +10:00
Damien George	928466d74c	rp2/Makefile: Add deploy target that uses picotool load. ... This is a convenient way to deploy firmware to an RP2xxx-based board. Signed-off-by: Damien George <damien@micropython.org>	2025-05-09 12:01:50 +10:00
Angus Gratton	d00eab4a30	rp2,extmod/cyw43: Move the LWIP responder fix into common CYW43 config. ... This means the fix from dd1465e7 will also apply to stm32 and mimxrt ports that use CYW43. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-08 15:32:05 +10:00
Angus Gratton	b2cda6c604	extmod,alif,mimxrt,rp2,stm32: Create common cyw43 driver config header. ... This is only a surface level refactor, some deeper refactoring would be possible with (for example) the SDIO interface in mimxrt and stm32, or the BTHCI interface which is is similar on supported ports. But sticking to cases where the macros are the same across all ports. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2025-05-08 15:32:05 +10:00