Commit Graph

261 Commits

Author SHA1 Message Date
Rachel Fenichel
6f520335ea Cleanup of colouring code, and move it into path_object. 2019-10-30 14:42:13 -07:00
Rachel Fenichel
85c4db5a10 First pass at colourers 2019-10-30 14:42:13 -07:00
Sam El-Husseini
942068314f Accept lowercase alignment (#3359)
* Accept lowercase alignment
2019-10-29 11:45:30 -07:00
Sam El-Husseini
e7752e6ea2 Dummy input right alignment (#3342)
* Fix dummy input alignment in geras.
2019-10-28 16:20:54 -07:00
Sam El-Husseini
100da4a66c Revert "Wrap dummy inputs in a measurable so that it can be aligned appropriately. (#3337)"
This reverts commit 7fc733b81f.
2019-10-24 21:53:30 -07:00
Sam El-Husseini
7fc733b81f Wrap dummy inputs in a measurable so that it can be aligned appropriately. (#3337) 2019-10-24 21:42:44 -04:00
Sam El-Husseini
06b5bb1945 Might right corner support to common. Making it so there's always a right corner element, square by default. (#3311) 2019-10-23 21:58:43 -04:00
Sam El-Husseini
3d6eb48937 Render a notch after a statement input in zelos (#3326) 2019-10-23 21:58:18 -04:00
Rachel Fenichel
3c64deceec Merge pull request #3297 from rachel-fenichel/bugfix/3228
Fix #3228 by only using the dark path offset in Geras.
2019-10-23 11:17:09 -07:00
Rachel Fenichel
d11b7228c2 Fix #3228 by only using the dark path offset in Geras. 2019-10-23 11:06:12 -07:00
Sam El-Husseini
ad2c5f69ce Fix for #3313 (#3316)
* Account for output connection with when aligning statement row
2019-10-23 13:07:04 -04:00
Rachel Fenichel
d48859e338 Fix #3191 2019-10-21 15:35:53 -07:00
Sam El-Husseini
42552b5b22 Fix 6 warnings related to rendering. (#3292) 2019-10-21 17:49:38 -04:00
Sam El-Husseini
36524a3b4a Only add a hat if there's no output connection or previous connection (#3280)
* Only add a hat if there's no output connection or previous connection
2019-10-17 14:08:06 -05:00
Neil Fraser
01b6992efd Normalize to one spelling of color/colour. 2019-10-16 09:46:47 -07:00
alschmiedt
a9420154a2 Update todos so they are no longer in jsdocs (#3250) (#3257) 2019-10-15 10:14:39 -07:00
Rachel Fenichel
9ce41598c0 Clean up todos. 2019-10-07 13:25:47 -07:00
Sam El-Husseini
d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
99ce193b1f Base renderer next / prev connection fixes. (#3135) 2019-10-02 12:35:00 -07:00
Rachel Fenichel
ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Rachel Fenichel
0e1a4b68e1 Remove blockRendering.Debug, thrasos, and zelos from default requires.js 2019-09-27 12:01:06 -07:00
Neil Fraser
872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Monica Kozbial
22e79ae496 Updating behavior of register functions and adding unregister. (#3085)
* Updating behavior of register functions and adding unregister.

* Updates jsdoc comments.
2019-09-26 13:23:45 -07:00
Monica Kozbial
303a841685 Adding check for pushing last row with only empty dummy input. (#3081) 2019-09-24 13:41:26 -07:00
Monica Kozbial
21c5698e98 Moving DARK_PATH_OFFSET to geras only. (#3066)
* Moving DARK_PATH_OFFSET to geras.

* Adding compressed and uncompressed files.

* Adding missing newlines

* Reverting commit of messages.

* Reverting compressed files.

* Updating compressed files.

* Addressing PR comments.

* Removing unecessary input overrides.
2019-09-23 15:57:59 -07:00
Monica Kozbial
a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Monica Kozbial
a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Sam El-Husseini
57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
kozbial
60e6b8c6df style and doc updates. 2019-09-19 10:38:23 -07:00
kozbial
3d06e7eb33 Creating cursordrawer in renderer. 2019-09-19 10:38:23 -07:00
Monica Kozbial
e551db41e0 Merge pull request #3017 from moniika/moniika-debug-render-checkmarks
Adding checkboxes for debug rendering options to playground.
2019-09-16 17:18:32 -07:00
Rachel Fenichel
77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
kozbial
53cb811f78 Addressing PR comments. 2019-09-16 11:42:28 -07:00
kozbial
02e5b77a20 Adding checkboxes for debug rendering options to playground. 2019-09-16 11:42:28 -07:00
Sam El-Husseini
e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini
fc420b7037 Support for registering renderers and switching between them (#3013)
* Added support for registering renderers and for choosing which renderer the workspace wants to use.
2019-09-13 10:30:20 -07:00
Neil Fraser
23caa12571 Error is a constructor, ‘new’ is not required. 2019-09-12 18:02:59 -07:00
kozbial
8a00ed9eb2 Remove duplicate check and undo changes in debugger render. 2019-09-12 13:36:45 -07:00
kozbial
90a10e5f44 Fix logic in shouldStartNewRow_ and between row padding in geras. 2019-09-12 11:34:08 -07:00
Rachel Fenichel
4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Sam El-Husseini
4c8e28c53d Dynamic output shapes (#2980)
* Round and triangle dynamic output shapes.
2019-09-06 13:04:01 -07:00
Rachel Fenichel
e96acf476c Add dark path offset in geras info. 2019-09-05 16:55:56 -07:00
Rachel Fenichel
e48c60fee6 Use strings instead of arrays for highlight paths 2019-09-05 15:48:46 -07:00
Rachel Fenichel
da6d28b818 More cleanup 2019-09-05 11:16:27 -07:00
Rachel Fenichel
87e7be9619 Cleanup 2019-09-04 17:19:31 -07:00
Rachel Fenichel
581705cc7b Create a Renderer base class and extend it for each type of renderer 2019-09-04 17:16:08 -07:00
Rachel Fenichel
135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini
73d0b70c22 Add a spacer before and after a statement input and place use it to render a right corner before and after the statement input. (#2967) 2019-09-04 15:38:23 -07:00
Rachel Fenichel
5dc45be726 Reset default renderer to geras. (#2960) 2019-09-03 15:55:52 -07:00