Commit Graph

114 Commits

Author SHA1 Message Date
Monica Kozbial fdb1d71e88 Editable field spacing (#3635)
* Substituting checks for isEditable.

* Add isField checks.

* Add parentheses for casting.

* Update value of isEditable and use for spacing.

* Changing to double equals.
2020-01-23 13:10:33 -08:00
Monica Kozbial 1afff3c439 Use baseline for positioning rendered connection. (#3609) 2020-01-16 16:07:38 -08:00
Sam El-Husseini 1661d640d6 Geras inline alignment of rows + max bottom row width (#3575)
* Add a desired width getter method for input rows. Override in geras to fix the width of the bottom row and statement input to a max width.
2020-01-13 10:40:52 -08:00
Sam El-Husseini 1924b2674a Treat a statement input as the end of the statement row. (#3577)
* Reduce spacing for editable fields when they appear right before a statement input.
2020-01-11 17:34:45 -08:00
Sam El-Husseini e1472a3600 Detect undefined elements in the debugger and remove undefined elem if a row has no elements when adding spacers. (#3576) 2020-01-11 17:33:20 -08:00
Sam El-Husseini fe555d9021 Rename input connection to connectionModel (#3571)
* Remove input measurable's connection property and rename references to connectionModel.
2020-01-09 18:09:15 -08:00
Sam El-Husseini c3867443f5 Fix value to stack width measurement (#3559)
* Include width of connected block in value to stack width measurement.
2020-01-07 16:05:34 -08:00
Sam El-Husseini 2b335dcb6b Make alignment common renderer behaviour (#3498)
* Make alignment common
2019-12-11 13:42:10 -08:00
Sam El-Husseini 55997784ca Move blockStyles into constants (#3485)
* Move blockStyles into constants.
2019-12-06 10:51:36 -08:00
Sam El-Husseini f4431b3361 [Zelos] apply Colour (#3465)
* Only apply colour from a single entry point. Zelos rendering apply colour
2019-11-25 14:18:10 -08:00
Sam El-Husseini 70c24cf94e CSS in renderers (#3446)
* Have each renderer declare some CSS that is specific to the renderer.
2019-11-18 16:14:19 -08:00
Sam El-Husseini 2dea7038d5 Moves field layout constants into the renderer (#3437)
* Add field constants into renderer constants
2019-11-13 16:41:35 -08:00
Sam El-Husseini ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Rachel Fenichel bfff91b673 Update geras and add underscore to setClass_ 2019-11-06 11:47:33 -08:00
Sam El-Husseini 337cb9c486 Fix path_object inheritance (#3403)
* Fix path_object inheritance, add zelos path_object
2019-11-05 16:36:30 -08:00
Rachel Fenichel 13e4d671c3 Moved setHighlighted and setDisabled into the path object. 2019-11-01 14:28:51 -07:00
Sam El-Husseini 93755fef53 Treat compiler warnings as errors and run on travis (#3378)
* Enable compiler warnings as errors and run on travis
2019-10-31 15:49:28 -07:00
Rachel Fenichel 46fad66ab1 Review feedback. 2019-10-30 15:58:53 -07:00
Rachel Fenichel 5ef08fc0d4 Switch to using the style object in the path object. 2019-10-30 14:47:23 -07:00
Rachel Fenichel ca1e49bf8e Fields now go through blockSvg for colours. 2019-10-30 14:43:42 -07:00
Rachel Fenichel ecef3467fd Colourer/path_object cleanup 2019-10-30 14:42:13 -07:00
Rachel Fenichel 6f520335ea Cleanup of colouring code, and move it into path_object. 2019-10-30 14:42:13 -07:00
Rachel Fenichel 85c4db5a10 First pass at colourers 2019-10-30 14:42:13 -07:00
Sam El-Husseini 942068314f Accept lowercase alignment (#3359)
* Accept lowercase alignment
2019-10-29 11:45:30 -07:00
Sam El-Husseini e7752e6ea2 Dummy input right alignment (#3342)
* Fix dummy input alignment in geras.
2019-10-28 16:20:54 -07:00
Sam El-Husseini 100da4a66c Revert "Wrap dummy inputs in a measurable so that it can be aligned appropriately. (#3337)"
This reverts commit 7fc733b81f.
2019-10-24 21:53:30 -07:00
Sam El-Husseini a79ea1652a [Zelos] Fix dynamic connection shape size (#3324)
* Better reporting of connection height and width for dynamic connections
2019-10-25 00:33:53 -04:00
Sam El-Husseini 7fc733b81f Wrap dummy inputs in a measurable so that it can be aligned appropriately. (#3337) 2019-10-24 21:42:44 -04:00
Rachel Fenichel d11b7228c2 Fix #3228 by only using the dark path offset in Geras. 2019-10-23 11:06:12 -07:00
Sam El-Husseini 42552b5b22 Fix 6 warnings related to rendering. (#3292) 2019-10-21 17:49:38 -04:00
Rachel Fenichel 9ce41598c0 Clean up todos. 2019-10-07 13:25:47 -07:00
Rachel Fenichel 05e9cf126a Signs are hard. 2019-10-03 10:47:27 -07:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Rachel Fenichel 6b78417ede Bound element position based on height of the row 2019-10-02 11:27:26 -07:00
Rachel Fenichel ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Neil Fraser 872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Monica Kozbial 21c5698e98 Moving DARK_PATH_OFFSET to geras only. (#3066)
* Moving DARK_PATH_OFFSET to geras.

* Adding compressed and uncompressed files.

* Adding missing newlines

* Reverting commit of messages.

* Reverting compressed files.

* Updating compressed files.

* Addressing PR comments.

* Removing unecessary input overrides.
2019-09-23 15:57:59 -07:00
Monica Kozbial a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Sam El-Husseini 57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
Rachel Fenichel 77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
Sam El-Husseini e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini fc420b7037 Support for registering renderers and switching between them (#3013)
* Added support for registering renderers and for choosing which renderer the workspace wants to use.
2019-09-13 10:30:20 -07:00
kozbial 90a10e5f44 Fix logic in shouldStartNewRow_ and between row padding in geras. 2019-09-12 11:34:08 -07:00
Sam El-Husseini 8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel 4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Rachel Fenichel e96acf476c Add dark path offset in geras info. 2019-09-05 16:55:56 -07:00
Rachel Fenichel 261040a6fd Add jsdoc 2019-09-05 16:19:51 -07:00
Rachel Fenichel e48c60fee6 Use strings instead of arrays for highlight paths 2019-09-05 15:48:46 -07:00
Rachel Fenichel da6d28b818 More cleanup 2019-09-05 11:16:27 -07:00
Rachel Fenichel 87e7be9619 Cleanup 2019-09-04 17:19:31 -07:00