Sam El-Husseini
526528354f
Fix 10 warnings related to visibility ( #3275 )
2019-10-17 11:46:57 -05:00
Sam El-Husseini
c1c9121fcc
Fix jsdoc. @return instead of @returns ( #3271 )
...
* Fix jsdoc. @return instead of @returns
2019-10-16 17:01:36 -05:00
Beka Westberg
8407428e8f
Reverted scrollbar resize change. ( #3274 )
2019-10-16 16:54:47 -05:00
Rachel Fenichel
b4b3ae316f
Merge pull request #3224 from zochris/variable-exists-phrasing
...
Rephrase "variable already exists" message
2019-10-16 12:37:15 -06:00
Rachel Fenichel
35e894af13
Fix #1714
2019-10-16 11:53:08 -06:00
Sam El-Husseini
3c2c4677df
Fix 55 warnings related to flyouts. ( #3211 )
...
* Fix 55 warnings related to flyouts.
2019-10-16 12:13:37 -05:00
Sam El-Husseini
986e965be8
Private/protected visibility cleanup ( #3263 )
...
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
Neil Fraser
01b6992efd
Normalize to one spelling of color/colour.
2019-10-16 09:46:47 -07:00
Sam El-Husseini
267deceb82
Dropdowndiv positioning ( #3212 )
...
* Fix positioning of the dropdown div
2019-10-16 10:20:40 -05:00
Neil Fraser
2eaabd180d
Minor cleanup in keyboard nav ( #3264 )
...
* Clean cursor code
Some obvious inefficiencies that jumped out while randomly browsing the compiled code.
* Typos
* Multiplying by minus one.
2019-10-16 08:19:37 -05:00
Neil Fraser
013f2714a3
Cleanup aria usage. ( #3261 )
...
Use enums instead of arbitrary strings.
Delete unused Aria properties
Add missing requires.
Delete unused code.
2019-10-15 22:43:23 -07:00
Sam El-Husseini
2224bb2a4e
More field dispose ( #3201 )
...
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Beka Westberg
8f73fdb512
Fixed comments in trashcan.
2019-10-15 13:02:02 -07:00
Beka Westberg
b2a8172720
Fixed disabled blocks in trashcan.
2019-10-15 13:02:02 -07:00
alschmiedt
a9420154a2
Update todos so they are no longer in jsdocs ( #3250 ) ( #3257 )
2019-10-15 10:14:39 -07:00
alschmiedt
ef859d351d
Fix jsdoc syntax ( #3246 )
2019-10-15 09:28:37 -07:00
Thomas Ballinger
b913295028
restart cursor animation on cursor move ( #3226 )
2019-10-15 09:01:03 -07:00
RoboErikG
d09b85dc9e
Cleanup for #3179 ( #3229 )
2019-10-14 09:57:38 -07:00
zochris
f26829eb6d
Change variable exists message to show casing
2019-10-13 20:39:06 +02:00
zochris
bf7abee679
Rephrase "variable already exists" message
...
The message now includes the name with casing of the already existing
variable.
2019-10-13 14:39:03 +02:00
Josh Lory
43f9ab6889
Look up notch height from the current renderer ( #3217 )
2019-10-11 15:30:26 -07:00
Sam El-Husseini
e18dcd1bea
bringToFront optimization for large workspaces ( #3214 )
...
* bringToFront optimization for large workspaces
2019-10-09 16:08:23 -07:00
Sam El-Husseini
3368a9f713
Revert calling onHide before the animation is complete to avoid double click issues. ( #3202 )
2019-10-09 11:16:16 -07:00
Sam El-Husseini
4b35320c86
Fix #2811 ( #3205 )
2019-10-09 10:10:12 -07:00
Rachel Fenichel
e7859db8c7
Merge pull request #3203 from rachel-fenichel/drag_delta
...
Initialize drag delta to (0,0) and update annotation.
2019-10-08 18:11:14 -07:00
Rachel Fenichel
65cf0c5e98
Initialize drag delta to (0,0) and update annotation.
...
Remove 12 warnings.
2019-10-08 18:04:05 -07:00
Rachel Fenichel
b9dd13cde0
Fix #3169 ( #3199 )
2019-10-08 17:29:53 -07:00
Beka Westberg
f4f9a67903
Fixed field editor disposal ( #3109 )
...
* Fixed field editor disposal.
2019-10-08 16:48:31 -07:00
alschmiedt
cf04a9529b
Fix compilier warnings for keyboard nav ( #3196 )
...
* Fix compilier warnings for keyboard nav
2019-10-08 11:34:39 -07:00
Sam El-Husseini
1d113b5069
Add support for setting the direction in RTL. ( #3192 )
2019-10-07 17:28:18 -07:00
Rachel Fenichel
a5f19a5660
Merge pull request #3187 from rachel-fenichel/todos
...
Clean up todos.
2019-10-07 15:08:04 -07:00
alschmiedt
a1b18368f2
Remove dead code from ast node ( #3183 )
2019-10-07 14:20:37 -07:00
zochris
fcfeb316e7
Make "Infinity" case-insensitive in number field ( #3188 )
2019-10-07 14:16:24 -07:00
Rachel Fenichel
9ce41598c0
Clean up todos.
2019-10-07 13:25:47 -07:00
RoboErikG
663809297d
Set correct defaults for Fields ( #3179 )
...
null was being converted to 0 by Number() when it should cause the
default value to be set instead. This updates FieldNumber and
FieldAngle to handle nulls correctly. Also update jsdoc.
Fixes #3177
2019-10-07 11:38:32 -07:00
Beka Westberg
a08d9f2277
Re-added resizeBubble_ call. Fixed resizeBubble_ JSDoc. ( #3173 )
2019-10-07 11:08:45 -07:00
Sam El-Husseini
2ac4149d98
Misc compiler warnings. ( #3172 )
...
* Fix misc compiler warnings. Use ws.getToolbox() instead of ws.toolbox_
2019-10-07 11:06:56 -07:00
Rachel Fenichel
608ce7b93c
Merge pull request #3133 from BeksOmega/fixes/ConnectionTracking
...
Connection Tracking Pt 3: Changed connections to use 'tracked_' property
2019-10-07 11:05:10 -07:00
Beka Westberg
e09a7b8165
Renamed doNotCallTrackConnections_ to callTrackConnections. Flipped logic. Moved it to the constructor.
2019-10-05 12:28:25 -07:00
Rachel Fenichel
b342a12911
Merge pull request #3155 from rachel-fenichel/trashcan_visibility
...
Make trashcan setOpen package and update a few annotations.
2019-10-04 15:55:15 -07:00
Rachel Fenichel
a5377c1e08
Merge pull request #3154 from rachel-fenichel/disposal_cleanup
...
Get rid of unnecessary nulls in block dragger, insertion marker manag…
2019-10-04 15:53:42 -07:00
Sam El-Husseini
74ecb94078
Remove last instance of Object.assign ( #3161 )
2019-10-04 13:06:58 -07:00
Sam El-Husseini
80aac249ea
Make bumpNeighbours public. ( #3156 )
2019-10-03 19:31:55 -07:00
Rachel Fenichel
79c2fa6688
Make trashcan setOpen package and update a few annotations.
2019-10-03 18:08:27 -07:00
Rachel Fenichel
45d66a1264
Get rid of unnecessary nulls in block dragger, insertion marker manager, and gesture dispose functions.
2019-10-03 17:58:29 -07:00
Sam El-Husseini
e4cc2217e6
Fix compiler warnings related to events. ( #3151 )
...
* Fix 23 warnings in event related code.
2019-10-03 15:59:01 -07:00
Sam El-Husseini
d0772ad496
Fix compiler warnings related to fields. ( #3144 )
...
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Sam El-Husseini
7839512f0e
When collapsed, toString was referencing text_. Using getText instead. ( #3150 )
2019-10-03 15:26:41 -07:00
Sam El-Husseini
e5ec726253
Fix type, caught by typings
2019-10-03 14:41:15 -07:00
Sam El-Husseini
fba98fca5b
Move the dropdown field into the dropdown div. ( #3122 )
...
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00