Commit Graph

2165 Commits

Author SHA1 Message Date
Sam El-Husseini
80aac249ea Make bumpNeighbours public. (#3156) 2019-10-03 19:31:55 -07:00
Sam El-Husseini
e4cc2217e6 Fix compiler warnings related to events. (#3151)
* Fix 23 warnings in event related code.
2019-10-03 15:59:01 -07:00
Sam El-Husseini
d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Sam El-Husseini
7839512f0e When collapsed, toString was referencing text_. Using getText instead. (#3150) 2019-10-03 15:26:41 -07:00
Sam El-Husseini
e5ec726253 Fix type, caught by typings 2019-10-03 14:41:15 -07:00
Sam El-Husseini
fba98fca5b Move the dropdown field into the dropdown div. (#3122)
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00
Rachel Fenichel
f2812df7dd Merge pull request #3147 from rachel-fenichel/misc_cleanup
Misc cleanup
2019-10-03 14:27:03 -07:00
Rachel Fenichel
c5e691b88b Update workspace_svg.js 2019-10-03 14:26:42 -07:00
Sam El-Husseini
735a72c20a mutation / compose fn annotations (#3149)
* Add compose / decompose type annotations.
2019-10-03 14:25:07 -07:00
Neil Fraser
f5909c9916 Restore require variables to blockly.js (#3145)
Variables and Xml are circular dependencies.  Both need to be declared in blockly.js

Maybe they can be sorted out later, but for now things are broken since nobody in core currently requires variables anywhere.
2019-10-03 14:14:19 -07:00
Rachel Fenichel
05e9cf126a Signs are hard. 2019-10-03 10:47:27 -07:00
Rachel Fenichel
78dc82f7ac Misc cleanup: annotations, and flyoutButton disposal. 2019-10-03 10:40:43 -07:00
Rachel Fenichel
77e64b39bc Remove unused nulls in disposal 2019-10-02 17:10:41 -07:00
Rachel Fenichel
771d6a119e Merge pull request #3143 from rachel-fenichel/remove_block_render_svg
Remove block_render_svg
2019-10-02 16:33:47 -07:00
Rachel Fenichel
668731b545 add visibility annotations 2019-10-02 16:29:32 -07:00
Rachel Fenichel
7ed47670cf Remove block_render_svg 2019-10-02 16:21:36 -07:00
Rachel Fenichel
79bedca5a7 Element -> SVGElement (#3140)
* Use SVGElement instead of Element for the results of createSvgElement

* More SVGElement annotations.
2019-10-02 16:12:31 -07:00
Sam El-Husseini
eb5f1cc94a Fix 6 warnings in components/ (#3141) 2019-10-02 16:12:17 -07:00
Neil Fraser
c6b8cd69b5 Update newly added licenses.
The minimalist rendere was added while the licenses PR was waiting for review.
2019-10-02 15:33:42 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
31a2544989 Rename sample renderer to minimalist (#3137)
* Rename sample to minimalist
2019-10-02 14:16:36 -07:00
Sam El-Husseini
d28e897e47 Add a sample renderer instance. (#3136)
* Add a sample renderer instance.
2019-10-02 13:22:54 -07:00
Sam El-Husseini
99ce193b1f Base renderer next / prev connection fixes. (#3135) 2019-10-02 12:35:00 -07:00
Rachel Fenichel
d7cc808d1f Merge pull request #3134 from rachel-fenichel/bugfix/3098
Bound element position based on height of the row
2019-10-02 11:44:37 -07:00
Sam El-Husseini
1236660efd Actually make WS comments optional (#3130)
* Remove last reference to ws comments since its an optional module

* Also remove from workspace
2019-10-02 11:41:51 -07:00
Sam El-Husseini
f22603f32a Call onHide before clearing content (#3131) 2019-10-02 11:41:34 -07:00
Rachel Fenichel
6b78417ede Bound element position based on height of the row 2019-10-02 11:27:26 -07:00
Rachel Fenichel
ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Sam El-Husseini
d7a7c7b4d5 Support XML serialization in Node.js (#3126)
* Support XML serialization in Node.js
2019-10-01 14:40:35 -07:00
Beka Westberg
229dd69e54 Fixed review comments. 2019-09-30 15:32:17 -07:00
Beka Westberg
afbb2cca1e Moved all database related code out of headless and into rendered. 2019-09-27 18:00:06 -07:00
Beka Westberg
1baf7d1dcf Added a bunch of connection related tests. 2019-09-27 15:56:29 -07:00
alschmiedt
468b673b73 Fix bugs (#3108)
* Fix various bugs around keyboard nav
2019-09-27 14:34:28 -07:00
Rachel Fenichel
371a7c5807 Merge branch 'develop' into remove_debug 2019-09-27 12:47:44 -07:00
alschmiedt
b5a076d2b3 Add theme requires (#3114) 2019-09-27 12:36:16 -07:00
Sam El-Husseini
41e5914bd7 el.style is readonly in strict mode IE. Fixing crash in IE. (#3119) 2019-09-27 12:21:08 -07:00
Rachel Fenichel
0e1a4b68e1 Remove blockRendering.Debug, thrasos, and zelos from default requires.js 2019-09-27 12:01:06 -07:00
Neil Fraser
a2e6cfffcc Block comments from XML not fatal
…if Blockly.Comment was not compiled in.
2019-09-27 11:46:23 -07:00
Neil Fraser
b701475984 Simplify trashcan code (#3110)
Also delete unused props in CSS.
2019-09-27 11:43:56 -07:00
Sam El-Husseini
fc2c730e44 Make workspace comments an optional module, remove from this release. (#3115) 2019-09-27 11:15:11 -07:00
Monica Kozbial
f4136fdc2a Adding test and updating TODO. (#3102)
* Adding test and updating TODO.

* changing bug number referenced in TODO
2019-09-27 11:12:37 -07:00
Monica Kozbial
40e0d55187 Removing obsolete TODO comment. (#3104) 2019-09-27 11:12:11 -07:00
Neil Fraser
872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Neil Fraser
6650ecf13f Make dynamic variables be an optional module.
Also straighten out some dependencies.
2019-09-27 10:48:14 -07:00
Neil Fraser
4ed3295ad9 Make generator an optional module (#3105) 2019-09-27 10:47:10 -07:00
Sam El-Husseini
35424f2484 Angle field touch fixes (#3079)
* Fix touch support for angle fields
2019-09-26 17:11:03 -07:00
Sam El-Husseini
870824bc3e Workspace theme (#3093)
* Move the theme object so it's on the workspace.

* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
Monica Kozbial
22e79ae496 Updating behavior of register functions and adding unregister. (#3085)
* Updating behavior of register functions and adding unregister.

* Updates jsdoc comments.
2019-09-26 13:23:45 -07:00
Sam El-Husseini
a57c7ffb13 Clean up fields by passing the right type in fromJson (#3095) 2019-09-26 12:03:17 -07:00
alschmiedt
244bbe554b More navigation cleanup (#3100) 2019-09-26 11:13:47 -07:00