Commit Graph

8201 Commits

Author SHA1 Message Date
Samruddhi Somwanshi
86bcf712dc fix: Addition of the .gitattributes file to standardize line endings #7191 (#7517)
* addition of the .gitattributes file

* Update .gitattributes
2023-09-23 09:30:43 -07:00
Sayali Kandarkar
e4d8f160aa fix: removed underscore from isLabel_ in flyout_button.ts (#7533)
* Removed underscore from isLabel_ in flyout_button.ts

* chore: rename isLabel_ to isFlyoutLabel in flyout_button.ts

* fix: format

---------

Co-authored-by: sayali-kandarkar <skandark@andrew.cmu.edu>
2023-09-22 15:32:39 -07:00
Sampada Bhujel
c37f4b8749 feat: Paste block in viewport / near cursor (#7521)
* fix: Paste block in viewport / near cursor

* Fix: formatting fix with prettier

* fix import path for Coordinate

* fix import path for coordinate

* paste so that the block's center is at the viewport center
2023-09-22 15:32:00 -07:00
Ramya Ramasamy
4437fdb089 feat: made the method isDragTowardWorkspace non private (#7529)
* removed internal from horizontal and vertical flyout

* feat : made the method isDragTowardWorkspace non private

* feat : made the method isDragTowardWorkspace non private

---------

Co-authored-by: Ramya Non-IU <ramyaram2092@outlook.com>
2023-09-22 14:28:48 -07:00
Rachel Fenichel
a4889732d6 Merge pull request #7528 from humera811/fixes
fix: move delete keyboard shortcut in-progress gesture check to precondition #6274
2023-09-22 14:21:28 -07:00
Akanksha Kushwaha
9051889c43 minor: update 'field_input.ts' file (#7514)
* minor: update return type of widgetCreate_

Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>

* minor: remove 'as HTMLInputElement' cast

Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>

* minor: update return type and cast

Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>

---------

Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>
2023-09-22 13:50:16 -07:00
humera811
112d1ae78a Fix: Move delete keyboard shortcut in-progress gesture check to precondition 2023-09-22 13:48:54 -07:00
ivalkshfoeif
bb425358bf Add a getTargetWorkspace method to flyout_base.ts (#7519) 2023-09-22 12:52:23 -07:00
Maribeth Bottorff
a04a0975a4 Revert "chore(deps): update webdriverio to 8.16 and stop using selenium-standalone" (#7520)
This reverts commit b22656b636.
2023-09-22 11:47:36 -07:00
satya verma
4a6d4399d1 fix: incorrect blockchange firing (#7492)
* BlockChange event disabled

* BlockChange event disabled

* executed command (npm run format)
2023-09-21 05:34:24 -07:00
Beka Westberg
12ac35829e fix: loading tooltips before messages (#7504)
* fix: loading tooltips before messages

* fix: typing
2023-09-20 14:07:06 +00:00
laurensvalk
3b234c7f87 fix: Call onFinishEditing_ for fields on mobile. (#7483)
On the desktop, widgetDispose_ will call onFinishEditing_ on close.

This was missing in the mobile counterpart, so any cleanups in onFinishEditing_ would not be called.

Also update the message string comment while we are touching this code.
2023-09-20 06:15:17 -07:00
Rachel Fenichel
ed043e7228 Merge pull request #7500 from rachel-fenichel/update_webdriverio
chore(deps): update webdriverio to 8.16 and remove selenium-standalone
2023-09-19 14:19:04 -07:00
Neil Fraser
61cdbb65d3 chore: Setting style property to make CSP less grumpy. (#7503)
* Setting style property to make CSP less grumpy.

"Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“style-src”)."

The 'style' property should be set as an object, not as a string, according to CSP rules.

Back-ported from Blockly Games.
2023-09-19 17:01:14 +02:00
Beka Westberg
32c9daf885 fix: bad JSON state leaving events disabled (#7501)
* fix: broken JSON state stopping event firing

* chore: add unit test for events not breaking
2023-09-19 05:17:51 -07:00
Beka Westberg
f8a134caef fix: immediately render for JavaFX (#7502) 2023-09-18 20:12:20 +00:00
Rachel Fenichel
550443f39c chore(deps): remove selenium config and macOS test setup 2023-09-18 12:03:30 -07:00
Rachel Fenichel
b22656b636 chore(deps): update webdriverio to 8.16 and stop using selenium-standalone 2023-09-18 11:49:12 -07:00
Rachel Fenichel
c3b7d42022 Merge pull request #7493 from rachel-fenichel/minor_browser_fixes
fix: minor issues in browser tests
2023-09-18 08:56:48 -07:00
dependabot[bot]
3806137340 chore(deps): Bump @blockly/dev-tools from 7.0.3 to 7.1.0 (#7499)
Bumps [@blockly/dev-tools](https://github.com/google/blockly-samples/tree/HEAD/plugins/dev-tools) from 7.0.3 to 7.1.0.
- [Release notes](https://github.com/google/blockly-samples/releases)
- [Changelog](https://github.com/google/blockly-samples/blob/master/plugins/dev-tools/CHANGELOG.md)
- [Commits](https://github.com/google/blockly-samples/commits/@blockly/dev-tools@7.1.0/plugins/dev-tools)

---
updated-dependencies:
- dependency-name: "@blockly/dev-tools"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-18 05:50:20 -07:00
dependabot[bot]
bd7334ffef chore(deps): Bump webdriverio from 8.13.10 to 8.16.10 (#7495)
Bumps [webdriverio](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/webdriverio) from 8.13.10 to 8.16.10.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.16.10/packages/webdriverio)

---
updated-dependencies:
- dependency-name: webdriverio
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-18 05:50:09 -07:00
dependabot[bot]
e914c48890 chore(deps): Bump eslint-plugin-jsdoc from 46.6.0 to 46.8.1 (#7496)
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 46.6.0 to 46.8.1.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v46.6.0...v46.8.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-18 05:49:47 -07:00
dependabot[bot]
dd88f7b912 chore(deps): Bump @typescript-eslint/eslint-plugin from 6.6.0 to 6.7.0 (#7497)
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.6.0 to 6.7.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-18 05:49:33 -07:00
dependabot[bot]
d7cb893d18 chore(deps): Bump chai from 4.3.7 to 4.3.8 (#7498)
Bumps [chai](https://github.com/chaijs/chai) from 4.3.7 to 4.3.8.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md)
- [Commits](https://github.com/chaijs/chai/compare/v4.3.7...v4.3.8)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-18 05:48:38 -07:00
Beka Westberg
25d15fd596 fix: zelos full block fields rendering badly (#7490)
* fix: text input fields

* fix: colour field

* chore: cleanup override keywords

* chore: revert playground changes

* fix: applyColour not being called

* chore: swap visibility for display

* chore: cleanup for PR comments

* fix: PR comments
2023-09-14 22:22:40 +00:00
Rachel Fenichel
cc3c0d9bdf fix: minor issues in browser tests 2023-09-14 14:01:31 -07:00
Rachel Fenichel
00d870ee03 Merge pull request #7485 from rachel-fenichel/clickableElement
fix(tests): contextMenuSelect sometimes clicks the wrong block
2023-09-13 13:29:58 -07:00
Rachel Fenichel
67f42f017a chore(tests): rewrite getClickableBlockElement as clickBlock 2023-09-13 12:36:39 -07:00
Rachel Fenichel
5ee26c9051 feat: use block instead of block ID in getClickableBlockElement 2023-09-13 11:30:46 -07:00
Rachel Fenichel
fc76981e5b Merge pull request #7482 from clementcontet/fix-7426
fix: insertion marker position when connection is resized (#7426)
2023-09-13 10:50:56 -07:00
Neil Fraser
1f0f733a04 chore: Remove 'cgi' import from Python (#7479)
The cgi modue disappears in the next version of Python.  This PR adds an import of urllib.parse, but that's not a new dependency since cgi already imported it.
2023-09-13 09:04:18 -07:00
dependabot[bot]
6415054a48 chore(deps): Bump actions/checkout from 3 to 4 (#7474)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-13 08:53:37 -07:00
dependabot[bot]
58c0e096ca chore(deps): Bump selenium-standalone from 8.3.0 to 9.1.1 (#7459)
Bumps [selenium-standalone](https://github.com/webdriverio/selenium-standalone) from 8.3.0 to 9.1.1.
- [Release notes](https://github.com/webdriverio/selenium-standalone/releases)
- [Changelog](https://github.com/webdriverio/selenium-standalone/blob/main/HISTORY.md)
- [Commits](https://github.com/webdriverio/selenium-standalone/compare/v8.3.0...v9.1.1)

---
updated-dependencies:
- dependency-name: selenium-standalone
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-13 08:53:16 -07:00
dependabot[bot]
c2e6ed8db6 chore(deps): Bump eslint-plugin-jsdoc from 46.5.0 to 46.6.0 (#7476)
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 46.5.0 to 46.6.0.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v46.5.0...v46.6.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-13 08:53:00 -07:00
dependabot[bot]
c59a52a070 chore(deps): Bump @hyperjump/json-schema from 1.5.1 to 1.5.2 (#7475)
Bumps [@hyperjump/json-schema](https://github.com/hyperjump-io/json-schema) from 1.5.1 to 1.5.2.
- [Commits](https://github.com/hyperjump-io/json-schema/compare/v1.5.1...v1.5.2)

---
updated-dependencies:
- dependency-name: "@hyperjump/json-schema"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-13 08:52:48 -07:00
Clément Contet
36b00fb660 chore: format 2023-09-13 07:49:13 +02:00
Rachel Fenichel
cad3d4b10c chore(tests): format 2023-09-12 15:13:43 -07:00
Rachel Fenichel
8d6eb80290 chore(tests): use new helper function in delete tests 2023-09-12 14:50:05 -07:00
Rachel Fenichel
6a920a87cc fix(tests): use new helper function for right-clicks 2023-09-12 14:45:08 -07:00
Rachel Fenichel
1f5dc25b3c fix(tests): use new helper function for right-clicks 2023-09-12 14:43:31 -07:00
Rachel Fenichel
6d63f3cc6b feat(tests): add helper to get a clickable element on a block 2023-09-12 14:30:11 -07:00
Christopher Allen
e7030a18a6 refactor(build): Remove closure-make-deps and closure-calculate-chunks (#7473)
* refactor(build): Don't use closure-calculate-chunks

  Rewrite the getChunkOptions function to not use
  closure-calculate-chunks, but instead just chunk the input files
  (more or less) by subdirectory: first chunk is core/, second is
  blocks/, etc.

  This does make a material change to blockly_compressed.js,
  because we end up feeding several empty modules that contain
  only typescript interface declarations and which tsc
  compiles to "export {};" in the input to Closure Compiler
  (closure-calculate-chunks is smart enough to notice that
  no other module depends on these), which results in ~1.7KiB of
  superflous

      var module$build$src$core$interfaces$i_ast_node_location_svg={};

  declarations.  This can be avoided by filtering such empty modules
  out but that has been left for a future commit.

  This adds the glob NPM package as a dev dependency, but gulp
  and several other existing dev dependencies already depend on
  it.

  Build time is sped up by about a factor of 3x, due to removal
  of the buildDeps step that was really slow:

  $ time npm run build

  before:
  real    0m24.410s
  user    0m16.010s
  sys     0m1.140s

  after:
  real    0m8.397s
  user    0m11.976s
  sys     0m0.694s

* chore(build): Remove buildDeps task

* refactor: Remove $build$src infix from munged paths

  Closure Compiler renames module globals so that they do not
  clash when multiple modules are bundled together.  It does so
  by adding a "$$module$build$src$path$to$module" suffix (with
  the module object istelf being named simply
  "$module$build$src$path$to$module").

  By changing the gulp.src base option to be build/src/ instead
  of ./ (referring to the repostiory root), Closure Compiler
  obligingly shortens all of these munged named by removing the
  "$build$src" infix, reducing the size of the compressed chunks
  by about 10%; blockly_compressed.js goes from 900595 to 816667
  bytes.

* chore(build): Compute module object munged name from entrypoint

  - Add modulePath to compute the munged name of the entrypoint
    module from the entrypoint module filename, and use this
    instead of hard-coded chunk.exports paths.
  - Be more careful about when we are using poxix vs. OS-specific
    paths, especially TSC_OUTPUT_PATH which is regularly passed
    to gulp.src, which is documented as taking only posix paths.
  - Rename one existing variable modulePath -> entryPath to try
    to avoid confusion with new modulePath function.
2023-09-12 17:13:52 +01:00
Clément Contet
b95067b949 chore: position insertion marker in a single function 2023-09-12 11:11:31 +02:00
Christopher Allen
07fec204bf chore: Tweak issue templates (#7455)
* chore: Tweak issue templates

* chore: fixup emoji

---------

Co-authored-by: Beka Westberg <bwestberg@google.com>
2023-09-11 12:02:20 -07:00
dependabot[bot]
b1d25b5304 chore(deps): Bump @typescript-eslint/eslint-plugin from 6.4.0 to 6.6.0 (#7477)
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.4.0 to 6.6.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.6.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-11 11:54:34 -07:00
Beka Westberg
4eba35ec7b fix: doFullSerialization for insertion markers (#7467) 2023-09-11 08:38:51 -07:00
John Nesky
1b2e91246e chore: Use JSON objects for context menu callbackFactory (#7382)
* chore: use json object for context callbackFactory

* Add test file for context menu callback function.
2023-09-08 16:16:59 -07:00
Beka Westberg
0d2879be7d chore: remove unused sections from PR template (#7465) 2023-09-06 15:28:38 -07:00
Beka Westberg
344861698e fix: connection highlight not disposed when block deleted (#7454) 2023-09-06 10:11:36 -07:00
dependabot[bot]
9390796e83 chore(deps): Bump prettier from 3.0.0 to 3.0.3 (#7458)
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.0 to 3.0.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.0.0...3.0.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-06 09:17:36 -07:00