Maribeth Bottorff
28de9ef494
fix: paste in a better spot ( #8123 )
...
* fix: paste in a better spot
* fix: include bump offset
* chore: rename param
---------
Co-authored-by: Beka Westberg <bwestberg@google.com >
2024-05-20 10:09:47 -07:00
Neil Fraser
fcdb8fc33d
fix: Normalize CSS between comment types ( #8161 )
...
Merge the CSS so that both comment types (block and workspace) are the same -- other than a border.
2024-05-20 18:59:24 +02:00
Beka Westberg
7c4b0bd703
fix: delete area animation ( #8149 )
...
* fix: delete area animation
* chore: format
* Update core/dragging/dragger.ts
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com >
---------
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com >
2024-05-20 09:58:48 -07:00
Beka Westberg
139b4b993f
fix: creating comments in RTL ( #8153 )
2024-05-20 09:54:30 -07:00
Neil Fraser
70ca676c24
fix: Properly size comments. ( #8158 )
...
* Properly size comments.
Fixes multiple rendering and sizing issues across different browsers.
Tip: `text-overflow: hidden;` is not legal CSS and did nothing.
Resolves #8142
2024-05-20 09:30:38 -07:00
Beka Westberg
36b75696a2
fix: comment text area bottom border hidden ( #8152 )
2024-05-20 09:03:59 -07:00
Beka Westberg
69db8a63d6
fix: comment size not respecting collapsed-ness ( #8136 )
...
* fix: comment size not respecting collapsed-ness
* chore: fix tests the only way I know how, by adding explicit clock ticks
2024-05-17 13:23:13 -07:00
Beka Westberg
3fd749205f
fix: dragging blocks by shadows to delete ( #8138 )
...
* Revert "fix: dragging shadow blocks (#7992 )"
This reverts commit c0e6e6745f
2024-05-17 13:22:53 -07:00
Neil Fraser
5a8969f855
fix: Zelos comments shouldn't be bold ( #8141 )
...
Resolves #8061
2024-05-17 21:33:52 +02:00
Beka Westberg
12ff96674b
fix: comment handle position in RTL ( #8151 )
2024-05-17 12:27:14 -07:00
Beka Westberg
75d81620ab
fix: undoing block delete over trashcan creates block in wrong place ( #8126 )
2024-05-17 12:26:10 -07:00
Maribeth Bottorff
80cacdcad7
Merge pull request #8140 from maribethb/grabby
...
fix: change cursor to grab on ws comment bar
2024-05-17 09:47:45 -07:00
Beka Westberg
44db3edce3
fix: comment move events and snapping ( #8127 )
2024-05-17 08:26:23 -07:00
Maribeth Moffatt
e4b734c0db
fix: change cursor to grab on ws comment bar
2024-05-16 17:54:28 -07:00
Sam El-Husseini
23af202796
fix: workspace comment bounding box affecting RTL zoom ( #8125 )
2024-05-16 10:36:36 -07:00
Sampada Bhujel
049993405e
fix: JSON deserialization not firing variable create events for blocks ( #8122 )
...
* fix: JSON deserialization not firing variable create events for blocks
* fix: extract logic for checking added variables and firing event to checkNewVariables function
2024-05-15 15:46:23 -07:00
Beka Westberg
dfcf5317c1
fix: throwing errors for chameleon blocks ( #8121 )
2024-05-15 12:51:55 -07:00
Beka Westberg
dd9619dc94
fix: extra insertion markers being created ( #8120 )
...
* fix: extra insertion markers being created
* chore: remove unused value
2024-05-15 10:44:13 -07:00
Beka Westberg
e2eba2879d
fix: connection db error for insertion markers ( #8109 )
2024-05-15 08:27:43 -07:00
Beka Westberg
392a38bb2e
fix: drag cursor being incorrect for flyout blocks ( #8107 )
2024-05-14 13:24:20 -07:00
Neil Fraser
fca94ce799
fix: Remove deprecation warnings for 'disabled'. ( #8104 )
...
We must continue to support existing XML and JSON serialization formats since they are in external databases.
The decision was taken not to make the save formats compatible with older versions of Blockly. We could not think of a convincing use-case for a newer Blockly's output to be read by an older Blockly. If such a case appears, then our decision should change.
Resolves #8095 .
2024-05-14 08:55:43 -07:00
Maribeth Moffatt
0255c580f7
Merge branch 'develop' into merge-v11
2024-05-13 11:20:39 -07:00
Neil Fraser
c0298652af
feat: Add snapping to workspace comments. ( #8070 )
...
Now that there are two things that snap (blocks and WS comments), the alignment code in being moved to a common place.
2024-05-12 23:16:26 +02:00
Maribeth Bottorff
28ac0c4473
fix: improve types in FieldRegistry ( #8062 )
...
* fix: improve types in FieldRegistry
* chore: tsdoc
2024-05-10 14:14:50 -07:00
Beka Westberg
c704d5a887
revert: "feat: allow the dialog methods to take in extra parameters ( #8084 )" ( #8085 )
...
This reverts commit 278006b5f8
2024-05-10 11:12:15 -07:00
Maribeth Bottorff
54eeb85d89
fix!: add getContents to IFlyout ( #8064 )
2024-05-08 11:44:00 -07:00
Beka Westberg
278006b5f8
feat: allow the dialog methods to take in extra parameters ( #8084 )
...
* feat: allow prompt to take in additional params
* feat: allow confirm tot ake in extra args
* feat: allow alert dialog to take in extra parameters
* chore: add tests for dialog methods
2024-05-08 10:10:09 -07:00
Aaron Dodson
08183863e7
refactor: split out block serialization for creating new blocks from the flyout ( #8065 )
...
* refactor: split out block serialization for creating new blocks from the flyout
* fix: add JSDoc.
* chore: satisfy the linter.
2024-05-03 12:27:55 -07:00
John Nesky
171befa746
fix!: Only fire intermediate events when editing input with invalid text. ( #8054 )
...
* fix: Fire intermediate events only when editing text input.
* Prefix unused arg with underscore.
* Fix tests.
2024-05-02 18:57:57 -07:00
Richard Knoll
4861c7d98a
fix: prevent duplication of comment icon bubbles ( #8053 )
2024-05-02 08:38:40 -07:00
Beka Westberg
93c4d75fbd
fix: comment highlight being positioned incorrectly in RTL ( #8044 )
2024-04-19 11:33:25 -07:00
Beka Westberg
69c5557e4f
chore: fix comments being resizable when readonly ( #8043 )
2024-04-19 11:15:56 -07:00
Beka Westberg
7246bbc0d1
fix: comment text input size in samples ( #8042 )
2024-04-19 08:37:35 -07:00
John Nesky
cee7f916bb
feat!: Invalid Blocks ( #7958 )
...
* feat: Invalid Blocks
* Rename the new json property from invalid to invalidReasons.
* Merged isValid into isEnabled.
* Minor fixes.
* More minor fixes.
* Reverting some stuff that didn't need to change.
* Addressing PR feedback.
* Update the BlockInfo interface to match State.
* Make BlockChange.disabledReason private.
2024-04-17 19:47:51 -07:00
Beka Westberg
7d8f88a4f1
chore: delete old comments ( #8038 )
...
* chore!: delete old comment classes and references
* chore: PR comments
2024-04-17 14:33:36 -07:00
Beka Westberg
a865744b7e
fix: bumping comments into bounds ( #8037 )
2024-04-17 14:02:46 -07:00
Beka Westberg
41fe298a62
fix: cut shortcut for workspace comments ( #8036 )
2024-04-17 13:53:57 -07:00
Beka Westberg
e21bb99ff1
feat!: Add context menu options for workspace comments ( #8035 )
...
* feat: add context menu support and migrate easy options
* feat: pass events to context menu options
* chore: migrate final comment context menu option
* feat: add exports for comment context menu items
* chore: PR comments
2024-04-17 13:02:53 -07:00
Beka Westberg
70f3f52911
fix: CSS for selected collapsed comments ( #8039 )
2024-04-17 09:48:43 -07:00
Beka Westberg
94dda6e668
fix: text input bubble css ( #8040 )
2024-04-17 09:47:51 -07:00
Beka Westberg
dabb11f4cb
feat!: add ability to copy and paste workspace comments ( #8024 )
...
* chore: add support for copying and pasting workspace comments
* chore: fix build
* fix: PR comments
2024-04-15 14:43:58 -07:00
Beka Westberg
b6753a250e
fix: more drag exports ( #8025 )
...
* fix: more drag exports I forgot about
* chore: fix date in copyright
2024-04-12 22:09:32 +00:00
Beka Westberg
d554053bd0
feat: add ability to delete workspace comments ( #8023 )
2024-04-11 13:22:50 -07:00
Beka Westberg
a0f821a239
fix: revert dragger name ( #8020 )
2024-04-11 13:22:17 -07:00
Beka Westberg
613c7335ee
chore: export some types and methods ( #8021 )
2024-04-11 08:38:50 -07:00
Beka Westberg
ee95b4c577
chore: rename method ( #8015 )
2024-04-09 10:57:03 -07:00
Mike Harvey
e2df0fc288
fix: correct dropdown arrow placement for Thrasos on Safari ( #8017 )
2024-04-08 14:56:36 -07:00
Beka Westberg
7491a50239
fix: compatibility with scroll plugin ( #8016 )
2024-04-08 13:17:03 -07:00
Beka Westberg
3e1e9b5ddc
fix: blocks not being returned to the correct layer if their drag is reverted with no parent ( #7998 )
...
* fix: blocks not being returned to the correct drag layer if their drag is reverted with no parent
* fix: delete test code
2024-04-08 09:44:31 -07:00
Beka Westberg
0cec8b1d29
fix: drag cursor not showing ( #7999 )
2024-04-08 09:23:49 -07:00
