Commit Graph

2147 Commits

Author SHA1 Message Date
Neil Fraser
c6b8cd69b5 Update newly added licenses.
The minimalist rendere was added while the licenses PR was waiting for review.
2019-10-02 15:33:42 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
31a2544989 Rename sample renderer to minimalist (#3137)
* Rename sample to minimalist
2019-10-02 14:16:36 -07:00
Sam El-Husseini
d28e897e47 Add a sample renderer instance. (#3136)
* Add a sample renderer instance.
2019-10-02 13:22:54 -07:00
Sam El-Husseini
99ce193b1f Base renderer next / prev connection fixes. (#3135) 2019-10-02 12:35:00 -07:00
Rachel Fenichel
d7cc808d1f Merge pull request #3134 from rachel-fenichel/bugfix/3098
Bound element position based on height of the row
2019-10-02 11:44:37 -07:00
Sam El-Husseini
1236660efd Actually make WS comments optional (#3130)
* Remove last reference to ws comments since its an optional module

* Also remove from workspace
2019-10-02 11:41:51 -07:00
Sam El-Husseini
f22603f32a Call onHide before clearing content (#3131) 2019-10-02 11:41:34 -07:00
Rachel Fenichel
6b78417ede Bound element position based on height of the row 2019-10-02 11:27:26 -07:00
Rachel Fenichel
ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Sam El-Husseini
d7a7c7b4d5 Support XML serialization in Node.js (#3126)
* Support XML serialization in Node.js
2019-10-01 14:40:35 -07:00
Beka Westberg
229dd69e54 Fixed review comments. 2019-09-30 15:32:17 -07:00
Beka Westberg
afbb2cca1e Moved all database related code out of headless and into rendered. 2019-09-27 18:00:06 -07:00
Beka Westberg
1baf7d1dcf Added a bunch of connection related tests. 2019-09-27 15:56:29 -07:00
alschmiedt
468b673b73 Fix bugs (#3108)
* Fix various bugs around keyboard nav
2019-09-27 14:34:28 -07:00
Rachel Fenichel
371a7c5807 Merge branch 'develop' into remove_debug 2019-09-27 12:47:44 -07:00
alschmiedt
b5a076d2b3 Add theme requires (#3114) 2019-09-27 12:36:16 -07:00
Sam El-Husseini
41e5914bd7 el.style is readonly in strict mode IE. Fixing crash in IE. (#3119) 2019-09-27 12:21:08 -07:00
Rachel Fenichel
0e1a4b68e1 Remove blockRendering.Debug, thrasos, and zelos from default requires.js 2019-09-27 12:01:06 -07:00
Neil Fraser
a2e6cfffcc Block comments from XML not fatal
…if Blockly.Comment was not compiled in.
2019-09-27 11:46:23 -07:00
Neil Fraser
b701475984 Simplify trashcan code (#3110)
Also delete unused props in CSS.
2019-09-27 11:43:56 -07:00
Sam El-Husseini
fc2c730e44 Make workspace comments an optional module, remove from this release. (#3115) 2019-09-27 11:15:11 -07:00
Monica Kozbial
f4136fdc2a Adding test and updating TODO. (#3102)
* Adding test and updating TODO.

* changing bug number referenced in TODO
2019-09-27 11:12:37 -07:00
Monica Kozbial
40e0d55187 Removing obsolete TODO comment. (#3104) 2019-09-27 11:12:11 -07:00
Neil Fraser
872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Neil Fraser
6650ecf13f Make dynamic variables be an optional module.
Also straighten out some dependencies.
2019-09-27 10:48:14 -07:00
Neil Fraser
4ed3295ad9 Make generator an optional module (#3105) 2019-09-27 10:47:10 -07:00
Sam El-Husseini
35424f2484 Angle field touch fixes (#3079)
* Fix touch support for angle fields
2019-09-26 17:11:03 -07:00
Sam El-Husseini
870824bc3e Workspace theme (#3093)
* Move the theme object so it's on the workspace.

* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
Monica Kozbial
22e79ae496 Updating behavior of register functions and adding unregister. (#3085)
* Updating behavior of register functions and adding unregister.

* Updates jsdoc comments.
2019-09-26 13:23:45 -07:00
Sam El-Husseini
a57c7ffb13 Clean up fields by passing the right type in fromJson (#3095) 2019-09-26 12:03:17 -07:00
alschmiedt
244bbe554b More navigation cleanup (#3100) 2019-09-26 11:13:47 -07:00
Neil Fraser
ddb04a3bc2 Partial code review of nav (#3091)
* Partial code review of nav

Had a few minutes free.

* Move getTopStackBlock to block

This is a generally useful function.
2019-09-26 10:19:40 -07:00
Neil Fraser
6ef84035ca Prevent dataset IDs from being renamed
The JS Compiler would rename ‘id’ and ‘blockId’ to something random.  Normally that would be fine, but if it ended up with a ‘$’ in the name, then that becomes an illegal HTML property name and Blockly crashes.

A bug that’s been lurking in Blockly for years and randomly surfaced on a recent compile.
2019-09-25 19:50:39 -07:00
Neil Fraser
75cf614104 Break CSS into modules. (#3084)
* Break CSS into modules.

Drops the compile test by 3 KB.
Remove obsolete .blocklyDraggable class stub (it used to be dynamically changed).
Remove unused menuseparator CSS.
2019-09-25 18:01:19 -07:00
Rachel Fenichel
269f0dc381 Enable eslint rule spaced-comment
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
alschmiedt
2c757aeb4d Cleanup navigation file (#3074)
* Cleanup navigation file
2019-09-25 13:57:42 -07:00
Monica Kozbial
e1e9513e86 Disconnect child block always for block.dispose(/* healStack */ true) (#3073)
* Disconnecting child block even if it cannot be connected to parent block.

* Bump disconnected child block.

* Added method for behavior on failed connection and updated expected behavior of unplug in unit tests.

* Removing obsolete TODO and calling new helper method in tests.
2019-09-25 10:47:29 -07:00
Neil Fraser
a03660243e Code cleanup, drop some CSS.
Random improvements to require statements.

Removal of some obviously dead CSS.

.blocklyDropDownDiv no longer supresses text selection (see comment in PR).

This PR drops the compiled size by 4 KB, which is larger than I was expecting.
2019-09-25 10:34:34 -07:00
Monica Kozbial
303a841685 Adding check for pushing last row with only empty dummy input. (#3081) 2019-09-24 13:41:26 -07:00
Neil Fraser
76af463ec4 Removing require for Blockly.FlyoutButton
Should have been in the previous PR, since that’s the point.

Also, a recompile given all the recent dependency changes.
2019-09-24 12:15:03 -07:00
Neil Fraser
6e76b6f49e Make flyout buttons be an optional module. 2019-09-24 10:58:33 -07:00
Neil Fraser
ddb8e46b87 Make flyouts be optional modules.
No Blockly instances need both Horizontal and Vertical flyouts.  Dropping one of these saves 2 KB.  Some don’t need flyouts at all (e.g. Blockly Games Puzzle or readonly documentation blocks).
2019-09-23 22:02:59 -07:00
Monica Kozbial
21c5698e98 Moving DARK_PATH_OFFSET to geras only. (#3066)
* Moving DARK_PATH_OFFSET to geras.

* Adding compressed and uncompressed files.

* Adding missing newlines

* Reverting commit of messages.

* Reverting compressed files.

* Updating compressed files.

* Addressing PR comments.

* Removing unecessary input overrides.
2019-09-23 15:57:59 -07:00
Neil Fraser
b84cda2c76 Strip out more bloat from toolbox (#3068)
Also removes three private accesses from workspaceSvg into toolbox tree.

The strategy for workspace.updateToolbox is no longer to clear and repopulate the toolbox, but rather to throw away the old toolbox and rebuild a new one.  This is simpler and more reliable.

This commit trims off another KB from the compiled code.
2019-09-23 15:18:32 -07:00
Neil Fraser
f550eb0c27 Uncomment requires
Although these requires aren’t required for advanced compilation, they are for simple compilation.
2019-09-23 14:16:00 -07:00
Sam El-Husseini
494487b37f Mark fields as dirty when the workspace becomes visible. (#3072)
* Mark fields as dirty when the workspace becomes visible.
2019-09-23 11:21:45 -07:00
Beka Westberg
593383e18a Changed variable field to use configuration (#3065)
* Changed variable field to use new configuration.
2019-09-23 11:14:03 -07:00
alschmiedt
f3b4fc0732 Fix interaction between mouse and keyboard (#3070) 2019-09-23 11:07:59 -07:00
alschmiedt
c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00