9238 Commits

Author SHA1 Message Date
Sam El-Husseini
36524a3b4a Only add a hat if there's no output connection or previous connection (#3280)
* Only add a hat if there's no output connection or previous connection
2019-10-17 14:08:06 -05:00
Navil Perez
bde1edff85 Add dragStart and dragEnd UI events 2019-10-17 11:41:31 -07:00
Neil Fraser
ce02665044 Replace static reserved word list with dynamic scan (#3269)
This change means the list is complete for every environment.  This makes evaling code more safe.  However it also means that code generated on one environment isn't guaranteed to be free of global collisions when executed on another environment (with the exception of the JS Interpreter).

So if you are generating code in Node, and then executing it with eval() in a user's browser a user's program could declare a variable named `location`, assign to it, and the browser will redirect to that URL.  Honestly, that's what you get for evaling untrusted code between users.  Use the JS Interpreter if you are doing anything other than just generating and executing in the same environment.
2019-10-17 11:17:37 -07:00
Sam El-Husseini
664cc3d6cd Fix warnings related to number of arguments passed. (#3270) 2019-10-17 11:47:30 -05:00
Sam El-Husseini
526528354f Fix 10 warnings related to visibility (#3275) 2019-10-17 11:46:57 -05:00
Sam El-Husseini
7f41532717 Print the output of the closure compiler in the console after a debug compile. (#3272) 2019-10-17 11:44:41 -05:00
Rachel Fenichel
5c8a5e3007 Merge pull request #3259 from rachel-fenichel/release_tasks
Rebuild task in gulp.
2019-10-17 10:27:06 -06:00
Rachel Fenichel
90f6948c27 Remove unnecessary stash 2019-10-17 10:21:55 -06:00
Sam El-Husseini
c1c9121fcc Fix jsdoc. @return instead of @returns (#3271)
* Fix jsdoc. @return instead of @returns
2019-10-16 17:01:36 -05:00
Beka Westberg
8407428e8f Reverted scrollbar resize change. (#3274) 2019-10-16 16:54:47 -05:00
Rachel Fenichel
b4b3ae316f Merge pull request #3224 from zochris/variable-exists-phrasing
Rephrase "variable already exists" message
2019-10-16 12:37:15 -06:00
Rachel Fenichel
d45da54bef Merge pull request #3267 from rachel-fenichel/bugfix_1714
Fix #1714
2019-10-16 11:59:09 -06:00
Rachel Fenichel
35e894af13 Fix #1714 2019-10-16 11:53:08 -06:00
Rachel Fenichel
17f47ee2cb Make git-sync-master as well as git-sync-develop 2019-10-16 11:29:54 -06:00
Rachel Fenichel
90f529603e Review feedback 2019-10-16 11:22:42 -06:00
Sam El-Husseini
3c2c4677df Fix 55 warnings related to flyouts. (#3211)
* Fix 55 warnings related to flyouts.
2019-10-16 12:13:37 -05:00
Sam El-Husseini
986e965be8 Private/protected visibility cleanup (#3263)
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
Neil Fraser
01b6992efd Normalize to one spelling of color/colour. 2019-10-16 09:46:47 -07:00
Sam El-Husseini
267deceb82 Dropdowndiv positioning (#3212)
* Fix positioning of the dropdown div
2019-10-16 10:20:40 -05:00
Neil Fraser
2eaabd180d Minor cleanup in keyboard nav (#3264)
* Clean cursor code

Some obvious inefficiencies that jumped out while randomly browsing the compiled code.

* Typos

* Multiplying by minus one.
2019-10-16 08:19:37 -05:00
Neil Fraser
013f2714a3 Cleanup aria usage. (#3261)
Use enums instead of arbitrary strings.
Delete unused Aria properties
Add missing requires.
Delete unused code.
2019-10-15 22:43:23 -07:00
Sam El-Husseini
2224bb2a4e More field dispose (#3201)
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Sam El-Husseini
e411077b9f Fix blocks tests (#3252) 2019-10-15 17:36:33 -05:00
Rachel Fenichel
07d6f33db9 Rebuild task in gulp. 2019-10-15 15:05:50 -06:00
Beka Westberg
8f73fdb512 Fixed comments in trashcan. 2019-10-15 13:02:02 -07:00
Beka Westberg
b2a8172720 Fixed disabled blocks in trashcan. 2019-10-15 13:02:02 -07:00
alschmiedt
a9420154a2 Update todos so they are no longer in jsdocs (#3250) (#3257) 2019-10-15 10:14:39 -07:00
alschmiedt
ef859d351d Fix jsdoc syntax (#3246) 2019-10-15 09:28:37 -07:00
Rachel Fenichel
921e00b0d0 Merge pull request #3256 from rachel-fenichel/cp_3202
Cherry-pick #3202 and bump patch version
3.20191014.1
2019-10-15 10:17:39 -06:00
Rachel Fenichel
09687cb387 Rebuild and bump patch number 2019-10-15 10:10:42 -06:00
Sam El-Husseini
863a4a52d9 Revert calling onHide before the animation is complete to avoid double click issues. (#3202) 2019-10-15 10:08:30 -06:00
Thomas Ballinger
b913295028 restart cursor animation on cursor move (#3226) 2019-10-15 09:01:03 -07:00
Noah Glaser
8eb003f01f Fix capitolization error 2019-10-14 23:25:34 -07:00
Noah Glaser
15a6fa7cb4 Fix capitolization error 2019-10-14 23:24:22 -07:00
alschmiedt
af72df58ae Update todos so they are no longer in jsdocs (#3250) 2019-10-14 19:39:26 -07:00
alschmiedt
8874e58f91 Fix jsdoc syntax (#3242) 2019-10-14 14:22:09 -07:00
Rachel Fenichel
b9473fefa8 Merge pull request #3240 from google/rachel-fenichel-patch-1
Update package.json
2019-10-14 13:25:03 -07:00
Rachel Fenichel
d35bc19bff Merge pull request #3239 from rachel-fenichel/bump_versions
Update version numbers
3.20191014.0
2019-10-14 13:20:36 -07:00
Rachel Fenichel
fc6e1bd529 Rebuild to pull in new version number 2019-10-14 14:16:38 -06:00
Rachel Fenichel
e11c7b0488 Update package.json 2019-10-14 14:02:43 -06:00
Rachel Fenichel
cffb126f37 Update version numbers 2019-10-14 14:01:14 -06:00
Rachel Fenichel
23a78c89e4 Merge pull request #3165 from google/rc/Oct_19
October 2019 release candidate (Q3 2019)
2019-10-14 12:59:11 -07:00
Rachel Fenichel
ae111744b6 Rebuild 2019-10-14 12:55:48 -06:00
RoboErikG
52a6992dfc Remove multi-line comments to avoid escaping (#3231) (#3232)
Fixes #3230 by removing multi-line comments for procedures.
2019-10-14 11:22:08 -07:00
RoboErikG
e62c2a3f6b Remove multi-line comments to avoid escaping (#3231)
Fixes #3230 by removing multi-line comments for procedures.
2019-10-14 10:40:22 -07:00
RoboErikG
d09b85dc9e Cleanup for #3179 (#3229) 2019-10-14 09:57:38 -07:00
translatewiki.net
c98bf02012 Localisation updates from https://translatewiki.net. 2019-10-14 17:17:03 +02:00
zochris
f26829eb6d Change variable exists message to show casing 2019-10-13 20:39:06 +02:00
zochris
bf7abee679 Rephrase "variable already exists" message
The message now includes the name with casing of the already existing
variable.
2019-10-13 14:39:03 +02:00
Josh Lory
43f9ab6889 Look up notch height from the current renderer (#3217) 2019-10-11 15:30:26 -07:00