Aaron Dodson
b0169ab724
fix: use the correct with in getBoundingRectangleWithoutChildren().
2024-07-10 15:54:56 -07:00
Aaron Dodson
fa15cda950
feat: allow fetching block bounds not including children. ( #8284 )
...
* feat: allow fetching block bounds not including children.
* chore: run formatter.
* chore: run the other formatter.
* fix: don't include subsequent blocks in the childless bounding rect.
* chore: remove logging.
2024-07-10 14:52:07 -07:00
Aaron Dodson
8323642d0e
fix: export the layer constants. ( #8256 )
...
* fix: export the layer constants.
* refactor: remove @internal annotations from layer constants.
2024-07-09 15:25:20 -07:00
Aaron Dodson
a6361fbd81
chore: make getEventWorkspace_() public ( #8241 )
2024-07-02 14:48:16 -07:00
Aaron Dodson
21a73c463f
fix: correctly report the pre-resize-drag size to workspace comment size change listeners ( #8240 )
...
* fix: correctly report the pre-resize-drag size to workspace comment size change listeners
* chore: run formatter
* refactor: implicitly use the presence of preResizeSize to identify a drag.
2024-07-02 14:42:47 -07:00
John Nesky
9a0619aa2a
fix: Drag and Resize events for workspace comments ( #8217 )
...
* feat: Added a comment_drag event.
* Add workspace comment resize events.
* Addressing PR feedback.
* Fixed chai imports in new test files.
* Addressing more PR feedback.
2024-06-26 12:16:56 -07:00
Maribeth Bottorff
3fa46f45fe
chore: tsdoc for generator exceptions ( #8214 )
...
* chore: tsdoc for generator exceptions
* chore: missed a period
2024-06-13 17:07:24 -07:00
Beka Westberg
dc91c3ab54
fix: c-blocks disappearing ( #8203 )
2024-06-11 11:21:48 -07:00
Mark Friedman
5881ce32c1
fix: change which element keydown is bound to from document to injection div ( #8188 )
...
* Change which element keydown is bound to
* Modify keydown tests
* Use browserEvents.conditionalBind()
* Remove commented out code.
2024-05-31 23:19:46 +01:00
Beka Westberg
c3d41cfd9f
fix: comment body height too short ( #8182 )
2024-05-29 11:13:43 -07:00
Beka Westberg
6e4ba00be5
fix: dragging and disposing of shadows ( #8172 )
...
* Revert "fix: dragging blocks by shadows to delete (#8138 )"
This reverts commit 3fd749205f
2024-05-28 10:28:16 -07:00
Maribeth Moffatt
c4287d1276
chore: format
2024-05-23 16:13:52 -07:00
Maribeth Moffatt
5d3ae222e7
feat: paste in viewport
2024-05-23 16:13:39 -07:00
Maribeth Moffatt
4040e78ffb
Revert "feat: Paste block in viewport / near cursor ( #7521 )"
...
This reverts commit c37f4b8749
2024-05-23 11:06:46 -07:00
Maribeth Moffatt
7c6fbec23c
Merge branch 'osd' into merge-osd
2024-05-23 10:59:53 -07:00
John Nesky
9b2ab79e73
fix: Only hide WidgetDiv if it is associated with the affected workspace. ( #8150 )
...
* Associate a workspace with WidgetDiv.
* Minor fixes after merging.
* Hide widget if owner is in an unknown workspace.
2024-05-20 12:48:05 -07:00
Maribeth Bottorff
28de9ef494
fix: paste in a better spot ( #8123 )
...
* fix: paste in a better spot
* fix: include bump offset
* chore: rename param
---------
Co-authored-by: Beka Westberg <bwestberg@google.com >
2024-05-20 10:09:47 -07:00
Neil Fraser
fcdb8fc33d
fix: Normalize CSS between comment types ( #8161 )
...
Merge the CSS so that both comment types (block and workspace) are the same -- other than a border.
2024-05-20 18:59:24 +02:00
Beka Westberg
7c4b0bd703
fix: delete area animation ( #8149 )
...
* fix: delete area animation
* chore: format
* Update core/dragging/dragger.ts
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com >
---------
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com >
2024-05-20 09:58:48 -07:00
Beka Westberg
139b4b993f
fix: creating comments in RTL ( #8153 )
2024-05-20 09:54:30 -07:00
Neil Fraser
70ca676c24
fix: Properly size comments. ( #8158 )
...
* Properly size comments.
Fixes multiple rendering and sizing issues across different browsers.
Tip: `text-overflow: hidden;` is not legal CSS and did nothing.
Resolves #8142
2024-05-20 09:30:38 -07:00
Beka Westberg
36b75696a2
fix: comment text area bottom border hidden ( #8152 )
2024-05-20 09:03:59 -07:00
Beka Westberg
69db8a63d6
fix: comment size not respecting collapsed-ness ( #8136 )
...
* fix: comment size not respecting collapsed-ness
* chore: fix tests the only way I know how, by adding explicit clock ticks
2024-05-17 13:23:13 -07:00
Beka Westberg
3fd749205f
fix: dragging blocks by shadows to delete ( #8138 )
...
* Revert "fix: dragging shadow blocks (#7992 )"
This reverts commit c0e6e6745f
2024-05-17 13:22:53 -07:00
Neil Fraser
5a8969f855
fix: Zelos comments shouldn't be bold ( #8141 )
...
Resolves #8061
2024-05-17 21:33:52 +02:00
Beka Westberg
12ff96674b
fix: comment handle position in RTL ( #8151 )
2024-05-17 12:27:14 -07:00
Beka Westberg
75d81620ab
fix: undoing block delete over trashcan creates block in wrong place ( #8126 )
2024-05-17 12:26:10 -07:00
Maribeth Bottorff
80cacdcad7
Merge pull request #8140 from maribethb/grabby
...
fix: change cursor to grab on ws comment bar
2024-05-17 09:47:45 -07:00
Beka Westberg
44db3edce3
fix: comment move events and snapping ( #8127 )
2024-05-17 08:26:23 -07:00
Maribeth Moffatt
e4b734c0db
fix: change cursor to grab on ws comment bar
2024-05-16 17:54:28 -07:00
Sam El-Husseini
23af202796
fix: workspace comment bounding box affecting RTL zoom ( #8125 )
2024-05-16 10:36:36 -07:00
Sampada Bhujel
049993405e
fix: JSON deserialization not firing variable create events for blocks ( #8122 )
...
* fix: JSON deserialization not firing variable create events for blocks
* fix: extract logic for checking added variables and firing event to checkNewVariables function
2024-05-15 15:46:23 -07:00
Beka Westberg
dfcf5317c1
fix: throwing errors for chameleon blocks ( #8121 )
2024-05-15 12:51:55 -07:00
Beka Westberg
dd9619dc94
fix: extra insertion markers being created ( #8120 )
...
* fix: extra insertion markers being created
* chore: remove unused value
2024-05-15 10:44:13 -07:00
Beka Westberg
e2eba2879d
fix: connection db error for insertion markers ( #8109 )
2024-05-15 08:27:43 -07:00
Beka Westberg
392a38bb2e
fix: drag cursor being incorrect for flyout blocks ( #8107 )
2024-05-14 13:24:20 -07:00
Neil Fraser
fca94ce799
fix: Remove deprecation warnings for 'disabled'. ( #8104 )
...
We must continue to support existing XML and JSON serialization formats since they are in external databases.
The decision was taken not to make the save formats compatible with older versions of Blockly. We could not think of a convincing use-case for a newer Blockly's output to be read by an older Blockly. If such a case appears, then our decision should change.
Resolves #8095 .
2024-05-14 08:55:43 -07:00
Maribeth Moffatt
0255c580f7
Merge branch 'develop' into merge-v11
2024-05-13 11:20:39 -07:00
Neil Fraser
c0298652af
feat: Add snapping to workspace comments. ( #8070 )
...
Now that there are two things that snap (blocks and WS comments), the alignment code in being moved to a common place.
2024-05-12 23:16:26 +02:00
Maribeth Bottorff
28ac0c4473
fix: improve types in FieldRegistry ( #8062 )
...
* fix: improve types in FieldRegistry
* chore: tsdoc
2024-05-10 14:14:50 -07:00
Beka Westberg
c704d5a887
revert: "feat: allow the dialog methods to take in extra parameters ( #8084 )" ( #8085 )
...
This reverts commit 278006b5f8
2024-05-10 11:12:15 -07:00
Maribeth Bottorff
54eeb85d89
fix!: add getContents to IFlyout ( #8064 )
2024-05-08 11:44:00 -07:00
Beka Westberg
278006b5f8
feat: allow the dialog methods to take in extra parameters ( #8084 )
...
* feat: allow prompt to take in additional params
* feat: allow confirm tot ake in extra args
* feat: allow alert dialog to take in extra parameters
* chore: add tests for dialog methods
2024-05-08 10:10:09 -07:00
Aaron Dodson
08183863e7
refactor: split out block serialization for creating new blocks from the flyout ( #8065 )
...
* refactor: split out block serialization for creating new blocks from the flyout
* fix: add JSDoc.
* chore: satisfy the linter.
2024-05-03 12:27:55 -07:00
John Nesky
171befa746
fix!: Only fire intermediate events when editing input with invalid text. ( #8054 )
...
* fix: Fire intermediate events only when editing text input.
* Prefix unused arg with underscore.
* Fix tests.
2024-05-02 18:57:57 -07:00
Richard Knoll
4861c7d98a
fix: prevent duplication of comment icon bubbles ( #8053 )
2024-05-02 08:38:40 -07:00
Beka Westberg
93c4d75fbd
fix: comment highlight being positioned incorrectly in RTL ( #8044 )
2024-04-19 11:33:25 -07:00
Beka Westberg
69c5557e4f
chore: fix comments being resizable when readonly ( #8043 )
2024-04-19 11:15:56 -07:00
Beka Westberg
7246bbc0d1
fix: comment text input size in samples ( #8042 )
2024-04-19 08:37:35 -07:00
John Nesky
cee7f916bb
feat!: Invalid Blocks ( #7958 )
...
* feat: Invalid Blocks
* Rename the new json property from invalid to invalidReasons.
* Merged isValid into isEnabled.
* Minor fixes.
* More minor fixes.
* Reverting some stuff that didn't need to change.
* Addressing PR feedback.
* Update the BlockInfo interface to match State.
* Make BlockChange.disabledReason private.
2024-04-17 19:47:51 -07:00
