Commit Graph

4256 Commits

Author SHA1 Message Date
Beka Westberg e09a7b8165 Renamed doNotCallTrackConnections_ to callTrackConnections. Flipped logic. Moved it to the constructor. 2019-10-05 12:28:25 -07:00
Beka Westberg f217320154 Unskipped tests. 2019-10-01 19:27:47 -07:00
Beka Westberg df5b5766c1 General cleanup. 2019-10-01 19:22:19 -07:00
Beka Westberg 5aaab251a3 Changed all other known 'hiding' references to 'tracking'. 2019-10-01 19:02:02 -07:00
Beka Westberg 08720929d3 Changed setConnectionsHidden to waitToTrackConnections and startTrackingConnections. 2019-10-01 19:00:53 -07:00
Beka Westberg 9d47e2b34e Fixed adding and removing from connection DB (will be cleaned up a future PR, but I want to focus on cleaning connections). 2019-10-01 16:58:33 -07:00
Beka Westberg d4e0594c2c Combined inDB_ and hidden_ into single tracked_ property. 2019-10-01 16:55:29 -07:00
Sam El-Husseini d7a7c7b4d5 Support XML serialization in Node.js (#3126)
* Support XML serialization in Node.js
2019-10-01 14:40:35 -07:00
Rachel Fenichel ae5c7527b6 Merge pull request #3125 from BeksOmega/fixes/MoveDbToRendered
Connection Tracking Pt 2: Moved all database related code out of headless
2019-10-01 14:05:12 -07:00
translatewiki.net c782889975 Localisation updates from https://translatewiki.net. 2019-10-01 16:25:49 +02:00
Beka Westberg 229dd69e54 Fixed review comments. 2019-09-30 15:32:17 -07:00
Beka Westberg afbb2cca1e Moved all database related code out of headless and into rendered. 2019-09-27 18:00:06 -07:00
Rachel Fenichel d26d220f85 Merge pull request #3123 from BeksOmega/tests/Connections
Connection Tracking Pt 1: Added a bunch of connection related tests
2019-09-27 16:44:16 -07:00
Beka Westberg d5e9e4c3b4 Removed TODO. 2019-09-27 16:38:37 -07:00
Beka Westberg 1baf7d1dcf Added a bunch of connection related tests. 2019-09-27 15:56:29 -07:00
alschmiedt 468b673b73 Fix bugs (#3108)
* Fix various bugs around keyboard nav
2019-09-27 14:34:28 -07:00
Sam El-Husseini edf3d0cfe2 Don't require everything in uncompressed. (#3120)
* Don't require everything in uncompressed.
2019-09-27 14:26:10 -07:00
Neil Fraser 27f554c647 Strip out unused Closure functions (#3121)
No functional changes.
2019-09-27 13:30:53 -07:00
Rachel Fenichel 548d80e1c3 Merge pull request #3118 from rachel-fenichel/remove_debug
Remove blockRendering.Debug, thrasos, and zelos from default requires.js
2019-09-27 13:15:49 -07:00
Rachel Fenichel 371a7c5807 Merge branch 'develop' into remove_debug 2019-09-27 12:47:44 -07:00
alschmiedt b5a076d2b3 Add theme requires (#3114) 2019-09-27 12:36:16 -07:00
Sam El-Husseini 41e5914bd7 el.style is readonly in strict mode IE. Fixing crash in IE. (#3119) 2019-09-27 12:21:08 -07:00
Rachel Fenichel 0e1a4b68e1 Remove blockRendering.Debug, thrasos, and zelos from default requires.js 2019-09-27 12:01:06 -07:00
Neil Fraser a2e6cfffcc Block comments from XML not fatal
…if Blockly.Comment was not compiled in.
2019-09-27 11:46:23 -07:00
Neil Fraser b701475984 Simplify trashcan code (#3110)
Also delete unused props in CSS.
2019-09-27 11:43:56 -07:00
Sam El-Husseini fc2c730e44 Make workspace comments an optional module, remove from this release. (#3115) 2019-09-27 11:15:11 -07:00
Monica Kozbial 328f2c3373 Removing deprecated renderMode reference in playground. (#3107) 2019-09-27 11:12:49 -07:00
Monica Kozbial f4136fdc2a Adding test and updating TODO. (#3102)
* Adding test and updating TODO.

* changing bug number referenced in TODO
2019-09-27 11:12:37 -07:00
Monica Kozbial 40e0d55187 Removing obsolete TODO comment. (#3104) 2019-09-27 11:12:11 -07:00
Neil Fraser 872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Neil Fraser 6650ecf13f Make dynamic variables be an optional module.
Also straighten out some dependencies.
2019-09-27 10:48:14 -07:00
Neil Fraser 4ed3295ad9 Make generator an optional module (#3105) 2019-09-27 10:47:10 -07:00
Sam El-Husseini 6a771a8636 Remove old node module, update tests to use the npm one. (#3111) 2019-09-27 10:32:52 -07:00
Sam El-Husseini 35424f2484 Angle field touch fixes (#3079)
* Fix touch support for angle fields
2019-09-26 17:11:03 -07:00
Sam El-Husseini 870824bc3e Workspace theme (#3093)
* Move the theme object so it's on the workspace.

* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
alschmiedt b587ad71c5 Fix changing category color in multi playground (#3103) 2019-09-26 16:05:47 -07:00
Monica Kozbial 22e79ae496 Updating behavior of register functions and adding unregister. (#3085)
* Updating behavior of register functions and adding unregister.

* Updates jsdoc comments.
2019-09-26 13:23:45 -07:00
Monica Kozbial 8619ad1a0a Re-enable block delete test. (#3088) 2019-09-26 13:19:25 -07:00
Sam El-Husseini a57c7ffb13 Clean up fields by passing the right type in fromJson (#3095) 2019-09-26 12:03:17 -07:00
alschmiedt 244bbe554b More navigation cleanup (#3100) 2019-09-26 11:13:47 -07:00
Neil Fraser ddb04a3bc2 Partial code review of nav (#3091)
* Partial code review of nav

Had a few minutes free.

* Move getTopStackBlock to block

This is a generally useful function.
2019-09-26 10:19:40 -07:00
Neil Fraser 6ef84035ca Prevent dataset IDs from being renamed
The JS Compiler would rename ‘id’ and ‘blockId’ to something random.  Normally that would be fine, but if it ended up with a ‘$’ in the name, then that becomes an illegal HTML property name and Blockly crashes.

A bug that’s been lurking in Blockly for years and randomly surfaced on a recent compile.
2019-09-25 19:50:39 -07:00
Neil Fraser 75cf614104 Break CSS into modules. (#3084)
* Break CSS into modules.

Drops the compile test by 3 KB.
Remove obsolete .blocklyDraggable class stub (it used to be dynamically changed).
Remove unused menuseparator CSS.
2019-09-25 18:01:19 -07:00
Rachel Fenichel 06d65b81c7 Merge pull request #3092 from rachel-fenichel/lint_spacing
Enable eslint rule spaced-comment
2019-09-25 17:31:50 -07:00
Rachel Fenichel 269f0dc381 Enable eslint rule spaced-comment
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
RoboErikG e69db137a7 Add a test for built file size (#3075)
* Add a test for built file size

Adds a script test for building Blockly's compressed files and
checking their size to prevent unexpected increases.

* Update size for new changes

* Add full stop
2019-09-25 15:03:31 -07:00
alschmiedt 2c757aeb4d Cleanup navigation file (#3074)
* Cleanup navigation file
2019-09-25 13:57:42 -07:00
Monica Kozbial e1e9513e86 Disconnect child block always for block.dispose(/* healStack */ true) (#3073)
* Disconnecting child block even if it cannot be connected to parent block.

* Bump disconnected child block.

* Added method for behavior on failed connection and updated expected behavior of unplug in unit tests.

* Removing obsolete TODO and calling new helper method in tests.
2019-09-25 10:47:29 -07:00
Neil Fraser a03660243e Code cleanup, drop some CSS.
Random improvements to require statements.

Removal of some obviously dead CSS.

.blocklyDropDownDiv no longer supresses text selection (see comment in PR).

This PR drops the compiled size by 4 KB, which is larger than I was expecting.
2019-09-25 10:34:34 -07:00
Monica Kozbial 303a841685 Adding check for pushing last row with only empty dummy input. (#3081) 2019-09-24 13:41:26 -07:00